New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782205 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Xoogler
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task

Blocked on:
issue 786385

Blocking:
issue 783201



Sign in to add a comment

Rename "Memory Infra Tester" to "Android Memory Infra Tester" and move to chromium.perf.fyi

Project Member Reported by kraynov@chromium.org, Nov 7 2017

Issue description

It would be more clear, since Memory Infra Tester is Android only.

 
Components: Infra>Client>Android
Did you want to move it to the chromium.perf.fyi waterfall as well? (Right now it's on chromium.android.fyi)
Yes, we want to move it.
Maybe call it "Memory Infra Perf FYI" then?
I would avoid putting FYI in the bot name.
Ok, "Memory Infra Perf" sgtm
Owner: bpastene@chromium.org
Status: Assigned (was: Untriaged)
Summary: Rename "Memory Infra Tester" to "Android Memory Infra Tester" and move to chromium.perf.fyi (was: Rename "Memory Infra Tester" to "Android Memory Infra Tester"?)
Ok, I can get to this sometime next week. (If you'd rather it be done before then, you're more than welcome to take a stab at it yourself.)
Fix comment 5
"Android Memory Infra Perf" I meant
Blocking: 783201
Labels: -Pri-3 Pri-2
Friendly ping on this :)
Cc: martiniss@chromium.org bpastene@chromium.org
Components: -Infra>Client>Android Infra>Client>Perf
Owner: ----
Status: Available (was: Assigned)
Just looked into it. I forgot how special-case perf's recipe & testing configs are. Given that this bot has specific compiler flags, is a builder-tester, and runs swarming tests that don't have device-affinity, this seems like it's going to require some novel support to both of those
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py
and
https://cs.chromium.org/chromium/src/tools/perf/core/perf_data_generator.py

Moving this over to the perf queue.
Cc: eyaich@chromium.org
I have a clarifying question given I am late to this game. 

Why are we adding new linux and android bots instead of adding these performance tests to the existing configurations?  Given our overhaul of the configurations on the chromium.perf master I would like to understand the need for new hardware. 
Ok is it appropriate to run contrib benchmarks on non-FYI waterfall?
We can't promise a support level expected for normal benchmarks (sheriffing, etc.)
eyaich@: for benchmarks that perf team are not willing to provide support & sheriffing, we let them run it on perf FYI.
Owner: kraynov@chromium.org
kraynov@: you can migrate your heap_profiling.mobile.* benchmarks to perf FYI now.

The way to do this:

1) Add your benchmarks to https://cs.chromium.org/chromium/src/tools/perf/chromium.perf.fyi.extras.json (see example in "Android Nexus 5X Perf FYI")
2) run: tools/perf/generate_perf_data
3) Upload CL

Blockedon: 786385
Status: Fixed (was: Available)
Resolved different way in https://crbug.com/786385

Sign in to add a comment