New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782201 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 605657
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression :Unwanted blank space is seen on chrome extension overlay .

Reported by pranjali...@etouch.net, Nov 7 2017

Issue description

Chrome Version:64.0.3260.2 (Official Build) 05d1d20e2db6d594b98fe87d7aa500f22aba70a6-refs/branch-heads/3260@{#3}(32/64 bit)

OS:Windows (7,8,10),Linux (14.04 LTS),Mac(10.12.6).

Test URL: https://chrome.google.com/webstore/detail/tripadvisor-browser-butto/oiekdmlabennjdpgimlcpmphdjphlcha?utm_source=chrome-ntp-icon

Precondition:Enable 'Material Design in the rest of the browser's native UI' flag.

Steps to reproduce:
1.Launch chrome ,go to the above URL and click on Add to chrome button.
2.Observe Add extension overlay.  

Actual Result:Unwanted blank space is seen on chrome extension overlay .
Expected Result:blank space should not be  seen on chrome extension overlay .

This is Regression issue broken in 'M-60' and Using the per-revision bisect providing the bisect results,
Good Build:60.0.3080.0
Bad Build:60.0.3081.0

You are probably looking for a change made after 467033 (known good), but no later than 467034 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

  https://chromium.googlesource.com/chromium/src/+log/7f2bb229d2728e932a8f50a881e792bfb803efc0..302ecd60a8d39c4684bb148fbead2097d9b989d9

Suspect:https://chromium.googlesource.com/chromium/src/+/302ecd60a8d39c4684bb148fbead2097d9b989d9
 
Actual_result.png
386 KB View Download
Expected_result.png
406 KB View Download
Owner: ----
Status: Unconfirmed (was: Assigned)
This is not in my area of expertise, and is definitely not caused by the CL mentioned. Could someone working on extensions please take a look? Thanks.
Labels: hasbisect-per-revision
Owner: ellyjo...@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 467030 (known good), but no later than 467031 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

  https://chromium.googlesource.com/chromium/src/+log/aeb180b1bc8066c2095c124d55e744be0124f020..ce9d455e92cf41f171d31093cee055e41d634ea9

Suspect:https://chromium.googlesource.com/chromium/src/+/ce9d455e92cf41f171d31093cee055e41d634ea9
This is probably my fault. I'll take a look today.
Cc: bsep@chromium.org
The dialog's native width is 362, and it's being snapped to a width of 448 for Harmony. That's fine - but the layout of it isn't adjusting to match.

bsep@: you're touching the extension dialogs, right? does that include this one? otherwise I can look at why the layout is behaving this way - I bet it's because this dialog tries to impose a fixed width on its contents.
layout.png
25.8 KB View Download
layout-nosnap.png
25.9 KB View Download

Comment 5 by bsep@chromium.org, Nov 28 2017

Mergedinto: 605657
Status: Duplicate (was: Assigned)
Yeah, that one is covered by  bug 605657 . The new design is pretty different, so I don't think we need a separate bug for this.

Sign in to add a comment