Issue metadata
Sign in to add a comment
|
Mac: Cmd+t works when the browser window has a window-modal sheet
Reported by
db...@etouch.net,
Nov 7 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 64.0.3261.0 Revision aac97fe5f3cb5890bedac2a2ba9fec6b3e8c16fc-refs/heads/master@{#514329}(32/64 bit) OS: Mac OS X(10.12.6,10.13.2) What steps will reproduce the problem? (1) Launch chrome, navigate to chrome://apps. (2) Right click on any app and Select 'Remove from chrome' option. (3) Press Ctrl+T and observe. Actual: Unnecessary 'Remove dialog box' is seen on NTP after pressing Ctrl+T Expected: 'Remove dialog box' should not seen on NTP or should disappear after switching tab. This is a regression issue, broken in 'M-64', below is bisect info: Good Build: 64.0.3260.0 Bad Build: 64.0.3261.0 You are probably looking for a change made after 514116 (known good), but no later than 514117 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/04f1082efb63369e19ace6dde8b62c8702303b88..6b6e8fe1fcf17e0545c688d1bfda16d6f79fd97e Suspect: https://chromium.googlesource.com/chromium/src/+/6b6e8fe1fcf17e0545c688d1bfda16d6f79fd97e Note: Issue is not seen on Windows and Linux OS.
,
Nov 8 2017
Hm. this is different, but I'm not sure it's wrong. The dialog is window modal, not tab modal, so shouldn't be dismissed when the tab changes. You can compare this to the `Save` dialog you get when you press Cmd+s. With that dialog open, you can press Cmd+t and a new tab opens with the 'Save' dialog remaining open. Since extension uninstall requests a window-modal, it gets a dialog consistent with that behaviour. To fix, we could make the extension uninstall dialog tab-modal when triggered from the NTP. Or we could block (some/all) commands when windows have a modal sheet on them. Not sure if this is a blocker.
,
Nov 8 2017
Some observations: * On Windows and Chrome OS, you can't use ctrl-t when the extension uninstall dialog is open. * On Chrome OS, you can use ctrl-t when the Save (ctrl-s) menu is open, but NOT the actual new-tab button. On Windows, you can't use either. So I don't think this was ever really consistent. In this case I'm not too concerned, because extension uninstalling isn't really a tab-specific action. Closing this. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Nov 8 2017