New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782190 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 710629
issue 733875



Sign in to add a comment

cros_vm doesn't launch with cros qemu images with lkgm versions > 10070.0.0

Project Member Reported by achuith@chromium.org, Nov 7 2017

Issue description

Enter simple chrome sdk:
achuith@achuith:~/code/chrome/src$ cros chrome-sdk --log-level=debug --download-vm --board=amd64-generic --clear-sdk-cache

Launch cros vm:
(sdk amd64-generic R64-10090.0.0-b20139) achuith@achuith ~/code/chrome/src $ cros_vm --start

VM fails to launch.

This is blocking efforts to run chromeos tests in the chromium waterfall, and making gardening harder.


 
Screenshot from 2017-11-06 10_33_43.png
14.4 KB View Download
Blockedon: 772568
Blockedon: -772568 710629
Blockedon: 733875
Cc: dpranke@chromium.org
Labels: -Pri-0 Pri-1
Owner: achuith@chromium.org
Status: Started (was: Assigned)
Summary: cros_vm doesn't launch with cros qemu images with lkgm versions > 10070.0.0 (was: cros_vm doesn't launch)
Cc: ihf@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/22bfedfc41149afecfba24ec04ba6b35af3fc6c4

commit 22bfedfc41149afecfba24ec04ba6b35af3fc6c4
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Wed Nov 15 05:52:42 2017

[cros_vm]: Use virtio instead of cirrus.

* Deprecate support for qemu less than 2.6.0
* format=raw is necessary for 2.6.0
* chromeos guest images no longer support cirrus, but support virtio.

BUG= chromium:782190 
TEST=manual

Change-Id: I036572d76dee14dafe4433cae6b328424e63a4c8
Reviewed-on: https://chromium-review.googlesource.com/758263
Commit-Ready: Achuith Bhandarkar <achuith@chromium.org>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/22bfedfc41149afecfba24ec04ba6b35af3fc6c4/scripts/cros_vm.py

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/0197a13d2edfb660fa5cbe6fcafad3096698f8b5

commit 0197a13d2edfb660fa5cbe6fcafad3096698f8b5
Author: Allen Webb <allenwebb@google.com>
Date: Wed Nov 15 05:52:41 2017

[image_to_vm.sh]: Recomment virtio instead of cirrus.

BUG= chromium:782190 
TEST=manual

Change-Id: I263de0a09797326945062ed7156125a323d2e5dc
Reviewed-on: https://chromium-review.googlesource.com/770095
Commit-Ready: Allen Webb <allenwebb@google.com>
Tested-by: Allen Webb <allenwebb@google.com>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>

[modify] https://crrev.com/0197a13d2edfb660fa5cbe6fcafad3096698f8b5/image_to_vm.sh

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/docs/+/deee88d6c4abac0e871a542a1f2a595ab7c131cc

commit deee88d6c4abac0e871a542a1f2a595ab7c131cc
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Sat Nov 18 04:18:53 2017

Update cros_vm.md.

* Add instructions on downloading QEMU, since stock trusty
qemu is not supported with cros images > lkgm version 10070.0.0
* Update --cmd syntax.

BUG= chromium:782190 
TEST=NONE

Change-Id: Ieb71b8d74e58eb1fda4d97353c871bb2b973743b
Reviewed-on: https://chromium-review.googlesource.com/769245
Commit-Ready: Achuith Bhandarkar <achuith@chromium.org>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/deee88d6c4abac0e871a542a1f2a595ab7c131cc/cros_vm.md

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/4125965e666e9ed3b5c9cd0aa4914d0ac8728171

commit 4125965e666e9ed3b5c9cd0aa4914d0ac8728171
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Wed Nov 29 04:17:05 2017

[cros_vm]: Support for qemu bios path.

--qemu-bios-path to point to location of bios files.
This is passed to the qemu binary as -L.

This allows for support of downloaded qemu binaries.

BUG= chromium:782190 
TEST=manual

Change-Id: I36700e86cb5393ad02752bee75eb95c3a2610293
Reviewed-on: https://chromium-review.googlesource.com/769288
Commit-Ready: Achuith Bhandarkar <achuith@chromium.org>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/4125965e666e9ed3b5c9cd0aa4914d0ac8728171/scripts/cros_vm.py

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/docs/+/673e9879322ade4de9b802a614b14778f23199ce

commit 673e9879322ade4de9b802a614b14778f23199ce
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Thu Nov 30 15:09:47 2017

[cros_vm]: Documentation for qemu-bios-path.

BUG= chromium:782190 
TEST=none

Change-Id: If6edfadc681088334384f8eee1cd6c88f2e17b70
Reviewed-on: https://chromium-review.googlesource.com/798395
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/673e9879322ade4de9b802a614b14778f23199ce/cros_vm.md

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/docs/+/61b0d51935543fd1e351f1a2d2321cd896faa77c

commit 61b0d51935543fd1e351f1a2d2321cd896faa77c
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Fri Dec 01 08:39:44 2017

[cros_vm]: vncviewer instructions.

BUG= chromium:782190 
TEST=None

Change-Id: I907b362c538935da916a50b5f323c05011487286
Reviewed-on: https://chromium-review.googlesource.com/802253
Commit-Ready: Achuith Bhandarkar <achuith@chromium.org>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/61b0d51935543fd1e351f1a2d2321cd896faa77c/cros_vm.md

Cc: perezju@chromium.org
Docs feedback from perezju:

* The link on "Prerequisites → Virtualization enabled" is broken. I think it should be https://g3doc.corp.google.com/tools/android/g3doc/development/crow/enable_kvm.md?cl=head (at least that's what I found, and it seemed to work).

* The section on Install EMU says "You can now specify the qemu path and ...", but that actually doesn't work until after the next step, Download the VM, is done. Actually, at this point is not even clear what the (sdk) environment is supposed to be. [The download VM command also starts the cros-sdk shell and then it all makes sense]

* On "To install vncviewer", when doing "sudo apt-get install vncviewer" I get back "Package 'vncviewer' has no installation candidate", and the output suggests trying xtightvncviewer or tigervnc-viewer. Not sure if there should be any preference. I went for the latter and seems to be working fine for now.

* Your doc says to run "sudo kvm-ok" to check if virtualization is enabled; but that just gives me "command not found". Step 5 in the crow doc gives another command to run and verify that KVM is working. That one did work for me.
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/docs/+/7ee4830be21462486c8e66eaa98e25201de0a8b7

commit 7ee4830be21462486c8e66eaa98e25201de0a8b7
Author: Achuith Bhandarkar <achuith@chromium.org>
Date: Tue Dec 05 04:02:50 2017

[cros_vm]: Docs feedback

Feedback here:
 https://crbug.com/782190#c13 

* Update link to virtualization doc.
* New section for Virtualization check.
* Move Install QEMU section to under Launch a Chrome OS VM.
* If chroot exists, point users to that before they download QEMU.
* Break out vncviewer installation instructions into its own section under
Launch a Chrome OS VM.
* Prefer running catapult tests from the workstation to within the VM since
this is the common catapult dev flow.
* mouse cursor problem no longer exists.
* Can now launch a locally built VM from within the chroot.

BUG= chromium:782190 
TEST=None
Change-Id: Icbbcf5292a81cf65c5c86d8bc75e3c884bcf2e24
Reviewed-on: https://chromium-review.googlesource.com/803624
Commit-Ready: Achuith Bhandarkar <achuith@chromium.org>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/7ee4830be21462486c8e66eaa98e25201de0a8b7/cros_vm.md

Status: Fixed (was: Started)
We have a workaround in place, and a final fix here:
https://chromium-review.googlesource.com/860903

Sign in to add a comment