New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782156 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Underline is missing from Change link on First run bubble.

Reported by dchau...@etouch.net, Nov 7 2017

Issue description

Chrome Version: 64.0.3260.2 (Official Build)05d1d20e2db6d594b98fe87d7aa500f22aba70a6-refs/branch-heads/3260@{#3} 32/64-bit.
OS: Win(7,8,10), Linux(14.04 LTS).

What steps will reproduce the problem?
1. Freshly launch Chrome, open NTP and observe 'Change' link on First run bubble.

Underline is missing on Change link.
Underline should seen on Change link.

NOTE: More space is also observed between text 'Google' and 'Change' link on First run bubble.

This is a regression issue, broken in M-64 series, below is manual regression range.

Good build: 64.0.3256.0 
Bad build: 64.0.3257.0

You are probably looking for a change made after 513360 (known good), but no later than 513361 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/a28eb737c4c9424d7656ada19b688af854777968..1eca7aba022c190ea02e34dbd4ae52a8f5f88bbc

Suspect: https://chromium.googlesource.com/chromium/src/+/1eca7aba022c190ea02e34dbd4ae52a8f5f88bbc

@tapted: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

NOTE: This issue is not seen on Mac OS.

Kindly review the attached screenshot for reference.
 
First Run Bubble_Screenshot.png
11.1 KB View Download
Cc: jawag@chromium.org bsep@chromium.org
Labels: Proj-HarmonyDialogs
Removing the underline is intentional.

But this dialog is really ugly, and might need some fixes for Harmony in m65. Removing that underline seems to throw off the alignment.

Comment 2 by bsep@chromium.org, Nov 7 2017

Status: WontFix (was: Assigned)
Removing the underline is working as intended. Agreed that the dialog is pretty ugly, but that's covered under tracking bug 699338.

Comment 3 by tapted@chromium.org, Nov 16 2017

Cc: tapted@chromium.org
 Issue 785794  has been merged into this issue.

Sign in to add a comment