[root-layer-scrolls] Implement VisibleContentSize for RLS flow |
|||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win7, OSX 10.9.5, etc...) During https://chromium-review.googlesource.com/c/chromium/src/+/716096 review, there is a discussion about simplifying the function PointInFrameContentIfVisible to avoid using point_in_content by using VisibleContentSize instead of VisibleContentRect and few other changes. But there is a unit test failure ElementFromPointOnScrollbar in DocumentTest.cpp for RLS case as there is no implementation for VisibleContentSize in PLSA.
,
Nov 7 2017
Sorry, I should have picked up on this in the review, but if you have VisibleContentRect you can always just use VisibleContentRect().Size() so I don't think you need to do this. (though I have no objection if this makes it cleaner...)
,
Nov 7 2017
ok, makes sense. I will try to clean up the function by using size from VisibleContentRect once the current patch lands.
,
Nov 8 2017
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d5912ce4bb64fdffe673abc894af0b91478a33a commit 7d5912ce4bb64fdffe673abc894af0b91478a33a Author: Sriram <srirama.m@samsung.com> Date: Fri Nov 10 06:36:03 2017 Simplify PointInFrameContentIfVisible() in TreeScope.cpp Bug: 782141 Change-Id: I243c94935989866778fa75169070326364ddfe38 Reviewed-on: https://chromium-review.googlesource.com/760438 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#515484} [modify] https://crrev.com/7d5912ce4bb64fdffe673abc894af0b91478a33a/third_party/WebKit/Source/core/dom/TreeScope.cpp
,
Nov 10 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sriram...@samsung.com
, Nov 7 2017