New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782137 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 603386



Sign in to add a comment

Add Extension button is disabled on MAC-Touchbar.

Reported by aiman.an...@etouch.net, Nov 7 2017

Issue description

Chrome Version:64.0.3261.0 (Official Build)aac97fe5f3cb5890bedac2a2ba9fec6b3e8c16fc-refs/heads/master@{#514329} (64-bit)

OS: Mac(10.13.2) 

Test URL: https://chrome.google.com/webstore/detail/salesforce-lightning-for/jjghhkepijgakdammjldcbnjehfkfmha?utm_source=chrome-ntp-icon

What steps will reproduce the problem?
1. Launch chrome, navigate to the above URL and click on ‘Add to Chrome’ button.
2. On add extension bubble - observe ‘Add extension’ button on Mac-touchbar.

Actual: Add extension button is not enabled on Mac-touchbar.
Expected: Add extension button should be enabled on Mac-touchbar.

This is a non-regression issue, seen from ‘M-64’(64.0.3261.0)

Note: 1. Issue is Mac-Touchbar specific.
      2. Button is enabled only for Cancel button on Touch Bar.

 
Actual Result.jpg
15.9 MB Download
Components: Platform>Extensions
Status: Untriaged (was: Unconfirmed)
As this being a Non-Regression issue, changing the status to Untriaged so that the issue would get addressed.

Thank You!
Cc: spqc...@chromium.org
Components: UI>Browser>Touchbar
Cc: shrike@chromium.org
Owner: tapted@chromium.org
Status: Assigned (was: Untriaged)
Blocking: 603386
Labels: -Pri-2 Proj-HarmonyDialogs Proj-MacViews Pri-1
Technically a dupe, but the other bugs are private. I'll dupe them into this.

Relevant comments

> Trent: Should this TouchBar/Dialog integration be behind the kDialogTouchBar Feature - https://cs.chromium.org/chromium/src/chrome/common/chrome_features.cc?type=cs&q=KdialogTouchBar&sq=package:chromium&l=118

kDialogTouchBar is for Cocoa UI. We should fix this. ui::DialogModel (or DialogClientView) probably needs to support observers.
Issue 779163 has been merged into this issue.
Issue 779658 has been merged into this issue.
Cc: linds...@chromium.org

Comment 9 by tapted@chromium.org, Nov 10 2017

Status: Started (was: Assigned)
https://chromium-review.googlesource.com/762927
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75c7c95ad3e46f58c36a2716a057390ef9e5597f

commit 75c7c95ad3e46f58c36a2716a057390ef9e5597f
Author: Trent Apted <tapted@chromium.org>
Date: Tue Nov 14 22:43:44 2017

Add views::DialogObserver

To begin, there are two observers: DialogClientView, and the
BridgedNativeWidget used on Mac. Both use it to update dialog
buttons when labels or enabled state changes. The latter allows
the Mac TouchBar to react to model changes.

Replaces calls to DialogClientView::UpdateDialogButtons() with
DialogDelegate::DialogModelChanged(). This allows some unnecessary
coupling to DialogClientView to be removed from DialogDelegate
implementations.

Bug:  782137 
Change-Id: I4718d80d2d5454e00c7438f1cadd6db3cfdc2490
Reviewed-on: https://chromium-review.googlesource.com/762708
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516473}
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/chromeos/certificate_provider/pin_dialog_manager.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/chromeos/options/vpn_config_view.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/chromeos/options/wifi_config_view.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/chromeos/options/wimax_config_view.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/chromeos/ui/request_pin_view.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/ui/views/content_setting_bubble_contents.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/ui/views/create_application_shortcut_view.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/ui/views/extensions/chooser_dialog_view.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/ui/views/permission_bubble/chooser_bubble_ui.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/ui/views/task_manager_view.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/chrome/browser/ui/views/webshare/webshare_target_picker_view.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/ui/views/BUILD.gn
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/ui/views/bubble/bubble_dialog_delegate_unittest.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/ui/views/bubble/bubble_frame_view_unittest.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/ui/views/cocoa/bridged_native_widget.h
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/ui/views/cocoa/bridged_native_widget.mm
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/ui/views/examples/dialog_example.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/ui/views/widget/native_widget_mac.mm
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/ui/views/widget/native_widget_mac_unittest.mm
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/ui/views/window/dialog_client_view.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/ui/views/window/dialog_client_view.h
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/ui/views/window/dialog_client_view_unittest.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/ui/views/window/dialog_delegate.cc
[modify] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/ui/views/window/dialog_delegate.h
[add] https://crrev.com/75c7c95ad3e46f58c36a2716a057390ef9e5597f/ui/views/window/dialog_observer.h

Status: Fixed (was: Started)
Labels: Needs-Feedback
tapted@, Thank you for the fix. I'm unable to replicate this issue on reported version of chrome#64.0.3261.0 for latest OS X 10.3.2 on Mac Touchbar. Seems like latest 10.13.2 OS updates have been fixed this?

aiman.ansari@, can you please double check it's still reproducible on reported chrome version# 64.0.3261.0 for latest OS X 10.13.2?

Thank you!
Labels: -Needs-Feedback
Hi manoranjanr,

Retested the above issue on Mac Touchbar(10.13.3) for latest Canary #65.0.3319.0 and issue is fixed now.

Now, 'Add Extension' button is Enabled, attaching screenshot for your reference.

Thank You!
Current_Result.jpeg
1.9 MB View Download
Hi,

Kindly note, that our Mac Touchbar machine OS X 10.13.2 is now updated to OS X 10.13.3 and we have no other Mac Touchbar machine with OS X 10.13.2.

Hence, retested the above issue on OS X 10.13.3 Mac Touchbar and got the following observations:

1. Issue is still reproducible on reported chrome version (64.0.3261.0) for OS X 10.13.3.
2. And, issue is fixed on latest canary #65.0.3321.0 for OS X 10.13.3. 

Kindly review attached screenshot referring to both the observations.

Thank You! 


Current_Result_64.0.3261.0.JPG
2.3 MB View Download
Current_Result_65.0.3321.0.JPG
2.3 MB View Download

Sign in to add a comment