New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782135 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: 'Learn more' link may wrap onto a second line in 'View site information' bubble, only half can show focus at a time.

Reported by nutan.ga...@etouch.net, Nov 7 2017

Issue description

Version : 64.0.3260.2 05d1d20e2db6d594b98fe87d7aa500f22aba70a6-refs/branch-heads/3260@{#3} 32/64 bits
OS: Linux (14.04 LTS)

What steps will reproduce the problem
1. Launch chrome, navigate to https://permission.site/
2. Click on 'View site information' icon and observe 'Learn more' link 

Actual: 'Learn more' link is not seen properly
Expected: 'Learn more' link should be seen properly

This is an Regression issue broken in 'M-64' and below is the bisect info :
Good build: 64.0.3256.0
Bad build: 64.0.3257.0

You are probably looking for a change made after 513360 (known good), but no later than 513361 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/a28eb737c4c9424d7656ada19b688af854777968..1eca7aba022c190ea02e34dbd4ae52a8f5f88bbc

Suspect: https://chromium.googlesource.com/chromium/src/+/1eca7aba022c190ea02e34dbd4ae52a8f5f88bbc

Note: Issue is not seen on Mac and Windows OS

 
Actual_Result.png
178 KB View Download
Expected_Result.png
179 KB View Download
Components: UI>Browser>Bubbles
Cc: bsep@chromium.org patricia...@chromium.org
Labels: Proj-HarmonyDialogs
Summary: Regression: 'Learn more' link may wrap onto a second line in 'View site information' bubble, only half can show focus at a time. (was: Regression: 'Learn more' link is not seen properly on 'View site information' bubble)
This is working correctly. It is strange that only one "half" of the link is showing key focus, but that isn't a regression caused by that CL.

I think the "Fix" for this is to give initial key focus to a different view of the dialog so that it isn't hurt by the inability of StyledLabel to show focus on both "halves" of a link that wraps lines.

(but really we should try to implement that in StyledLabel)

Comment 3 by bsep@chromium.org, Nov 7 2017

Cc: -nyerramilli@chromium.org tapted@chromium.org
Labels: -Pri-1 -M-64 M-65 Pri-2
Owner: ----
Status: Available (was: Assigned)
Agreed that it's okay for the link to wrap a line. We should fix that weird focus behavior, but not urgently.

Comment 4 by tapted@chromium.org, Nov 10 2017

Cc: krajshree@chromium.org brajkumar@chromium.org ajha@chromium.org
 Issue 783581  has been merged into this issue.
Cc: nyerramilli@chromium.org
 Issue 839340  has been merged into this issue.
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
***Mass UI Triage***

Just to update: 
Still we are able to reproduce the issue on latest canary #72.0.3609.3 on Linux(14.04) OS. 

@bsep: Could you please take a look into this issue.

Kindly find the attached screen-cast for reference.

Thank you.
LearnMore_Issue.webm
941 KB View Download

Sign in to add a comment