Regression : Unable to mute tab on NTP
Reported by
vineetha...@etouch.net,
Nov 7 2017
|
||||||||
Issue descriptionChrome version: 64.0.3260.2 05d1d20e2db6d594b98fe87d7aa500f22aba70a6-refs/branch-heads/3260@{#3}(32/64-bit) OS: Windows (7,8,10),Linux (14.04 LTS),Mac(10.12.6, 10.13.2). Steps to reproduce: 1. Launch Chrome. 2. Navigate to NTP ,right click on tab and click "Mute site" option and observe. Actual Result: Tab is not muted after clicking on "Mute site", mute icon is not visible on tab. Expected Result: Tab should get muted after clicking on "Mute site", mute icon should be visible on tab. This is Regression Issue broken in M-62 and and Using the per-revision bisect providing the bisect results, Good Build: 64.0.3243.0(Revision: 509637) Bad Build: 64.0.3244.0(Revision: 509944) You are probably looking for a change made after 509775 (known good), but no later than 509776 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/e7fa637d7ac2f35b26ffc6c1d0b5cf443d6c787c..4bee58d8cc08debda0ea2d40a9d41a09b6f165a9 Suspect : https://chromium.googlesource.com/chromium/src/+/4bee58d8cc08debda0ea2d40a9d41a09b6f165a9 @steimel : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thank You
,
Nov 7 2017
Adding Release blocker for this issue. Please undo if not the case. Thank You!
,
Nov 8 2017
,
Nov 8 2017
,
Nov 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3b6ea0d1f0ab0a3f757918366a7242b82fe2349 commit a3b6ea0d1f0ab0a3f757918366a7242b82fe2349 Author: Tommy Steimel <steimel@chromium.org> Date: Sat Nov 11 01:44:44 2017 Disable "Mute site" option on chrome:// URLs With the new site muting feature, "Mute tab" in the tab dropdown was replaced with "Mute site", which mutes via a content setting. There are no content settings for chrome:// urls, so this CL disables the "Mute Site" option for those pages. Bug: 782134 Change-Id: Ib95027b3124ae75e49ab6f32556e73d4f2918d04 Reviewed-on: https://chromium-review.googlesource.com/758139 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#515784} [modify] https://crrev.com/a3b6ea0d1f0ab0a3f757918366a7242b82fe2349/chrome/browser/extensions/api/tabs/tabs_api.cc [modify] https://crrev.com/a3b6ea0d1f0ab0a3f757918366a7242b82fe2349/chrome/browser/ui/tabs/tab_strip_model_impl.cc [modify] https://crrev.com/a3b6ea0d1f0ab0a3f757918366a7242b82fe2349/chrome/browser/ui/tabs/tab_utils.cc [modify] https://crrev.com/a3b6ea0d1f0ab0a3f757918366a7242b82fe2349/chrome/browser/ui/tabs/tab_utils.h
,
Nov 11 2017
Fixed this, but the expected case has changed. Instead of muting the tab, it should instead not allow the user to click the option at all. 1. Launch Chrome. 2. Navigate to NTP ,right click on tab and see that "Mute site" option is disabled. Thanks!
,
Nov 13 2017
Update : Retested above issue on Windows(7,8,10) OS and Linux OS using latest Canary #64.0.3267.0 and issue is fixed. Kindly review an attached screen cast. Thank you!
,
Nov 13 2017
Looks good, thanks!
,
Nov 14 2017
Note: Will soon update Mac info after testing it once Mac build is available. Thanks.
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac06f06510f555acd580cac6cf787ef8649efb71 commit ac06f06510f555acd580cac6cf787ef8649efb71 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 22 22:33:23 2017 Revert "Disable "Mute site" option on chrome:// URLs" This reverts commit a3b6ea0d1f0ab0a3f757918366a7242b82fe2349. Reason for revert: We landed this with the intention of not allowing muting for any chrome:// URLs, but we've now changed our minds due to crbug.com/787743 (unable to mute chrome://dino tab). Original change's description: > Disable "Mute site" option on chrome:// URLs > > With the new site muting feature, "Mute tab" in the tab dropdown was > replaced with "Mute site", which mutes via a content setting. There are > no content settings for chrome:// urls, so this CL disables the "Mute > Site" option for those pages. > > Bug: 782134 > Change-Id: Ib95027b3124ae75e49ab6f32556e73d4f2918d04 > Reviewed-on: https://chromium-review.googlesource.com/758139 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515784} TBR=sky@chromium.org,miu@chromium.org,steimel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 782134 Change-Id: Iaddfa0f57dddda199906e43655839ca7f6bfc1ac Reviewed-on: https://chromium-review.googlesource.com/786113 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#518774} [modify] https://crrev.com/ac06f06510f555acd580cac6cf787ef8649efb71/chrome/browser/extensions/api/tabs/tabs_api.cc [modify] https://crrev.com/ac06f06510f555acd580cac6cf787ef8649efb71/chrome/browser/ui/tabs/tab_strip_model_impl.cc [modify] https://crrev.com/ac06f06510f555acd580cac6cf787ef8649efb71/chrome/browser/ui/tabs/tab_utils.cc [modify] https://crrev.com/ac06f06510f555acd580cac6cf787ef8649efb71/chrome/browser/ui/tabs/tab_utils.h
,
Nov 23 2017
Rechecked again and above issue is still reproducible on Windows (7,8,10),Linux (14.04 LTS),Mac(10.12.6, 10.13.2) on latest canary version i.e. 64.0.3276.0 (Official Build) Please refer attached screencast
,
Nov 28 2017
Rechecked again and above issue is still reproducible on Windows (7,8,10),Linux (14.04 LTS),Mac(10.12.6, 10.13.2) on latest canary version i.e. 64.0.3279.0 (Official Build) Please refer attached screencast
,
Nov 28 2017
Un-resolving this since the fix was reverted. There's a CL in review that we re-fix this, though the expected case is going to change back to: 1. Launch Chrome. 2. Navigate to NTP, right click on tab and click "Mute site" option and observe. Expected Result: Tab should get muted after clicking on "Mute site", mute icon should be visible on tab. Thanks!
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37112950bc5ed3dbd06fdf42c0367ff246939287 commit 37112950bc5ed3dbd06fdf42c0367ff246939287 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 19:41:45 2017 Add ability to mute chrome:// pages Bug: 787743 , 785711 , 782134 Change-Id: I77fe9a7192697ebe82734231ae709c2094b57b62 Reviewed-on: https://chromium-review.googlesource.com/791813 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#520203} [modify] https://crrev.com/37112950bc5ed3dbd06fdf42c0367ff246939287/chrome/browser/content_settings/sound_content_setting_observer.cc [modify] https://crrev.com/37112950bc5ed3dbd06fdf42c0367ff246939287/chrome/browser/content_settings/sound_content_setting_observer_unittest.cc [modify] https://crrev.com/37112950bc5ed3dbd06fdf42c0367ff246939287/chrome/browser/extensions/extension_tab_util.cc [modify] https://crrev.com/37112950bc5ed3dbd06fdf42c0367ff246939287/chrome/browser/ui/tabs/tab_utils.cc [modify] https://crrev.com/37112950bc5ed3dbd06fdf42c0367ff246939287/chrome/browser/ui/tabs/tab_utils.h
,
Nov 29 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mastiz@chromium.org
, Nov 7 2017