Issue metadata
Sign in to add a comment
|
Permissions.Action.Notification doesn't record revokes on Android |
||||||||||||||||||||||
Issue descriptionThe UMA histograms Permissions.Action.* have a REVOKE value which counts how much permissions are revoked, but it isn't hooked up for clearing notification permissions on Android (i.e. when clicking Clear & Reset in Site Settings). Looks to be that SetNotificationSettingForOrigin is missing a ScopedRevocationReporter
,
Nov 10 2017
,
Feb 18 2018
,
Oct 27
,
Nov 6
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8c0f174bb015976222531ead359ade19b488833 commit f8c0f174bb015976222531ead359ade19b488833 Author: Joe DeBlasio <jdeblasio@chromium.org> Date: Fri Nov 09 17:35:40 2018 Record Android revokes in Permissions.Action.Notification. This CL modifies fixes a bug in which metrics were not being recorded on Android when notification permissions were revoked. It adds a missing ScopedRevocationReporter for Chrome-visible changes, and adds detection code for when notification permissions are revoked in Android O+ system channel settings. Bug: 782126 Change-Id: I609e909936d09e6dd948f0601bbf73ecdb6b8b75 Reviewed-on: https://chromium-review.googlesource.com/c/1324394 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#606887} [modify] https://crrev.com/f8c0f174bb015976222531ead359ade19b488833/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java [modify] https://crrev.com/f8c0f174bb015976222531ead359ade19b488833/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferenceBridge.java [modify] https://crrev.com/f8c0f174bb015976222531ead359ade19b488833/chrome/browser/android/preferences/website_preference_bridge.cc [modify] https://crrev.com/f8c0f174bb015976222531ead359ade19b488833/chrome/browser/permissions/permission_uma_util.h [modify] https://crrev.com/f8c0f174bb015976222531ead359ade19b488833/tools/metrics/ukm/ukm.xml
,
Nov 9
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by timloh@chromium.org
, Nov 7 2017