Crash with signature: autofill::KeyPressHandlerManager::RemoveKeyPressHandler
Reported by
xae...@yandex-team.ru,
Nov 7 2017
|
||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0 Steps to reproduce the problem: 1. Open https://passport.yandex.ru/registration-new 2. Invoke password generator popup. 3. Close the tab or the whole browser (Cmd+Q). What is the expected behavior? Browser doesn't crash. What went wrong? Browser crashed because of dereferencing the invalid pointer. Crashed report ID: How much crashed? Whole browser Is it a problem with a plugin? No Did this work before? No Chrome version: 64.0.3260.0 canary Channel: n/a OS Version: 10.12.5 Flash Version: Shockwave Flash 27.0 r0
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13d2fa5b74265db2b4d8454180909b8bb2d6636c commit 13d2fa5b74265db2b4d8454180909b8bb2d6636c Author: Aleksandr Popov <xaerox@yandex-team.ru> Date: Wed Nov 08 12:12:29 2017 Pass driver as weak pointer to popup controllers. Pass driver as weak pointer to popup controllers to prevent crashes. Sometimes the password generation popup is not closed prior to destroying of web contents; this makes it being destroyed during the destruction of the web contents. However, at that point, the contents' render frame host is already deleted, and the driver is no more valid. But the popup keeps a raw pointer to the driver, and attempts to use it in its Hide() function, which leads to a crash. This can be reprocuced on MacOS at the website https://passport.yandex.ru/registration-new with the password generator enabled. TEST=On MacOS at the website https://passport.yandex.ru/registration-new with the password generator enabled, click the 4th field (the password field) to invoke the generator. Then press Cmd+Q: the browser should close without a crash. Bug: 782125 Change-Id: Id2095ddee3b7c02f6dcd9607c13856ddf97df2e9 Reviewed-on: https://chromium-review.googlesource.com/758256 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#514804} [modify] https://crrev.com/13d2fa5b74265db2b4d8454180909b8bb2d6636c/chrome/browser/password_manager/chrome_password_manager_client.cc [modify] https://crrev.com/13d2fa5b74265db2b4d8454180909b8bb2d6636c/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc [modify] https://crrev.com/13d2fa5b74265db2b4d8454180909b8bb2d6636c/chrome/browser/ui/autofill/password_generation_popup_controller_impl.h [modify] https://crrev.com/13d2fa5b74265db2b4d8454180909b8bb2d6636c/chrome/browser/ui/autofill/password_generation_popup_view_browsertest.cc
,
Nov 8 2017
[chrome mac triage] Closing this as fix |
||
►
Sign in to add a comment |
||
Comment 1 by dtapu...@chromium.org
, Nov 7 2017