New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782120 link

Starred by 4 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocking:
issue 807842
issue 814960



Sign in to add a comment

Implement an ambient badge to inform users they are browsing a PWA

Project Member Reported by dominickn@chromium.org, Nov 7 2017

Issue description

Giving a static signal to users when they are on a PWA will help encourage developer uptake of PWAs and surface the fact that these sites are installable.
 
It will also help take the pressure of informing a user that they are on a PWA off the app install banner, allowing that feature to be evolved to allow more developer control.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/203b49362f2a10176bd12346f116266622316913

commit 203b49362f2a10176bd12346f116266622316913
Author: Dominick Ng <dominickn@chromium.org>
Date: Fri Feb 02 05:32:45 2018

Implement a PWA ambient badge behind a flag.

This CL implements a mini-infobar that is displayed when users visit any
PWA. Tapping the infobar will trigger add to home screen. The intention
is to inform users that they are browsing a PWA, give easier access to
add to home screen, and encourage developers to adopt PWAs through
privileged UI.

App install currently fulfill the informational role that ambient badges
will now take. This CL will enable future work to stop app banners from
automatically appearing, and change them to adopt a modal,
developer-triggered flow which hands more control to sites.

Future CLs will:
 - disable automatic app install banner triggering when the ambient
   badge feature is active
 - change the string of the ambient badge such that it launches the PWA
   if it is already installed

Eventually, it is hoped that a less intrusive UI will take the place of
the mini infobar for the ambient badge.

BUG=782120

Change-Id: Id012522982699d61293c57b79c4eb3ef0fe9e55f
Reviewed-on: https://chromium-review.googlesource.com/879701
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533966}
[modify] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/android/java/src/org/chromium/chrome/browser/infobar/OWNERS
[add] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/android/java/src/org/chromium/chrome/browser/infobar/PwaAmbientBadgeInfoBar.java
[modify] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/android/java/src/org/chromium/chrome/browser/infobar/ReaderModeInfoBar.java
[add] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibleTextView.java
[modify] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/android/java_sources.gni
[modify] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/app/generated_resources.grd
[modify] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/browser/BUILD.gn
[modify] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/browser/android/shortcut_helper.cc
[modify] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/browser/android/shortcut_helper.h
[modify] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/browser/android/webapk/webapk_metrics.cc
[modify] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/browser/banners/app_banner_infobar_delegate_android.cc
[modify] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/browser/banners/app_banner_manager_android.cc
[modify] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/browser/banners/app_banner_manager_android.h
[modify] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/browser/installable/installable_metrics.cc
[modify] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/browser/installable/installable_metrics.h
[add] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/browser/installable/pwa_ambient_badge_infobar_delegate_android.cc
[add] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/browser/installable/pwa_ambient_badge_infobar_delegate_android.h
[add] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/browser/installable/pwa_ambient_badge_manager_android.cc
[add] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/browser/installable/pwa_ambient_badge_manager_android.h
[modify] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/browser/ui/android/infobars/OWNERS
[add] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/browser/ui/android/infobars/pwa_ambient_badge_infobar.cc
[add] https://crrev.com/203b49362f2a10176bd12346f116266622316913/chrome/browser/ui/android/infobars/pwa_ambient_badge_infobar.h
[modify] https://crrev.com/203b49362f2a10176bd12346f116266622316913/components/infobars/core/infobar_delegate.h
[modify] https://crrev.com/203b49362f2a10176bd12346f116266622316913/tools/metrics/histograms/enums.xml

Comment 3 by mgiuca@chromium.org, Feb 21 2018

Should we split this off into a separate bug for DPWAs or just reuse it?
Let's split this for DPWAs and leave this one as Android-specific.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a428757cace3ba6571abc23f41947fcc92c7415f

commit a428757cace3ba6571abc23f41947fcc92c7415f
Author: Dominick Ng <dominickn@chromium.org>
Date: Wed Feb 21 23:32:44 2018

Remove the CheckInstallabilityForBannerOnLoad feature.

This CL replaces mentions of the CheckInstallabilityForBannerOnLoad
feature with ExperimentalAppBanners, consolidating the feature flags for
the new app banner flow.

Once the modal banner UI and ambient badging changes on Android land,
this CL has the additional effect of ensuring ambient badge checking
will start as soon as the load event dispatches, rather than when
sufficient engagement to trigger the banner is earned.

BUG=782120, 811578 

Change-Id: I86409406bec56012a62c831ad57b799a8bf45547
Reviewed-on: https://chromium-review.googlesource.com/928095
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538253}
[modify] https://crrev.com/a428757cace3ba6571abc23f41947fcc92c7415f/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/a428757cace3ba6571abc23f41947fcc92c7415f/chrome/browser/banners/app_banner_manager_browsertest.cc
[modify] https://crrev.com/a428757cace3ba6571abc23f41947fcc92c7415f/chrome/browser/engagement/site_engagement_service.h
[modify] https://crrev.com/a428757cace3ba6571abc23f41947fcc92c7415f/chrome/common/chrome_features.cc
[modify] https://crrev.com/a428757cace3ba6571abc23f41947fcc92c7415f/chrome/common/chrome_features.h

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a32333e7b6248fe973ac434d918b83226acf138d

commit a32333e7b6248fe973ac434d918b83226acf138d
Author: Dominick Ng <dominickn@chromium.org>
Date: Thu Feb 22 00:05:47 2018

Display an ambient badge for sites advertising a native app installation.

This CL shows ambient badges for sites offering native app banners when
the ExperimentalAppBanners feature is active. This is in order to
retain the ability to subtly advertise a native app and disincentivise
door-slam app install interstitials following the conversion of app
install banners to user-triggered modal dialogs.

With ExperimentalAppBanners active, no app banners are automatically
shown. Instead, sites that are eligible for banners will display an
ambient badge (currently a mini-infobar on Android) that triggers the
modal banner when tapped. This is a slight behaviour change for the
ambient badge (it previously triggered add to home screen directly;
now it triggers the banner). This allows users an additional
confirmation step before installing a native app, and keeps consistency
between web and native.

The site may also use the JavaScript beforeinstallprompt API to
trigger the app install banner directly. A follow-up CL will dismisss
the ambient badge when the app install banner is triggered in this way.

Search has been downranking sites showing app install interstitials, and
app install banners have been advertised as an alternative. With the
conversion of app install banners to modal, this CL retains the ability
for sites to use the same mechanism for app install banners.

This CL also renames the PwaAmbientBadge*Android classes to be called
InstallableAmbientBadge*. The Android suffix is removed as the infobar
header is included and compiled on non-Android platforms in order for
AppBannerManager to fulfil the
InstallableAmbientBadgeInfoBarDelegate::Client interface, which is
needed to avoid a duplicated WeakPtrFactory on AppBannerManagerAndroid.

BUG=782120
TBR=estade@chromium.org

Change-Id: Ic2f0244eabf4b57d5aa3613b92d815bb557b83bb
Reviewed-on: https://chromium-review.googlesource.com/923250
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538263}
[rename] https://crrev.com/a32333e7b6248fe973ac434d918b83226acf138d/chrome/android/java/src/org/chromium/chrome/browser/infobar/InstallableAmbientBadgeInfoBar.java
[modify] https://crrev.com/a32333e7b6248fe973ac434d918b83226acf138d/chrome/android/java/src/org/chromium/chrome/browser/infobar/OWNERS
[modify] https://crrev.com/a32333e7b6248fe973ac434d918b83226acf138d/chrome/android/java_sources.gni
[modify] https://crrev.com/a32333e7b6248fe973ac434d918b83226acf138d/chrome/browser/BUILD.gn
[modify] https://crrev.com/a32333e7b6248fe973ac434d918b83226acf138d/chrome/browser/banners/app_banner_manager.h
[modify] https://crrev.com/a32333e7b6248fe973ac434d918b83226acf138d/chrome/browser/banners/app_banner_manager_android.cc
[modify] https://crrev.com/a32333e7b6248fe973ac434d918b83226acf138d/chrome/browser/banners/app_banner_manager_android.h
[add] https://crrev.com/a32333e7b6248fe973ac434d918b83226acf138d/chrome/browser/installable/installable_ambient_badge_infobar_delegate.cc
[add] https://crrev.com/a32333e7b6248fe973ac434d918b83226acf138d/chrome/browser/installable/installable_ambient_badge_infobar_delegate.h
[delete] https://crrev.com/64bf482feb86ae02503c588cad1cb56e46c31b1d/chrome/browser/installable/pwa_ambient_badge_infobar_delegate_android.cc
[delete] https://crrev.com/64bf482feb86ae02503c588cad1cb56e46c31b1d/chrome/browser/installable/pwa_ambient_badge_infobar_delegate_android.h
[delete] https://crrev.com/64bf482feb86ae02503c588cad1cb56e46c31b1d/chrome/browser/installable/pwa_ambient_badge_manager_android.cc
[delete] https://crrev.com/64bf482feb86ae02503c588cad1cb56e46c31b1d/chrome/browser/installable/pwa_ambient_badge_manager_android.h
[modify] https://crrev.com/a32333e7b6248fe973ac434d918b83226acf138d/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/a32333e7b6248fe973ac434d918b83226acf138d/chrome/browser/ui/android/infobars/OWNERS
[add] https://crrev.com/a32333e7b6248fe973ac434d918b83226acf138d/chrome/browser/ui/android/infobars/installable_ambient_badge_infobar.cc
[add] https://crrev.com/a32333e7b6248fe973ac434d918b83226acf138d/chrome/browser/ui/android/infobars/installable_ambient_badge_infobar.h
[delete] https://crrev.com/64bf482feb86ae02503c588cad1cb56e46c31b1d/chrome/browser/ui/android/infobars/pwa_ambient_badge_infobar.cc
[delete] https://crrev.com/64bf482feb86ae02503c588cad1cb56e46c31b1d/chrome/browser/ui/android/infobars/pwa_ambient_badge_infobar.h
[modify] https://crrev.com/a32333e7b6248fe973ac434d918b83226acf138d/components/infobars/core/infobar_delegate.h
[modify] https://crrev.com/a32333e7b6248fe973ac434d918b83226acf138d/tools/metrics/histograms/enums.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b5c7ab51b151604c2a9120c3d1a1ba065b055b4

commit 4b5c7ab51b151604c2a9120c3d1a1ba065b055b4
Author: Dominick Ng <dominickn@chromium.org>
Date: Thu Feb 22 01:09:16 2018

Dismiss the installable ambient badge when a modal app install banner is triggered.

When the ExperimentalAppBanners feature is active, sites with an
installable app (PWA or native app) display an ambient infobar to
inform users of the app. This CL dismisses the ambient badge
infobar if the site shows a modal app banner, as the ambient
badge and app install banner both link to an add to home screen
action.

BUG=782120, 811578 

Change-Id: Ifb9d3c9f8db21f3a0fcd0e4e697a881c84f55570
Reviewed-on: https://chromium-review.googlesource.com/923470
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538292}
[modify] https://crrev.com/4b5c7ab51b151604c2a9120c3d1a1ba065b055b4/chrome/browser/banners/app_banner_manager_android.cc
[modify] https://crrev.com/4b5c7ab51b151604c2a9120c3d1a1ba065b055b4/chrome/browser/banners/app_banner_manager_android.h

Comment 8 by mgiuca@chromium.org, Feb 22 2018

Blocking: 814960
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fe3c712fa15226ea0953f91c6557aa59e3de15b

commit 2fe3c712fa15226ea0953f91c6557aa59e3de15b
Author: Dominick Ng <dominickn@chromium.org>
Date: Fri Feb 23 04:33:52 2018

Improve the interaction of the installable ambient badge and app banners.

This CL restructures the app installed check for app banners to run
after banner eligibility is checked, but before engagement is checked.
This allows the Android subclass to dispatch the installable ambient
badge as soon as eligibility is established, rather than waiting until
sufficient engagement is earned. It also allows the text of the badge to
be changed based on whether the app is installed ("Open in app") or not
("Add to Home screen").

This CL also:
 - adds functionality to open the web app from the ambient badge
 - ensures that trying to trigger the banner after installing from the
   ambient badge is a no-op (edge case)

BUG=782120

Change-Id: I9ed708573673a5709b9771e45947348b9a006fb2
Reviewed-on: https://chromium-review.googlesource.com/930621
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538700}
[modify] https://crrev.com/2fe3c712fa15226ea0953f91c6557aa59e3de15b/chrome/android/java/src/org/chromium/chrome/browser/infobar/InstallableAmbientBadgeInfoBar.java
[modify] https://crrev.com/2fe3c712fa15226ea0953f91c6557aa59e3de15b/chrome/app/generated_resources.grd
[modify] https://crrev.com/2fe3c712fa15226ea0953f91c6557aa59e3de15b/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/2fe3c712fa15226ea0953f91c6557aa59e3de15b/chrome/browser/banners/app_banner_manager.h
[modify] https://crrev.com/2fe3c712fa15226ea0953f91c6557aa59e3de15b/chrome/browser/banners/app_banner_manager_android.cc
[modify] https://crrev.com/2fe3c712fa15226ea0953f91c6557aa59e3de15b/chrome/browser/banners/app_banner_manager_android.h
[modify] https://crrev.com/2fe3c712fa15226ea0953f91c6557aa59e3de15b/chrome/browser/installable/installable_ambient_badge_infobar_delegate.cc
[modify] https://crrev.com/2fe3c712fa15226ea0953f91c6557aa59e3de15b/chrome/browser/installable/installable_ambient_badge_infobar_delegate.h
[modify] https://crrev.com/2fe3c712fa15226ea0953f91c6557aa59e3de15b/chrome/browser/ui/android/infobars/installable_ambient_badge_infobar.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/239fc0c67dcaa982873009c85d09bc8e6399f90f

commit 239fc0c67dcaa982873009c85d09bc8e6399f90f
Author: Dominick Ng <dominickn@chromium.org>
Date: Fri Mar 16 00:28:46 2018

Use the app name in the installable ambient badge.

This CL changes the string for the installable ambient badge to use the
app name that will be installed or opened. The string now reads "Add
<appname> to Home screen", or "Open <appname>" in the case of an
installed app.

BUG=782120

Change-Id: Icd3f727cd583930c8a1c43a504823ae4cf4d43f2
Reviewed-on: https://chromium-review.googlesource.com/963862
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543572}
[modify] https://crrev.com/239fc0c67dcaa982873009c85d09bc8e6399f90f/chrome/android/java/src/org/chromium/chrome/browser/infobar/InstallableAmbientBadgeInfoBar.java
[modify] https://crrev.com/239fc0c67dcaa982873009c85d09bc8e6399f90f/chrome/app/generated_resources.grd
[modify] https://crrev.com/239fc0c67dcaa982873009c85d09bc8e6399f90f/chrome/browser/banners/app_banner_manager_android.cc
[modify] https://crrev.com/239fc0c67dcaa982873009c85d09bc8e6399f90f/chrome/browser/banners/app_banner_manager_android.h
[modify] https://crrev.com/239fc0c67dcaa982873009c85d09bc8e6399f90f/chrome/browser/installable/installable_ambient_badge_infobar_delegate.cc
[modify] https://crrev.com/239fc0c67dcaa982873009c85d09bc8e6399f90f/chrome/browser/installable/installable_ambient_badge_infobar_delegate.h
[modify] https://crrev.com/239fc0c67dcaa982873009c85d09bc8e6399f90f/chrome/browser/ui/android/infobars/installable_ambient_badge_infobar.cc

Blocking: 807842
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e81fab496202e46b7f3834d418520c7750014918

commit e81fab496202e46b7f3834d418520c7750014918
Author: Dominick Ng <dominickn@chromium.org>
Date: Thu Apr 05 08:36:39 2018

Enable ExperimentalAppBanners by default on Android.

BUG=782120, 811578 

Change-Id: I240ed465ddab68c363fdbbac99c86ccd3ffd0194
Reviewed-on: https://chromium-review.googlesource.com/996833
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548369}
[modify] https://crrev.com/e81fab496202e46b7f3834d418520c7750014918/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
[modify] https://crrev.com/e81fab496202e46b7f3834d418520c7750014918/chrome/common/chrome_features.cc

Cc: aska...@chromium.org
+askatte.
testing team noticed this and wasn't informed ahead of time. does this need any x-functional reviews?
Launching this has been a mess due to the PM swap. We're aiming to have a launch bug filed today.

We're trying to make M67 for this + the new modal banner flow since desktop PWAs are launching in that milestone with the new banner behaviour; we don't want mobile to be inconsistent and lag behind. 
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f604f9fc31e56f447fa55fbbb30ccfe45f561eb

commit 6f604f9fc31e56f447fa55fbbb30ccfe45f561eb
Author: Dominick Ng <dominickn@chromium.org>
Date: Fri Apr 20 01:41:59 2018

Disable ExperimentalAppBanners by default on Android.

This will be relanded to target M68.

BUG=782120, 811578 

Change-Id: I2f67f27e8aacc76c32efb3e3773e2482033b19fb
Reviewed-on: https://chromium-review.googlesource.com/1020560
Reviewed-by: Patti <patricialor@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552226}
[modify] https://crrev.com/6f604f9fc31e56f447fa55fbbb30ccfe45f561eb/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
[modify] https://crrev.com/6f604f9fc31e56f447fa55fbbb30ccfe45f561eb/chrome/common/chrome_features.cc

Labels: Merge-Request-67
Requesting merge of #15 to M67 branch 3396. This is a flat revert of #12 since we are punting the launch of this feature by 1 milestone. It should be very safe to merge since this state was on trunk for a long time prior to #12 landing, and there have been no relevant changes in the interim.
Project Member

Comment 17 by sheriffbot@chromium.org, Apr 20 2018

Labels: -Merge-Request-67 Merge-Review-67 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 38 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
There are no grd changes in #15 (thanks sheriffbot)
Project Member

Comment 19 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc27696e786369a5c795b8a88f2b050f7df0b72a

commit cc27696e786369a5c795b8a88f2b050f7df0b72a
Author: Dominick Ng <dominickn@chromium.org>
Date: Fri Apr 20 21:29:11 2018

Do not show the PWA ambient badge for installed apps.

Feedback from UI review is that this is intrusive (e.g. having Twitter
Lite installed as a PWA, but still viewing tweets in the browser).

BUG=782120

Change-Id: I3b9c622217916decaf49b1d1fdba14fbfa1b1824
Reviewed-on: https://chromium-review.googlesource.com/1015447
Commit-Queue: Ben Wells <benwells@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552476}
[modify] https://crrev.com/cc27696e786369a5c795b8a88f2b050f7df0b72a/chrome/android/java/src/org/chromium/chrome/browser/infobar/InstallableAmbientBadgeInfoBar.java
[modify] https://crrev.com/cc27696e786369a5c795b8a88f2b050f7df0b72a/chrome/app/generated_resources.grd
[modify] https://crrev.com/cc27696e786369a5c795b8a88f2b050f7df0b72a/chrome/browser/banners/app_banner_manager_android.cc
[modify] https://crrev.com/cc27696e786369a5c795b8a88f2b050f7df0b72a/chrome/browser/banners/app_banner_manager_android.h
[modify] https://crrev.com/cc27696e786369a5c795b8a88f2b050f7df0b72a/chrome/browser/installable/installable_ambient_badge_infobar_delegate.cc
[modify] https://crrev.com/cc27696e786369a5c795b8a88f2b050f7df0b72a/chrome/browser/installable/installable_ambient_badge_infobar_delegate.h
[modify] https://crrev.com/cc27696e786369a5c795b8a88f2b050f7df0b72a/chrome/browser/ui/android/infobars/installable_ambient_badge_infobar.cc

Comment 20 by cmasso@google.com, Apr 23 2018

Labels: -Hotlist-Merge-Review -Merge-Review-67 Merge-Approved-67
Can someone else own this bug since dominickn@ is OOO until May 20th?
Yep - Dominick has already arranged for me to help with the merge before he left. Will start the merge now, thank you!
Project Member

Comment 22 by bugdroid1@chromium.org, Apr 24 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c5e44652dd6cf27a0543ef02a43ea111741ccd4

commit 1c5e44652dd6cf27a0543ef02a43ea111741ccd4
Author: Patti <patricialor@chromium.org>
Date: Tue Apr 24 00:56:14 2018

Disable ExperimentalAppBanners by default on Android.

This will be relanded to target M68.

BUG=782120, 811578 
TBR=dominickn@chromium.org

(cherry picked from commit 6f604f9fc31e56f447fa55fbbb30ccfe45f561eb)

Change-Id: I2f67f27e8aacc76c32efb3e3773e2482033b19fb
Reviewed-on: https://chromium-review.googlesource.com/1020560
Reviewed-by: Patti <patricialor@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552226}
Reviewed-on: https://chromium-review.googlesource.com/1025151
Cr-Commit-Position: refs/branch-heads/3396@{#249}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/1c5e44652dd6cf27a0543ef02a43ea111741ccd4/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
[modify] https://crrev.com/1c5e44652dd6cf27a0543ef02a43ea111741ccd4/chrome/common/chrome_features.cc

Project Member

Comment 23 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0553a3dabeb3692185282df8efd2b91ca1eda4f

commit d0553a3dabeb3692185282df8efd2b91ca1eda4f
Author: Dominick Ng <dominickn@chromium.org>
Date: Tue Apr 24 02:51:15 2018

Enable ExperimentalAppBanners by default on Android.

BUG=782120, 811578 

Change-Id: I24d1129b61bf16b800331e1c512191bce529f5b1
Reviewed-on: https://chromium-review.googlesource.com/1020620
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552979}
[modify] https://crrev.com/d0553a3dabeb3692185282df8efd2b91ca1eda4f/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
[modify] https://crrev.com/d0553a3dabeb3692185282df8efd2b91ca1eda4f/chrome/common/chrome_features.cc

Project Member

Comment 24 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b423ee3e193af2ec44260d1f19590fa5b7ea9980

commit b423ee3e193af2ec44260d1f19590fa5b7ea9980
Author: Dominick Ng <dominickn@chromium.org>
Date: Wed May 23 06:54:58 2018

Hide the ambient install infobar for 90 days if it has been dismissed.

This CL reduces the annoyingness of the ambient badge infobar on Android
when browsing a PWA. If the infobar is dismissed, it will not be shown
for 90 days, mirroring the existing block time for infobar app banners.
The infobar will continue to be shown on navigations until it is
dismissed.

BUG=782120, 834259 

Change-Id: Idbbb9e9451fd01f639e859a1b65470330929f993
Reviewed-on: https://chromium-review.googlesource.com/1068903
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560977}
[modify] https://crrev.com/b423ee3e193af2ec44260d1f19590fa5b7ea9980/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
[modify] https://crrev.com/b423ee3e193af2ec44260d1f19590fa5b7ea9980/chrome/browser/banners/app_banner_manager.h
[modify] https://crrev.com/b423ee3e193af2ec44260d1f19590fa5b7ea9980/chrome/browser/banners/app_banner_manager_android.cc
[modify] https://crrev.com/b423ee3e193af2ec44260d1f19590fa5b7ea9980/chrome/browser/banners/app_banner_manager_android.h
[modify] https://crrev.com/b423ee3e193af2ec44260d1f19590fa5b7ea9980/chrome/browser/banners/app_banner_metrics.h
[modify] https://crrev.com/b423ee3e193af2ec44260d1f19590fa5b7ea9980/chrome/browser/installable/installable_ambient_badge_infobar_delegate.cc
[modify] https://crrev.com/b423ee3e193af2ec44260d1f19590fa5b7ea9980/chrome/browser/installable/installable_ambient_badge_infobar_delegate.h
[modify] https://crrev.com/b423ee3e193af2ec44260d1f19590fa5b7ea9980/tools/metrics/histograms/enums.xml

Sign in to add a comment