New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782119 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Security



Sign in to add a comment

Security DCHECK failure: value.IsPrimitiveValue() in CSSPrimitiveValue.h

Project Member Reported by ClusterFuzz, Nov 7 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6227621393465344

Fuzzer: ochang_domfuzzer
Job Type: windows_asan_content_shell
Platform Id: windows

Crash Type: Security DCHECK failure
Crash Address: 
Crash State:
  value.IsPrimitiveValue() in CSSPrimitiveValue.h
  blink::StyleBuilderConverterBase::ConvertFontSize
  blink::FontStyleResolver::ComputeFont
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=495972:496126

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6227621393465344

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 7 2017

Components: Blink>Canvas Blink>CSS
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 7 2017

Labels: Test-Predator-AutoOwner
Owner: rlanday@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/182db0ea27128fe987ad6e70a05626db55664e3a (Remove unused parameter from Font::SelectionRectForText()).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 7 2017

Labels: M-62
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 7 2017

Labels: Pri-1
Cc: rlanday@chromium.org cma...@chromium.org
Labels: Test-Predator-Wrong-Components
Owner: junov@chromium.org
I don't think this can possibly be related to my change, which just removes an unused parameter. I haven't been able to figure out how to reproduce this yet (doesn't seem to repro on Linux...might be Windows-specific for some reason? Or maybe it only repros on the release branch?) and the reproducer test case uses OffscreenCanvas, so I suspect this commit:

https://chromium.googlesource.com/chromium/src/+/08a150acae681dfa3abe9908919cdeea3b2416ce
Fix OffscreenCanvas resizing behavior

Note that Clusterfuzz is claiming this is a security bug for the M62 release we're currently trying to ship, which means we may have to re-spin the release if this is serious.

Comment 6 by junov@chromium.org, Nov 7 2017

Labels: -Pri-1 -Security_Impact-Stable -Security_Severity-High -M-62 Security_Severity-Low Pri-2
Owner: fs...@chromium.org
Fonts + OffscreenCanvas -> fserb

Reducing priority since this failure involves experimental APIs that are currently hidden behind a runtime flag.

Comment 7 by junov@chromium.org, Nov 7 2017

Cc: junov@chromium.org
Labels: Test-Predator-Auto-CC
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner
Labels: -Test-Predator-Auto-CC
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29e4f1d2d25dec624a190c0844d72f54d870d508

commit 29e4f1d2d25dec624a190c0844d72f54d870d508
Author: Fernando Serboncini <fserb@chromium.org>
Date: Thu Nov 09 19:53:14 2017

Ignore inherit fonts on OffscreenCanvas2D

Bug:  782119 
Change-Id: I534996d8f222b0ed277de74c0ee6f860f7d60a36
Reviewed-on: https://chromium-review.googlesource.com/759093
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515250}
[modify] https://crrev.com/29e4f1d2d25dec624a190c0844d72f54d870d508/third_party/WebKit/Source/modules/canvas/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp

Project Member

Comment 13 by ClusterFuzz, Nov 18 2017

ClusterFuzz has detected this issue as fixed in range 514498:517698.

Detailed report: https://clusterfuzz.com/testcase?key=6227621393465344

Fuzzer: ochang_domfuzzer
Job Type: windows_asan_content_shell
Platform Id: windows

Crash Type: Security DCHECK failure
Crash Address: 
Crash State:
  value.IsPrimitiveValue() in CSSPrimitiveValue.h
  blink::StyleBuilderConverterBase::ConvertFontSize
  blink::FontStyleResolver::ComputeFont
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=495972:496126
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=514498:517698

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6227621393465344

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 14 by ClusterFuzz, Nov 18 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6227621393465344 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 15 by sheriffbot@chromium.org, Nov 18 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -Test-Predator-Wrong-Components Test-Predator-Wrong-CLs
Project Member

Comment 17 by sheriffbot@chromium.org, Feb 24 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment