New issue
Advanced search Search tips

Issue 782104 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Task



Sign in to add a comment

Replace WTF::AdoptRef to use base::AdoptRef

Project Member Reported by gyuyoung...@chromium.org, Nov 7 2017

Issue description

As a step to remove RefPtr.h in blink( issue 781740 ), this issue is to replace WTF::AdoptRef with base::AdopRef.
 
Description: Show this description
Owner: gyuyoung...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5063163ce3a7954e54225b7f4dc040de5b68110

commit f5063163ce3a7954e54225b7f4dc040de5b68110
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Wed Nov 08 00:42:04 2017

Replace WTF::AdoptRef with base::AdoptRef in /platform of blink

Blink can use base::AdoptRef now. Replace them with base::AdoptRef in /platform.

Bug:  782104 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7edb2abe043ab77909c1004f5458a9af1bf34f82
Reviewed-on: https://chromium-review.googlesource.com/756656
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514676}
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/CalculationValue.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/DragImageTest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/LayoutLocale.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/PODArena.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/PODFreeListArena.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/SharedBuffer.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/TimerTest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/WebTaskRunner.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/WebTaskRunnerTest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/animation/TimingFunction.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/animation/TimingFunction.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/audio/AudioBus.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/audio/AudioDestination.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/bindings/ScriptState.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/bindings/SharedPersistent.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/blob/BlobData.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/exported/WebContentSettingCallbacks.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/exported/WebCryptoAlgorithm.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/exported/WebCryptoKey.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/exported/WebCryptoKeyAlgorithm.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/exported/WebFileSystemCallbacks.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/exported/WebHTTPLoadInfo.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/exported/WebMediaConstraints.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/exported/WebMediaDeviceInfo.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/exported/WebPrerender.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/exported/WebRTCICECandidate.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/exported/WebRTCSessionDescription.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/fonts/CustomFontData.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/fonts/FontFallbackIterator.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/fonts/FontFallbackList.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/fonts/FontFamily.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/fonts/SegmentedFontData.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/fonts/SimpleFontData.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/fonts/UnicodeRangeSetTest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/fonts/opentype/FontSettings.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/fonts/opentype/OpenTypeVerticalData.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFontCache.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/fonts/shaping/ShapeResultBloberizerTest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/BitmapImage.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/Gradient.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/GradientGeneratedImage.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/ImageLayerChromiumTest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/ImagePattern.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/PaintGeneratedImage.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/PaintRecordPattern.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/PlaceholderImage.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/UnacceleratedStaticBitmapImage.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/filters/DistantLightSource.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/filters/PointLightSource.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/filters/SpotLightSource.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTestHelpers.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/paint/ScrollPaintPropertyNode.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/image-decoders/SegmentReader.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/loader/fetch/CachedMetadata.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadTiming.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/loader/testing/MockFetchContext.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/network/EncodedFormData.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/network/WebSocketHandshakeRequest.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/scheduler/child/web_task_runner_impl.cc
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/scheduler/test/fake_web_task_runner.cc
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisVoice.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/testing/ArenaTestHelpers.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/text/BidiContext.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/text/HyphenationTest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/text/hyphenation/HyphenationMinikin.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/text/mac/HyphenationMac.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/transforms/IdentityTransformOperation.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/transforms/InterpolatedTransformOperation.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/transforms/Matrix3DTransformOperation.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/transforms/MatrixTransformOperation.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/transforms/PerspectiveTransformOperation.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/transforms/RotateTransformOperation.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/transforms/ScaleTransformOperation.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/transforms/SkewTransformOperation.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/transforms/TranslateTransformOperation.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/wtf/FunctionalTest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/wtf/HashMapTest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/wtf/HashSetTest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/wtf/ListHashSetTest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/wtf/RefPtrTest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/wtf/RefVector.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/wtf/TreeNodeTest.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/wtf/text/CString.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/wtf/typed_arrays/ArrayBuffer.h
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/wtf/typed_arrays/ArrayBufferContents.cpp
[modify] https://crrev.com/f5063163ce3a7954e54225b7f4dc040de5b68110/third_party/WebKit/Source/platform/wtf/typed_arrays/TypedArrayBase.h

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee

commit e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Wed Nov 08 04:49:38 2017

Replace WTF::AdoptRef with base::AdoptRef in /core of blink

Blink can use base::AdoptRef now. Replace them with base::AdoptRef in /core.

In order to allow the use of base::AdoptRef in /core, this CL adds base::AdoptRef
to chromium_allowed_classes in PRESUBMIT.py.

Bug:  782104 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5b4ee176fdea8e6e2adf55a25016420b2a85e47c
Reviewed-on: https://chromium-review.googlesource.com/756648
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514751}
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/PRESUBMIT.py
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/CSSDefaultInterpolationType.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/CSSFontVariationSettingsInterpolationType.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/CSSImageInterpolationType.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/CSSOffsetRotateInterpolationType.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/CSSRayInterpolationType.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/FilterInterpolationFunctions.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/LengthInterpolationFunctions.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/ListInterpolationFunctions.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/PathInterpolationFunctions.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/SVGValueInterpolationType.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/ShadowInterpolationFunctions.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/SizeInterpolationFunctions.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/StringKeyframe.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/StringKeyframe.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/TransitionInterpolation.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/TransitionKeyframe.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/animatable/AnimatableDouble.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/animatable/AnimatableFilterOperations.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/animatable/AnimatableTransform.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/animation/animatable/AnimatableUnknown.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/css/CSSCustomFontData.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/css/CSSFontFace.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/css/CSSSelector.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/css/CSSVariableData.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/css/MediaList.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/css/invalidation/InvalidationSet.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/dom/QualifiedName.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/dom/SpaceSplitString.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/dom/UserGestureIndicator.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/editing/FrameCaretTest.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/exported/WebPagePopupImpl.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/html/forms/FileChooser.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/html/parser/HTMLParserReentryPermit.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/html/parser/TokenizedChunkQueue.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/CounterNode.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/HitTestingTransformState.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/LayoutBoxTest.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/LayoutThemeAndroid.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/LayoutThemeFuchsia.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/LayoutThemeLinux.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/LayoutThemeMobile.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/LayoutThemeWin.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/line/AbstractInlineTextBox.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_break_token.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/ng/inline/ng_physical_line_box_fragment.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/ng/inline/ng_physical_text_fragment.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/ng/inline/ng_text_fragment_builder.cc
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/ng/ng_block_break_token.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/ng/ng_layout_result.cc
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/ng/ng_physical_box_fragment.cc
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/layout/ng/ng_unpositioned_float.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/paint/ClipRects.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/style/BasicShapes.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/style/ClipPathOperation.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/style/NinePieceImage.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/style/QuotesData.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/style/SVGComputedStyle.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/style/SVGComputedStyleDefs.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/style/SVGComputedStyleDefs.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/style/ShadowList.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/style/StyleInheritedVariables.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/style/StylePath.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/style/StyleRay.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/style/StyleReflection.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/svg/graphics/SVGImage.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/typed_arrays/DOMDataView.cpp
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/workers/WorkerScriptLoader.h
[modify] https://crrev.com/e8afbe9262dfbb73a909dcf03bd09eb1a21c65ee/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6287b3c44a53e496b480b93137c4d159b8464b4

commit f6287b3c44a53e496b480b93137c4d159b8464b4
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Wed Nov 08 07:39:24 2017

Replace WTF::AdoptRef with base::AdoptRef in /modules of blink

Blink can use base::AdoptRef now. Replace them with base::AdoptRef in /modules.
Additionally, the uses of WTF::AdoptRef are also replaced in
third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl

Bug:  782104 
Change-Id: I3ddd374ed14cdd2193ecf642ab0d0a06e84c8071
Reviewed-on: https://chromium-review.googlesource.com/757941
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514774}
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/crypto/CryptoResultImpl.h
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/indexeddb/IDBMetadata.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/indexeddb/IDBValue.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/AnalyserNode.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandler.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/AudioParam.h
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/ChannelMergerNode.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/ChannelSplitterNode.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/ConstantSourceNode.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/GainNode.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/OscillatorNode.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/PannerNode.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/ScriptProcessorNode.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webaudio/StereoPannerNode.cpp
[modify] https://crrev.com/f6287b3c44a53e496b480b93137c4d159b8464b4/third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41398b3a32dd36e96179862c5393dd3ac8151339

commit 41398b3a32dd36e96179862c5393dd3ac8151339
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Wed Nov 08 09:33:38 2017

Replace WTF::AdoptRef with base::AdoptRef in /bindings of blink

Blink can use base::AdoptRef now. Replace them with base::AdoptRef in /bindings
as well.

Bug:  782104 
Change-Id: I1f6ab16223928cb79f3376ba9025eaa6365573d8
Reviewed-on: https://chromium-review.googlesource.com/757888
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514787}
[modify] https://crrev.com/41398b3a32dd36e96179862c5393dd3ac8151339/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.h
[modify] https://crrev.com/41398b3a32dd36e96179862c5393dd3ac8151339/third_party/WebKit/Source/bindings/core/v8/V8BindingForTesting.cpp
[modify] https://crrev.com/41398b3a32dd36e96179862c5393dd3ac8151339/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValue.cpp

Status: Fixed (was: Untriaged)
I think all uses of WTF::AdoptRef in blink were removed finally. Closed.

Sign in to add a comment