New issue
Advanced search Search tips

Issue 782095 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

media/.../track-kind.html in webkit_layout_tests failing on chromium.webkit/WebKit Win10

Project Member Reported by meade@chromium.org, Nov 7 2017

Issue description

media/.../track-kind.html in webkit_layout_tests failing on chromium.webkit/WebKit Win10

Builders failed on: 
- WebKit Win10: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10


Test is timing out. First failed build:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/27426

I can't see any obvious suspect in the list. This is a really old test, so I'm not sure where to send this... mlamouri@ and fs@, could you PTAL and reassign where appropriate? Thanks.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7de4eacfeeb4e10600957504bb9aaf6029e73216

commit 7de4eacfeeb4e10600957504bb9aaf6029e73216
Author: Eddy Mead <meade@chromium.org>
Date: Tue Nov 07 04:27:34 2017

[Chromium sheriff] Add Timeout to TestExpectations for media/track/track-kind.html

TBR=shend@chromium.org

Bug:  782095 
Change-Id: Ib0e8b999af3a3a40715113c2565de515d20b4981
Reviewed-on: https://chromium-review.googlesource.com/756139
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514387}
[modify] https://crrev.com/7de4eacfeeb4e10600957504bb9aaf6029e73216/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by meade@chromium.org, Nov 7 2017

Labels: -Sheriff-Chromium
Removing sheriff label since test is now allowed to timeout
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21ae2fa294051f3a3a6194a081bfae0f7744c716

commit 21ae2fa294051f3a3a6194a081bfae0f7744c716
Author: Eddy Mead <meade@chromium.org>
Date: Tue Nov 07 05:48:59 2017

[Chromium sheriff] Make timeout expectation for media/track/track-kind.html to all kinds of windows
platforms, as it also started failing on others.

Win7 failure:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/57265

TBR=rjwright@chromium.org

Bug:  782095 
Change-Id: I3df66874619c496b11ced3c45a806d50d3095b8e
Reviewed-on: https://chromium-review.googlesource.com/756636
Reviewed-by: meade_UTC10 <meade@chromium.org>
Reviewed-by: Renée Wright <rjwright@chromium.org>
Commit-Queue: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514407}
[modify] https://crrev.com/21ae2fa294051f3a3a6194a081bfae0f7744c716/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by f...@opera.com, Nov 7 2017

Cc: -f...@opera.com mlamouri@chromium.org
Owner: f...@opera.com
Status: Assigned (was: Available)
I'd suspect that the change in behavior from 1aec1a92fb786cae0a24ff2b22d4858d4486252e now cause the <track> 'load' to be dispatched before the handler is added, meaning that testKind() only runs once and the test times out. Some mild tinkering seems to confirm that.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7284e5e7452bfeb539b7d1f3c698d8b967371d19

commit 7284e5e7452bfeb539b7d1f3c698d8b967371d19
Author: Fredrik Söderquist <fs@opera.com>
Date: Wed Nov 08 14:11:57 2017

Remove media/track/track-kind.html

Remove this test in favor of the existing and overlapping coverage in
Web Platform Tests:

  html/semantics/embedded-content/media-elements/interfaces/
    HTMLElement/HTMLTrackElement/kind.html
    TextTrack/kind.html

Bug:  782095 
Change-Id: Iff866ddabaa69a30e24f6126f202c6cbd431425a
Reviewed-on: https://chromium-review.googlesource.com/756752
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#514817}
[modify] https://crrev.com/7284e5e7452bfeb539b7d1f3c698d8b967371d19/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/f2bfc8c76fdfa4cacb21e3a7710c515d6e2030bf/third_party/WebKit/LayoutTests/media/track/track-kind.html

Comment 6 by f...@opera.com, Nov 8 2017

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b5b9a5186a48157f699d112409b429d76a40deb

commit 0b5b9a5186a48157f699d112409b429d76a40deb
Author: Fredrik Söderquist <fs@opera.com>
Date: Mon Nov 13 11:25:35 2017

Avoid track 'load' race in a few media/track/ tests

In media/track/, the following tests seemed to exhibit the same timeout
behavior as track-kind.html:

  track-default-attribute.html
  track-load-error-readyState.html
  track-load-from-element-readyState.html

The default track could finish loading before the event handler was
added. Move the external <script>s earlier (to within <head>) and attach
event handlers before </video>.

Bug:  782095 
Change-Id: I103e6d24a20f8b164a38a9014eae98528a6caf92
Reviewed-on: https://chromium-review.googlesource.com/757012
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#515925}
[modify] https://crrev.com/0b5b9a5186a48157f699d112409b429d76a40deb/third_party/WebKit/LayoutTests/media/track/track-default-attribute.html
[modify] https://crrev.com/0b5b9a5186a48157f699d112409b429d76a40deb/third_party/WebKit/LayoutTests/media/track/track-load-error-readyState.html
[modify] https://crrev.com/0b5b9a5186a48157f699d112409b429d76a40deb/third_party/WebKit/LayoutTests/media/track/track-load-from-element-readyState.html

Sign in to add a comment