New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 782094 link

Starred by 1 user
Status: Fixed
Owner:
dominickn@chromium.org
Closed: Nov 2017
Cc:
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

AppBannerInfoBarDelegateAndroid makes two copies of the app icon

Project Member Reported by dominickn@chromium.org, Nov 7 2017 
The icon is:

 - stored as an SkBitmap
 - converted to a gfx::Image in GetIcon()
 - converted back to an SkBitmap to send to Java

This back and forth conversion can be avoided by just keeping the icon as an SkBitmap.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5adaed784e2dbc04dbfd578163ffd4418a4a1b8e

commit 5adaed784e2dbc04dbfd578163ffd4418a4a1b8e
Author: Dominick Ng <dominickn@chromium.org>
Date: Wed Nov 08 06:08:52 2017

Remove unnecessary type conversions when displaying an app banner.

This CL removes a cyclic conversion SkBitmap -> gfx::Image -> SkBitmap
in the display of an app banner on Android. The gfx::Image step is
removed entirely.

BUG= 782094 

Change-Id: I3ddd70e848fe6d9387040ebb68ff457610b5f236
Reviewed-on: https://chromium-review.googlesource.com/756140
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514770}
[modify] https://crrev.com/5adaed784e2dbc04dbfd578163ffd4418a4a1b8e/chrome/browser/banners/app_banner_infobar_delegate_android.cc
[modify] https://crrev.com/5adaed784e2dbc04dbfd578163ffd4418a4a1b8e/chrome/browser/banners/app_banner_infobar_delegate_android.h
[modify] https://crrev.com/5adaed784e2dbc04dbfd578163ffd4418a4a1b8e/chrome/browser/ui/android/infobars/app_banner_infobar_android.cc
[modify] https://crrev.com/5adaed784e2dbc04dbfd578163ffd4418a4a1b8e/chrome/browser/ui/android/infobars/app_banner_infobar_android.h

Comment 2 by dominickn@chromium.org, Nov 8 2017

Status: Fixed (was: Started)
►

Sign in to add a comment