fast/.../no-recalc-on-no-op-inline-style-changes.html in webkit_layout_tests failing on chromium.webkit/WebKit Mac10.11 |
||||||||
Issue descriptionfast/.../no-recalc-on-no-op-inline-style-changes.html in webkit_layout_tests failing on chromium.webkit/WebKit Mac10.11 Builders failed on: - WebKit Mac10.11: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11 First failing build https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/25247 Error: FAIL Check that a no-op inline style change doesn't result in a recalc assert_greater_than: expected a number greater than 1 but got 1 Test link: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/css/no-recalc-on-no-op-inline-style-changes.html It looks like the test is failing due to the number of recalcs before the test starts being only 1. I'm not familiar enough with the intention of the test to know whether this matters. nainar@, do you know whether this is a spurious failure? I would have thought the part we're actually trying to test is everything after line 12...
,
Nov 7 2017
How did this ever work? Line 1 should have always been false since the test is run after loading :/
,
Nov 7 2017
I have no idea...
,
Nov 7 2017
Issue 782294 has been merged into this issue.
,
Nov 7 2017
This is also failing on Mac10.10.
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/060dd71c370d5a145c8a57e9033811829da6b4a3 commit 060dd71c370d5a145c8a57e9033811829da6b4a3 Author: Scott Violet <sky@chromium.org> Date: Tue Nov 07 19:13:13 2017 Mark fast/css/no-recalc-on-no-op-inline-style-changes.html as failing on Mac10.10 It seems to be failing there too. BUG= 782067 TEST=none TBR=nainar@chromium.org Change-Id: I2d0d768d0ead848bbe9570e2c51933890470ea47 Reviewed-on: https://chromium-review.googlesource.com/757458 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#514529} [modify] https://crrev.com/060dd71c370d5a145c8a57e9033811829da6b4a3/third_party/WebKit/LayoutTests/TestExpectations
,
Nov 8 2017
The test faiiure on Line 11: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/css/no-recalc-on-no-op-inline-style-changes.html?q=no-recalc&sq=package:chromium&l=11 Makes it sound like we are recalcing less elements. If you remove it the expectation on line 14: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/css/no-recalc-on-no-op-inline-style-changes.html?q=no-recalc&sq=package:chromium&l=14 fails as well - the number of elements being recalced there are 3. However we should be recalcing 1.
,
Dec 6 2017
,
Feb 2 2018
,
Feb 8 2018
,
Feb 9 2018
,
May 25 2018
This test was removed in https://chromium.googlesource.com/chromium/src/+/9d45b94d610d27094ccfd07d20b7283813fa0bf6. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 7 2017