New issue
Advanced search Search tips

Issue 782065 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

fix calls to new when registering a component installer

Project Member Reported by sorin@chromium.org, Nov 7 2017

Issue description

use a creator function to avoid the calls to new operator.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d7fe60747a71d451b67cc7beca23e5df5cb3891

commit 9d7fe60747a71d451b67cc7beca23e5df5cb3891
Author: Sorin Jianu <sorin@chromium.org>
Date: Tue Nov 07 22:44:59 2017

Fix calls to new when registering a component installer.

Bug:  782065 
Change-Id: I66964b0ff88ebb153e24af10a97f1efb83a3d0bd
Reviewed-on: https://chromium-review.googlesource.com/756366
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514632}
[modify] https://crrev.com/9d7fe60747a71d451b67cc7beca23e5df5cb3891/chrome/browser/component_updater/component_updater_resource_throttle.cc
[modify] https://crrev.com/9d7fe60747a71d451b67cc7beca23e5df5cb3891/chrome/browser/component_updater/crl_set_component_installer.cc
[modify] https://crrev.com/9d7fe60747a71d451b67cc7beca23e5df5cb3891/chrome/browser/component_updater/cros_component_installer.cc
[modify] https://crrev.com/9d7fe60747a71d451b67cc7beca23e5df5cb3891/chrome/browser/component_updater/file_type_policies_component_installer.cc
[modify] https://crrev.com/9d7fe60747a71d451b67cc7beca23e5df5cb3891/chrome/browser/component_updater/origin_trials_component_installer.cc
[modify] https://crrev.com/9d7fe60747a71d451b67cc7beca23e5df5cb3891/chrome/browser/component_updater/pepper_flash_component_installer.cc
[modify] https://crrev.com/9d7fe60747a71d451b67cc7beca23e5df5cb3891/chrome/browser/component_updater/pnacl_component_installer.cc
[modify] https://crrev.com/9d7fe60747a71d451b67cc7beca23e5df5cb3891/chrome/browser/component_updater/recovery_improved_component_installer.cc
[modify] https://crrev.com/9d7fe60747a71d451b67cc7beca23e5df5cb3891/chrome/browser/component_updater/ssl_error_assistant_component_installer.cc
[modify] https://crrev.com/9d7fe60747a71d451b67cc7beca23e5df5cb3891/chrome/browser/component_updater/sth_set_component_installer.cc
[modify] https://crrev.com/9d7fe60747a71d451b67cc7beca23e5df5cb3891/chrome/browser/component_updater/subresource_filter_component_installer.cc
[modify] https://crrev.com/9d7fe60747a71d451b67cc7beca23e5df5cb3891/chrome/browser/component_updater/sw_reporter_installer_win.cc
[modify] https://crrev.com/9d7fe60747a71d451b67cc7beca23e5df5cb3891/chrome/browser/component_updater/third_party_module_list_component_installer_win.cc
[modify] https://crrev.com/9d7fe60747a71d451b67cc7beca23e5df5cb3891/chrome/browser/component_updater/widevine_cdm_component_installer.cc
[modify] https://crrev.com/9d7fe60747a71d451b67cc7beca23e5df5cb3891/components/component_updater/component_installer.cc
[modify] https://crrev.com/9d7fe60747a71d451b67cc7beca23e5df5cb3891/components/component_updater/component_installer.h

Comment 2 by sorin@chromium.org, Nov 7 2017

Status: Fixed (was: Assigned)

Sign in to add a comment