New issue
Advanced search Search tips

Issue 782048 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

suite num parameter is not used

Project Member Reported by ayatane@chromium.org, Nov 7 2017

Issue description

The suite num parameter is documented to be the maximum number of hosts to use.  However, the parameter is not actually used anywhere.

It should be removed, but care needs to be taken for all of the places it is referenced and for backward compatibility.

cbuildbot
run_suite.py
RPC interface
dynamic suite

(provision suite uses it at this moment, but that will be changed soon.)
 
Labels: -Restrict-View-Google
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/7b0db0f35028052040c834bc04388c2856bb9ef2

commit 7b0db0f35028052040c834bc04388c2856bb9ef2
Author: Allen Li <ayatane@chromium.org>
Date: Thu Nov 30 02:04:38 2017

Deprecate num from RunHWTestSuite

num is not used.  It gets passed all the way to the create_suite_job
AFE RPC in Autotest, and then gets discarded without being inserted
into the control file or elsewhere.  The host scheduler does not use
it.

Therefore the claim that it specifies the maximum number of devices to
use is a blatant lie, or, according to the contemporary lexicon, an
alternative fact.

This commit deprecates it from cbuildbot.  Future commits will remove
num from Autotest.

Since RunHWTestSuite is referenced in a lot of places, leave the
parameter in place for now and log a warning.  That makes it easier to
land commits to fix references in multiple parts, instead of having to
get a giant commit right all at once.

BUG=chromium:782048
TEST=None

Change-Id: I89b6981d91f6ba4d2f5bf330d820ce0ef8fdd8bc
Reviewed-on: https://chromium-review.googlesource.com/791393
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/7b0db0f35028052040c834bc04388c2856bb9ef2/cbuildbot/commands.py
[modify] https://crrev.com/7b0db0f35028052040c834bc04388c2856bb9ef2/cbuildbot/commands_unittest.py

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/40c845477eab71685471f00d8cdf1889ed6cc159

commit 40c845477eab71685471f00d8cdf1889ed6cc159
Author: Allen Li <ayatane@chromium.org>
Date: Sat Dec 02 04:32:43 2017

Remove RunHWTestSuite num parameter

num is not used.  It gets passed all the way to the create_suite_job
AFE RPC in Autotest, and then gets discarded without being inserted
into the control file or elsewhere.  The host scheduler does not use
it.

Therefore the claim that it specifies the maximum number of devices to
use is a blatant lie, or, according to the contemporary lexicon, an
alternative fact.

BUG=chromium:782048
TEST=None

Change-Id: Iaea1f5148933a23312f67d98eac58c61ce803fb3
Reviewed-on: https://chromium-review.googlesource.com/791394
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/40c845477eab71685471f00d8cdf1889ed6cc159/cbuildbot/config_dump.json
[modify] https://crrev.com/40c845477eab71685471f00d8cdf1889ed6cc159/cbuildbot/stages/test_stages.py
[modify] https://crrev.com/40c845477eab71685471f00d8cdf1889ed6cc159/cbuildbot/commands.py
[modify] https://crrev.com/40c845477eab71685471f00d8cdf1889ed6cc159/cbuildbot/chromeos_config.py

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/97642e00cb524118426debb612e2503562655c4d

commit 97642e00cb524118426debb612e2503562655c4d
Author: Allen Li <ayatane@chromium.org>
Date: Tue Dec 05 04:02:37 2017

Remove HWTestConfig num parameter [1/2]

This must be done in two parts to land config_dump.json correctly.

BUG=chromium:782048
TEST=None

Change-Id: I20c0474ffe6a2dc02b56cbd53e74fcd60d6f87f4
Reviewed-on: https://chromium-review.googlesource.com/801109
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/97642e00cb524118426debb612e2503562655c4d/cbuildbot/config_dump.json
[modify] https://crrev.com/97642e00cb524118426debb612e2503562655c4d/lib/config_lib.py

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/7303746a7c18da3cbe44f967608e12223a15d836

commit 7303746a7c18da3cbe44f967608e12223a15d836
Author: Allen Li <ayatane@chromium.org>
Date: Tue Dec 05 04:02:38 2017

Remove HWTestConfig num parameter [2/2]

This must be done in two parts to land config_dump.json correctly.

BUG=chromium:782048
TEST=None

Change-Id: If0a40987dd4fcc58f588e687f78b6d65604775e7
Reviewed-on: https://chromium-review.googlesource.com/801794
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/7303746a7c18da3cbe44f967608e12223a15d836/lib/constants.py
[modify] https://crrev.com/7303746a7c18da3cbe44f967608e12223a15d836/lib/config_lib.py

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/04afc8f3b08c565b8988383c02689d547e688823

commit 04afc8f3b08c565b8988383c02689d547e688823
Author: Allen Li <ayatane@chromium.org>
Date: Wed Dec 06 04:22:42 2017

[autotest] Deprecate num parameter

This isnt used; see the bug.

BUG=chromium:782048
TEST=None
CQ-DEPEND=CL:791394

Change-Id: I0557d71362445691fc5ac02840fdaa75215a0c9e
Reviewed-on: https://chromium-review.googlesource.com/791999
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/04afc8f3b08c565b8988383c02689d547e688823/server/cros/dynamic_suite/dynamic_suite.py
[modify] https://crrev.com/04afc8f3b08c565b8988383c02689d547e688823/test_suites/control.wifi_perf_bcm4371
[modify] https://crrev.com/04afc8f3b08c565b8988383c02689d547e688823/site_utils/run_suite.py
[modify] https://crrev.com/04afc8f3b08c565b8988383c02689d547e688823/cli/suite.py
[modify] https://crrev.com/04afc8f3b08c565b8988383c02689d547e688823/frontend/afe/rpc_interface_unittest.py
[modify] https://crrev.com/04afc8f3b08c565b8988383c02689d547e688823/test_suites/control.wifi_matfunc_bcm4371
[modify] https://crrev.com/04afc8f3b08c565b8988383c02689d547e688823/site_utils/test_push.py
[modify] https://crrev.com/04afc8f3b08c565b8988383c02689d547e688823/server/cros/dynamic_suite/dynamic_suite_unittest.py
[modify] https://crrev.com/04afc8f3b08c565b8988383c02689d547e688823/frontend/afe/rpc_interface.py

Current release is R65, final references to num can be removed in R66 (R66 moblab should support back until R65)
Components: Infra>Client>ChromeOS>CI
Components: -Infra>Client>ChromeOS

Sign in to add a comment