Print-to-PDF suggests nonsensical filename |
|||
Issue descriptionChrome Version: (copy from chrome://version) 62.0.3202.75 (Official Build) (64-bit) OS: (e.g. Win7, OSX 10.9.5, etc...) Ubuntu Trusty What steps will reproduce the problem? (1) Go to data:text/html,<title>someone@example.com (2) Press Ctrl-S and observe the suggested filename (3) Press Ctrl-P and select to save as PDF (4) Click Save and observe the suggested filename What is the expected result? The print-to-PDF filename is "someone@example.com.pdf" to match the format of the Save suggested filename (someone@example.com.html). What happens instead? The print-to-PDF filename is "someone@example.pdf", unnecessarily mangling the title.
,
Nov 8 2017
Oh, the code that interacts with the file dialog decided .com is a file extension.
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd28e707ae73eb32d43943846c14880fbb700fff commit fd28e707ae73eb32d43943846c14880fbb700fff Author: Lei Zhang <thestig@chromium.org> Date: Thu Nov 09 00:02:59 2017 Add tests for file name generation in PdfPrinterHandler. Split out the tested code into a static method. BUG= 782041 Change-Id: I24aafa02a7294b92253061280080c65a218c74cc Reviewed-on: https://chromium-review.googlesource.com/757978 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#515017} [modify] https://crrev.com/fd28e707ae73eb32d43943846c14880fbb700fff/chrome/browser/ui/webui/print_preview/pdf_printer_handler.cc [modify] https://crrev.com/fd28e707ae73eb32d43943846c14880fbb700fff/chrome/browser/ui/webui/print_preview/pdf_printer_handler.h [add] https://crrev.com/fd28e707ae73eb32d43943846c14880fbb700fff/chrome/browser/ui/webui/print_preview/pdf_printer_handler_unittest.cc [modify] https://crrev.com/fd28e707ae73eb32d43943846c14880fbb700fff/chrome/browser/ui/webui/print_preview/pdf_printer_handler_win_unittest.cc [modify] https://crrev.com/fd28e707ae73eb32d43943846c14880fbb700fff/chrome/test/BUILD.gn
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/26228de5277b64fcadedad08c50417c3cb9be026 commit 26228de5277b64fcadedad08c50417c3cb9be026 Author: Lei Zhang <thestig@chromium.org> Date: Thu Nov 09 20:37:45 2017 Fix file name generation in PdfPrinterHandler. Make it behave more like Save As as implemented in the downloads code. BUG= 375330 , 782041 Change-Id: I62d373f8f356bc6614ffa2ad293fc05a3d9e1ba3 Reviewed-on: https://chromium-review.googlesource.com/759411 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#515276} [modify] https://crrev.com/26228de5277b64fcadedad08c50417c3cb9be026/chrome/browser/ui/webui/print_preview/pdf_printer_handler.cc [modify] https://crrev.com/26228de5277b64fcadedad08c50417c3cb9be026/chrome/browser/ui/webui/print_preview/pdf_printer_handler.h [modify] https://crrev.com/26228de5277b64fcadedad08c50417c3cb9be026/chrome/browser/ui/webui/print_preview/pdf_printer_handler_unittest.cc [modify] https://crrev.com/26228de5277b64fcadedad08c50417c3cb9be026/chrome/browser/ui/webui/print_preview/pdf_printer_handler_win_unittest.cc
,
Nov 9 2017
Thanks for filing the bug to provide extra motivation to fix this.
,
Apr 27 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by thestig@chromium.org
, Nov 7 2017