Add clickable links feature to LogDog |
||
Issue descriptionThere are times when it would be extremely helpful to be able to toggle clickable links in LogDog output.
,
Nov 7 2017
Can you be more specific about which links you'd want clickable?
,
Nov 7 2017
All of them? Example output: https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromeos%2Fcaroline-release%2F1189%2F%2B%2Frecipes%2Fsteps%2FHWTest__bvt-arc_%2F0%2Fstdout The text output contains lots of links like: http://cautotest-prod.corp.google.com/afe/#tab_id=view_job&object_id=154216274 I get that parsing the entire output and turning 'http://blah' into links may be slow and/or undesireable to do by default, but it would be handy to have an option to do so. I'm sure I can find an extension to do that, but I'd have to find one that is trustworthy (or write it).
,
Nov 7 2017
It's a great idea! It's also totally do-able, but would take some internal code updates. Right now, LogDog bundles log messages into a series of vertical <div>s, each containing several lines worth of newline-delimited text. Chrome (and other browsers) render this very quickly. We'd have to change that logic to identify lines with link regexps and break it into a before-<div>, a separate <div> w/ that line formatted as HTML (instead of straight text), and then an after-<div> of the remainder (potentially broken up similarly). Fortunately: 1) Logs already come broken up by lines, so no delimiter parsing is necessary. 2) The logic to emit lines operates on an Array of lines, so this isn't actually so bad. 3) Most of the time spent rendering is reflow, NOT log processing time. The place to add this sort of processing is probably here: https://chromium.googlesource.com/infra/luci/luci-go/+/cca232833532f09634888996b73582691fda470c/web/inc/logdog-stream-view/view.ts#349 You'd probably want to update CSS to make the ensuing links not underlined-blue hideousness: https://chromium.googlesource.com/infra/luci/luci-go/+/cca232833532f09634888996b73582691fda470c/web/inc/logdog-stream-view/logdog-stream-view.html#58 I'd be happy to discuss further, help someone test, or review a CL for this if someone wants to give it a shot.
,
Dec 5 2017
,
Sep 26
|
||
►
Sign in to add a comment |
||
Comment 1 by hinoka@chromium.org
, Nov 7 2017