Add close/maximize/minimize/restore options when right clicking the tabstrip background |
|||||
Issue descriptionModern version of GNOME by default omit the minimize and maximize buttons. In this case, Chrome correctly displays just a close button, but does not provide any other way to minimize or maximize the window (besides, if the window manager allows it, double clicking on the titlebar or dragging the window to the top edge). Windows in GNOME do provide a way to do this though: right clicking on the titlebar shows options for close, minimize, and maximize. We should add any missing buttons to the tabstrip right-click menu.
,
Nov 7 2017
This seems reasonable to me, since that's the platform expectations.
,
Nov 7 2017
Yes, in fact on windows we show a number of such options.
,
Nov 8 2017
In that case, I think we should always show all of the options, because that's what windows Chrome does, and it's what Linux GTK apps do.
,
Nov 8 2017
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f15ede50a29d9d4bf0d3aeb2ddc67188a0188b83 commit f15ede50a29d9d4bf0d3aeb2ddc67188a0188b83 Author: Tom Anderson <thomasanderson@chromium.org> Date: Fri Nov 10 03:17:15 2017 [Linux] Add min/max/restore/close options to browser frame menu BUG= 782028 R=sky@chromium.org Change-Id: Idc91012a8cd8d851f85d6c45d81677354f05364e Reviewed-on: https://chromium-review.googlesource.com/759100 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#515437} [modify] https://crrev.com/f15ede50a29d9d4bf0d3aeb2ddc67188a0188b83/chrome/app/chrome_command_ids.h [modify] https://crrev.com/f15ede50a29d9d4bf0d3aeb2ddc67188a0188b83/chrome/app/generated_resources.grd [modify] https://crrev.com/f15ede50a29d9d4bf0d3aeb2ddc67188a0188b83/chrome/browser/ui/browser_command_controller.cc [modify] https://crrev.com/f15ede50a29d9d4bf0d3aeb2ddc67188a0188b83/chrome/browser/ui/views/frame/system_menu_model_builder.cc [modify] https://crrev.com/f15ede50a29d9d4bf0d3aeb2ddc67188a0188b83/chrome/browser/ui/views/frame/system_menu_model_delegate.cc [modify] https://crrev.com/f15ede50a29d9d4bf0d3aeb2ddc67188a0188b83/chrome/browser/ui/views/frame/system_menu_model_delegate.h
,
Nov 10 2017
,
Nov 13 2017
Tested this on Linux Ubuntu 14.04 and compared the context menu b/w 63.0.3239.40 and 64.0.3267.0. Observed min/max/close in the context menu but no 'restore' option. Tom@: Could you please take a look at this and confirm if the screen-shots are WAI.
,
Nov 13 2017
You need to maximize the window to see the restore button |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by thomasanderson@chromium.org
, Nov 7 2017