New issue
Advanced search Search tips

Issue 782025 link

Starred by 1 user
Status: Fixed
Owner:
cmumford@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 598073



Sign in to add a comment

Support component extension resources with Network Service enabled

Project Member Reported by roc...@chromium.org, Nov 7 2017 
Component extension resources are loaded a bit differently from other extensions resources. Tracking that work separately.

Comment 1 by roc...@chromium.org, Nov 7 2017

Blocking: 598073
Status: Assigned (was: Available)

Comment 2 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 3 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service
Apologies, applied the wrong component in bulk.

Comment 4 by roc...@chromium.org, Nov 8 2017 

The old path does this through ChromeExtensionsBrowserClient::MaybeCreateResourceBundleRequestJob. Haven't looked into it in much further detail yet, but we need to essentially cover through same behavior in ExtensionURLLoaderFactory. Most likely this will mean introducing a new ExtensionsBrowserClient method.

Comment 5 by cmumford@chromium.org, Dec 4 2017

Owner: cmumford@chromium.org

Comment 6 by cmumford@chromium.org, Dec 4 2017

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c67e063843e4bd37522692d9b74586a2304575e5

commit c67e063843e4bd37522692d9b74586a2304575e5
Author: Chris Mumford <cmumford@chromium.org>
Date: Fri Feb 16 03:06:07 2018

Load resources from extension bundles in the network service.

Bug:  782025 
Change-Id: I144d650ff86af288a22afbc4173c94de46da4faf
Reviewed-on: https://chromium-review.googlesource.com/834749
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537165}
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/chrome/browser/extensions/DEPS
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/chrome/browser/extensions/chrome_content_verifier_delegate.cc
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/chrome/browser/extensions/chrome_extensions_browser_client.cc
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/chrome/browser/extensions/chrome_extensions_browser_client.h
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/chrome/browser/extensions/chrome_url_request_util.cc
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/chrome/browser/extensions/chrome_url_request_util.h
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/chrome/browser/extensions/extension_protocols_unittest.cc
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/chromecast/browser/extensions/cast_extensions_browser_client.cc
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/chromecast/browser/extensions/cast_extensions_browser_client.h
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/content/browser/file_url_loader_factory.cc
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/content/public/browser/file_url_loader.h
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/extensions/browser/extension_protocols.cc
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/extensions/browser/extension_protocols.h
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/extensions/browser/extensions_browser_client.h
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/extensions/browser/test_extensions_browser_client.cc
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/extensions/browser/test_extensions_browser_client.h
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/extensions/shell/browser/shell_extensions_browser_client.cc
[modify] https://crrev.com/c67e063843e4bd37522692d9b74586a2304575e5/extensions/shell/browser/shell_extensions_browser_client.h
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8706c4d78dd68c46cbe0826fbb65d48b5c488dee

commit 8706c4d78dd68c46cbe0826fbb65d48b5c488dee
Author: Takeshi Yoshino <tyoshino@chromium.org>
Date: Fri Feb 16 06:08:16 2018

Revert "Load resources from extension bundles in the network service."

This reverts commit c67e063843e4bd37522692d9b74586a2304575e5.

Reason for revert: Broke unit_tests on Linux CFI bot. See my comment for details

Original change's description:
> Load resources from extension bundles in the network service.
> 
> Bug:  782025 
> Change-Id: I144d650ff86af288a22afbc4173c94de46da4faf
> Reviewed-on: https://chromium-review.googlesource.com/834749
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537165}

TBR=nick@chromium.org,jam@chromium.org,rockot@chromium.org,rdevlin.cronin@chromium.org,cmumford@chromium.org

Change-Id: I57b1630225b9be7020c83d09aa782ec31d67b985
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  782025 
Reviewed-on: https://chromium-review.googlesource.com/923761
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537228}
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/chrome/browser/extensions/DEPS
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/chrome/browser/extensions/chrome_content_verifier_delegate.cc
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/chrome/browser/extensions/chrome_extensions_browser_client.cc
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/chrome/browser/extensions/chrome_extensions_browser_client.h
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/chrome/browser/extensions/chrome_url_request_util.cc
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/chrome/browser/extensions/chrome_url_request_util.h
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/chrome/browser/extensions/extension_protocols_unittest.cc
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/chromecast/browser/extensions/cast_extensions_browser_client.cc
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/chromecast/browser/extensions/cast_extensions_browser_client.h
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/content/browser/file_url_loader_factory.cc
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/content/public/browser/file_url_loader.h
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/extensions/browser/extension_protocols.cc
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/extensions/browser/extension_protocols.h
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/extensions/browser/extensions_browser_client.h
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/extensions/browser/test_extensions_browser_client.cc
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/extensions/browser/test_extensions_browser_client.h
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/extensions/shell/browser/shell_extensions_browser_client.cc
[modify] https://crrev.com/8706c4d78dd68c46cbe0826fbb65d48b5c488dee/extensions/shell/browser/shell_extensions_browser_client.h
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f8126680433a020fae54e416790e652e16380e8

commit 8f8126680433a020fae54e416790e652e16380e8
Author: Chris Mumford <cmumford@chromium.org>
Date: Thu Feb 22 00:27:57 2018

[Reland] Load resources from extension bundles in the network service.

This is a relanding of c67e063843e4bd37522692d9b74586a2304575e5
reviewed at https://chromium-review.googlesource.com/834749 which
broke the Linux CFI builds.

Bug:  782025 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I24e9e3e6dc3312af2a94c4f30232da0f798ab541
Reviewed-on: https://chromium-review.googlesource.com/923565
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538274}
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/chrome/browser/extensions/DEPS
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/chrome/browser/extensions/chrome_content_verifier_delegate.cc
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/chrome/browser/extensions/chrome_extensions_browser_client.cc
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/chrome/browser/extensions/chrome_extensions_browser_client.h
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/chrome/browser/extensions/chrome_url_request_util.cc
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/chrome/browser/extensions/chrome_url_request_util.h
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/chrome/browser/extensions/extension_protocols_unittest.cc
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/chromecast/browser/extensions/cast_extensions_browser_client.cc
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/chromecast/browser/extensions/cast_extensions_browser_client.h
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/content/browser/file_url_loader_factory.cc
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/content/public/browser/file_url_loader.h
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/extensions/browser/extension_protocols.cc
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/extensions/browser/extension_protocols.h
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/extensions/browser/extensions_browser_client.h
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/extensions/browser/test_extensions_browser_client.cc
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/extensions/browser/test_extensions_browser_client.h
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/extensions/shell/browser/shell_extensions_browser_client.cc
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/extensions/shell/browser/shell_extensions_browser_client.h
[modify] https://crrev.com/8f8126680433a020fae54e416790e652e16380e8/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 10 by cmumford@chromium.org, Mar 10 2018

Status: Fixed (was: Started)
►

Sign in to add a comment