Issue metadata
Sign in to add a comment
|
crashpad_tests failing on chromium.win/Win7 Tests (dbg)(1) |
||||||||||||||||||||||
Issue descriptioncrashpad_tests failing on chromium.win/Win7 Tests (dbg)(1) Builders failed on: - Win7 Tests (dbg)(1): https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29 First failing build https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64492 Suspecting https://chromium-review.googlesource.com/c/chromium/src/+/751403
,
Nov 7 2017
,
Nov 7 2017
Bot cycled out to a different failure, so removing sheriff label.
,
Nov 7 2017
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/crashpad/crashpad.git/+/d3b7463c7a48e83180a2619d00614a175641fb4e commit d3b7463c7a48e83180a2619d00614a175641fb4e Author: Mark Mentovai <mark@chromium.org> Date: Tue Nov 07 17:42:18 2017 win: Recognize nsi.dll presenting as VFT_DRV/VFT2_DRV_NETWORK This was previously proposed at https://chromium-review.googlesource.com/c/crashpad/crashpad/+/339103/2/util/win/pe_image_reader_test.cc#84. It didn’t land because the change was abandoned for other reasons, but the fix was valid. nsi.dll is not VFT_APP or VFT_DLL, and if it’s loaded, crashpad_snapshot_test PEImageReader.VSFixedFileInfo_AllModules fails. Although I can’t reproduce nsi.dll being loaded spontaneously in local testing or on trybots, it occurred in the monolithic crashpad_tests at https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64492: [ RUN ] PEImageReader.VSFixedFileInfo_AllModules ../../third_party/crashpad/crashpad/snapshot/win/pe_image_reader_test.cc(90): error: Value of: observed.dwFileType == VFT_APP || observed.dwFileType == VFT_DLL Actual: false Expected: true Google Test trace: ../../third_party/crashpad/crashpad/snapshot/win/pe_image_reader_test.cc(164): C:\Windows\syswow64\NSI.dll [ FAILED ] PEImageReader.VSFixedFileInfo_AllModules (11 ms) I can also reproduce locally by calling LoadLibrary(L"nsi.dll"). Bug: chromium:779790 , chromium:782011 Test: crashpad_snapshot_test PEImageReader.VSFixedFileInfo_AllModules Change-Id: I361c7d6521645913277a441ce38779aaa4a182c2 Reviewed-on: https://chromium-review.googlesource.com/757077 Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> [modify] https://crrev.com/d3b7463c7a48e83180a2619d00614a175641fb4e/snapshot/win/pe_image_reader_test.cc
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1782adb1a98dc011a10049787696bd70671c1d06 commit 1782adb1a98dc011a10049787696bd70671c1d06 Author: Mark Mentovai <mark@chromium.org> Date: Wed Nov 08 05:11:27 2017 Build all Crashpad tests in Chromium, and run on Chromium bots Originally landed at efd8584f0232 (https://chromium-review.googlesource.com/751403) and subsequently reverted at 49f5374a36de because of test failures. There are no changes to this reland, but the test failures are addressed by updating Crashpad to include https://chromium.googlesource.com/crashpad/crashpad/+/d3b7463c7a48. Until the recent ef647b4938a6 and 00a065492978, Crashpad tests did not build or run in Chromium. Since then, crashpad_util_test was buildable in Chromium, but was only run on Windows bots. Crashpad has many more tests than crashpad_util_test, and its tests run on both macOS and Windows. This change allows all of Crashpad’s unit tests to build in Chromium’s GN-based build, and runs them on macOS and Windows try- and buildbots. Rather than having individual module-specific test executables like crashpad_util_test, all unit tests are brought together into one monolithic “crashpad_tests” executable. On Windows, Crashpad also has an “end_to_end_test.py” which drives crashpad_handler and some test crasher programs, and verifies the produced minidump output by running the cdb debugger. That’s not currently accounted for in the Chromium build. As part of this change, additional Crashpad tools are also added to the Chromium build, including the generate_dump tool. Bug: 779790 , 782011 Change-Id: Id192c40a1e7db178bdb093cd050b7fc5a5a876c9 Reviewed-on: https://chromium-review.googlesource.com/757188 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#514759} [modify] https://crrev.com/1782adb1a98dc011a10049787696bd70671c1d06/BUILD.gn [add] https://crrev.com/1782adb1a98dc011a10049787696bd70671c1d06/build/secondary/third_party/crashpad/crashpad/BUILD.gn [modify] https://crrev.com/1782adb1a98dc011a10049787696bd70671c1d06/build/secondary/third_party/crashpad/crashpad/client/BUILD.gn [modify] https://crrev.com/1782adb1a98dc011a10049787696bd70671c1d06/build/secondary/third_party/crashpad/crashpad/compat/BUILD.gn [modify] https://crrev.com/1782adb1a98dc011a10049787696bd70671c1d06/build/secondary/third_party/crashpad/crashpad/handler/BUILD.gn [modify] https://crrev.com/1782adb1a98dc011a10049787696bd70671c1d06/build/secondary/third_party/crashpad/crashpad/minidump/BUILD.gn [modify] https://crrev.com/1782adb1a98dc011a10049787696bd70671c1d06/build/secondary/third_party/crashpad/crashpad/snapshot/BUILD.gn [modify] https://crrev.com/1782adb1a98dc011a10049787696bd70671c1d06/build/secondary/third_party/crashpad/crashpad/test/BUILD.gn [modify] https://crrev.com/1782adb1a98dc011a10049787696bd70671c1d06/build/secondary/third_party/crashpad/crashpad/third_party/zlib/BUILD.gn [modify] https://crrev.com/1782adb1a98dc011a10049787696bd70671c1d06/build/secondary/third_party/crashpad/crashpad/tools/BUILD.gn [modify] https://crrev.com/1782adb1a98dc011a10049787696bd70671c1d06/build/secondary/third_party/crashpad/crashpad/util/BUILD.gn [modify] https://crrev.com/1782adb1a98dc011a10049787696bd70671c1d06/components/browser_watcher/BUILD.gn [modify] https://crrev.com/1782adb1a98dc011a10049787696bd70671c1d06/components/crash/content/app/BUILD.gn [modify] https://crrev.com/1782adb1a98dc011a10049787696bd70671c1d06/testing/buildbot/chromium.clang.json [modify] https://crrev.com/1782adb1a98dc011a10049787696bd70671c1d06/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/1782adb1a98dc011a10049787696bd70671c1d06/testing/buildbot/chromium.mac.json [modify] https://crrev.com/1782adb1a98dc011a10049787696bd70671c1d06/testing/buildbot/chromium.win.json [modify] https://crrev.com/1782adb1a98dc011a10049787696bd70671c1d06/testing/buildbot/gn_isolate_map.pyl
,
Nov 8 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 6 2017