New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 782008 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Device policy wallpaper is lost when rotating the device

Project Member Reported by wzang@chromium.org, Nov 6 2017

Issue description

Chrome Version: 64.0.3258.0
OS: Chrome

What steps will reproduce the problem?
Set a device wallpaper, and rotate the device at login screen.

What is the expected result?
The device policy wallpaper should not change.

What happens instead?
The device policy wallpaper is changed into the default wallpaper.

See video: (ignore the delay when rotating the device, that should be caused by 779311)
https://drive.google.com/a/google.com/file/d/1jEVSEOqHViT0Yooqn8RVEwPSP7DednCs/view?usp=sharing

 
Components: UI>Shell>Wallpaper

Comment 2 by wzang@chromium.org, Nov 8 2017

Owner: wzang@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37ebcfb0c42669055273c31dad7920ed11a258e1

commit 37ebcfb0c42669055273c31dad7920ed11a258e1
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Nov 08 20:09:32 2017

Prevent device wallpaper loss when rotating the device

This CL tried to fix the issue without changing anything else to avoid
regression. We could consider merging this to M63.

UpdateWallpaper() function will be refactored at a later time.

Bug:  782008 
Change-Id: I8f60c8e3dc833233c9b725c036475089f2810511
Reviewed-on: https://chromium-review.googlesource.com/756180
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514920}
[modify] https://crrev.com/37ebcfb0c42669055273c31dad7920ed11a258e1/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc

Comment 4 by wzang@chromium.org, Nov 8 2017

Labels: Merge-Request-63

Comment 5 by wzang@chromium.org, Nov 8 2017

Status: Fixed (was: Started)
Waiting for verification on tot before considering merge to M63
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 9 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by wzang@chromium.org, Nov 10 2017

Verified to work on ToT and latest Canary.

Comment 9 by wzang@chromium.org, Nov 13 2017

Cc: gkihumba@google.com
Labels: -Hotlist-Merge-Review -Merge-Review-63 Merge-Approved-63
Project Member

Comment 11 by sheriffbot@chromium.org, Nov 20 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by wzang@chromium.org, Nov 20 2017

Labels: -Merge-Approved-63

Sign in to add a comment