New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 782004 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Nov 2017
Cc:
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 740783



Sign in to add a comment

desktop-pwas: Pasting links in the omnibox sometimes results in a new app window

Project Member Reported by ortuno@chromium.org, Nov 6 2017 
What steps will reproduce the problem?
(1) Copy link from another tab
(2) Paste the link in another tab
(3) Press enter

What is the expected result?
Tab in which the link was pasted should navigate

What happens instead?
A new app window is opened.

This is happening because step (3) results in a LINK navigation rather than in a TYPED navigation. This causes us to think the user clicked a link in the page instead of typing a link in the omnibox.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f60f086a4cf5d1297fbbc0dcc8a3da9178288530

commit f60f086a4cf5d1297fbbc0dcc8a3da9178288530
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Thu Nov 30 04:53:26 2017

desktop-pwas: Don't intercept address bar and back/forward navigations

Pasting a link into the address bar and then navigating to it results in
a LINK navigation instead of a TYPED navigation. The transition
qualifier for the navigation will be FROM_ADDRESS_BAR so we use that to
distinguish it from regular link navigations.

Back/Forward navigations have the same type as the original navigation
e.g. if a navigation to "a.com" was a LINK navigation then navigating
back or forward to "a.com" again will be a LINK navigation as well.
This could cause us to incorrectly open an app window.

Bug:  789328 ,  782004 
Change-Id: I5b53211bfbe144fc596ae7a1ac542e771e3c4f2b
Reviewed-on: https://chromium-review.googlesource.com/795397
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520443}
[modify] https://crrev.com/f60f086a4cf5d1297fbbc0dcc8a3da9178288530/chrome/browser/extensions/bookmark_app_navigation_throttle.cc
[modify] https://crrev.com/f60f086a4cf5d1297fbbc0dcc8a3da9178288530/chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc

Comment 2 by ortuno@chromium.org, Nov 30 2017

Status: Fixed (was: Available)
►

Sign in to add a comment