Issue metadata
Sign in to add a comment
|
Ensure flatbuffer ruleset construction does not regress with r514268. |
||||||||||||||||||||
Issue descriptionMonitor SubresourceFilter.IndexRuleset.WallDuration SubresourceFilter.IndexRuleset.CPUDuration after https://chromium-review.googlesource.com/c/chromium/src/+/748962 is available on Canary and Dev.
,
Nov 15 2017
The NextAction date has arrived: 2017-11-15
,
Nov 30 2017
Charles: So I looked at the UMA stats, and it seems that this in fact does have some performance penalty. This landed in 64.0.3261.0. See https://uma.googleplex.com/p/chrome/timeline_v2/?sid=77e9be6b5b89e11eadaabb53ccf8145e. Let me know if your reading of the UMA is similar. It's weird how 64.0.3254.2 is also bad. Anyways, I do have a very simple fix in mind for sub-resource filter and will send a patch.
,
Nov 30 2017
Hm I wasn't seeing anything with this query: https://uma.googleplex.com/p/chrome/timeline_v2/?sid=1d9edb73a59946e562efeb28d734dc9a I'm not sure I understand why they are showing big differences.
,
Nov 30 2017
Weird, not sure how to interpret this as well.
,
Nov 30 2017
Do you mind quickly double checking that your first link was comparing apples to apples? Eg. platform / channel.
,
Nov 30 2017
Most of the versions don't show up, probably because of low data volume - https://uma.googleplex.com/p/chrome/timeline_v2/?sid=94946bb2ac5089a9d29f729a72fe462a.
,
Dec 1 2017
I think it's because you're looking at versions that weren't dev releases or weren't android releases.
,
Jan 23 2018
Closing this, as can be seen from c#4, the CL didn't cause a regression after all. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by csharrison@chromium.org
, Nov 6 2017