New issue
Advanced search Search tips

Issue 781991 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Improve ETW event emitting

Project Member Reported by brucedaw...@chromium.org, Nov 6 2017

Issue description

The Chrome ETW event emitting could be more useful if a few changes were made:

1) Automatically enabling without needing a command-line flag and a background thread, somehow
2) Improving the quality of the emitted strings - right now they often include explicit quotes and double backslashes which harms readability

 
Labels: OS-Windows

Comment 2 by dli...@microsoft.com, Jan 17 (5 days ago)

Cc: brucedaw...@chromium.org
Owner: dli...@microsoft.com
I'm going to take a look at this one. My current plan for cleaning up (1):
1. Remove ETW polling thread - instead pass our own EnableCallback to EventRegister. Invoke the default callback, then use this as a signal to update category flags
2. Remove flags and unconditionally enable etw tracing for chrome processes

After that, I'll look into the issue of the quotes and backslashes in the payload

Comment 3 by brucedaw...@chromium.org, Jan 17 (5 days ago)

Thanks for grabbing this. I'm not familiar with how the EnableCallback works (I didn't know about it) which is how we ended up with the polling thread. Having ETW tracing always available would be better.

Some customer configuration files to better display the data could also be very helpful.

Sign in to add a comment