New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781990 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Not currently working on Chromium
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Reword Device Chooser when no devices found

Project Member Reported by scheib@chromium.org, Nov 6 2017

Issue description

1. Search for devices, e.g. using 

Bluetooth:
https://googlechrome.github.io/samples/web-bluetooth/get-descriptors-async-await.html

USB:
https://webusb.github.io/arduino/demos/console/

2. None to be found
Bluetooth: wait for time out
USB: instantly


The message currently displayed:
 Bluetooth: "No Bluetooth devices found"
 USB: "No devices found"

...is lacking, because devices may well have been found.  However, they didn't match the constraints of the application requesting the device. 

In discussion with UI design srahim@chromium.org
and ddorwin who raised the topic.  It was decided that
"No compatible devices found" is a good replacement that
is both succinct and accurate. 
 
Images of before/after change:
android-bt-after.png
196 KB View Download
android-usb-after.png
67.2 KB View Download
android-usb-before.png
64.4 KB View Download
chromeos-bt-after.png
21.1 KB View Download
chromeos-bt-before.png
20.7 KB View Download
chromeos-usb-after.png
20.5 KB View Download
chromeos-usb-before.png
20.0 KB View Download
mac-bt-after.png
50.6 KB View Download
mac-usb-after.png
36.1 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb8364657de1941f9ea3c181d33deb0906d854a0

commit fb8364657de1941f9ea3c181d33deb0906d854a0
Author: Vincent Scheib <scheib@chromium.org>
Date: Tue Nov 07 19:22:19 2017

Clarify Bluetooth & USB Chooser message "No compatible devices found"

Changing text in the device chooser from the form
  "No devices found"
to
  "No compatible devices found"
to be more accurate and avoid user confusion.

The device chooser for Bluetooth and USB populates with
discovered devices that *also* match the constraints of
the application.  E.g. only devices from a certain manufacturer.

See screenshots showing the change on multiple platforms:
https://bugs.chromium.org/p/chromium/issues/detail?id=781990#c1

Bug:  781990 
Change-Id: Ieae4f9f77da0f41f132d46bb6eb0e3d0e42c0239
Reviewed-on: https://chromium-review.googlesource.com/755458
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514534}
[modify] https://crrev.com/fb8364657de1941f9ea3c181d33deb0906d854a0/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/fb8364657de1941f9ea3c181d33deb0906d854a0/chrome/app/generated_resources.grd

That is definitely better. Thanks Vincent!
Cc: sandeepkumars@chromium.org
Labels: TE-Verified-M64 TE-Verified-64.0.3262.0
Tested the issue using #64.0.3262.0 on Win 10, Mac 10.12.6 and Linux Ubuntu 14.04 as per the steps mentioned in comment #0. Observed "No compatible devices found" message on the pop up.

Please find the screencast. Hence adding Verified labels.

Note: Requesting Bluetooth Device... Argh! NotFoundError: Bluetooth adapter not available message in seen for Bluetooth in Linux.

Thanks!!
781990.mp4
2.5 MB View Download

Comment 5 by scheib@chromium.org, Nov 15 2017

Status: Fixed (was: Started)

Sign in to add a comment