New issue
Advanced search Search tips

Issue 781983 link

Starred by 1 user
Status: Duplicate
Merged: issue 746518
Owner:
sunn...@chromium.org
Closed: Nov 2017
Cc:
vmi...@chromium.org
piman@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Expensive uses of base::debug::SetCrashKeyValue in GPU process

Project Member Reported by wittman@chromium.org, Nov 6 2017 
Data from the UMA Sampling Profiler shows that execution of calls to base::debug::SetCrashKeyValue in the GPU process are taking a combined 92ms during startup, or 2.2% of non-idle execution. This is in canary release 64.0.3259.0 on 64 bit Chrome on Windows.

During steady state execution these calls are likely taking close to 3% of non-idle execution time.

Flame graph showing SetCrashKeyValue invocations in 64.0.3259.0: https://uma.googleplex.com/p/chrome/callstacks?sid=f0ca56f5fe9f13a69110a7964abbbe35

The calls were added in https://chromium.googlesource.com/chromium/src/+/93c2ec10160631b757a99db7eb12ffd94696e75f.

Comment 1 by sunn...@chromium.org, Nov 10 2017

Cc: vmi...@chromium.org piman@chromium.org
That CL only added the virtual context crash key which is a fraction of all calls to SetCrashKeyValue. Most calls are for setting the active URL which was already there.

Comment 2 by piman@chromium.org, Nov 10 2017

Mergedinto: 746518
Status: Duplicate (was: Assigned)

Comment 3 by wittman@chromium.org, Nov 10 2017 

Setting the active URL is also costly, but flame graph link above shows that almost half the SetCrashKeyValue runtime is associated with the virtual context crash key calls made directly from GpuCommandBufferStub::PerformWork() and GpuCommandBufferStub::OnMessageReceived().

Comment 4 by wittman@chromium.org, Jan 5 2018

Labels: Performance-Browser
Bulk adding Performance-Browser label for bugs identified with the UMA Sampling Profiler.
►

Sign in to add a comment