New issue
Advanced search Search tips

Issue 781981 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make opsCache gracefully degrade when memcache is down

Project Member Reported by vadimsh@chromium.org, Nov 6 2017

Issue description

https://chromium.googlesource.com/infra/luci/luci-go/+/master/scheduler/appengine/engine/utils.go#176

opsCache is used in schedule to "remember" that some heavyweight operations have been done.

It currently depends on memcache. If memcache is down opsCache.Do fails.

Instead it should just degrade to using local memory only. Redoing ops is OK, per opsCache contract.
 
Owner: tandrii@chromium.org
Status: Started (was: Untriaged)
https://chromium-review.googlesource.com/c/755951/
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/fa7ff3fe8653f13c781048768b9ce1795034d5d2

commit fa7ff3fe8653f13c781048768b9ce1795034d5d2
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Nov 06 23:02:14 2017

scheduler: opsCache should proceed if memcache is not available.

R=vadimsh@chromium.org

Bug:  781981 
Change-Id: I398a7fe194e6016dc0adf347dc174fb9d027ed61
Reviewed-on: https://chromium-review.googlesource.com/755951
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/fa7ff3fe8653f13c781048768b9ce1795034d5d2/scheduler/appengine/engine/utils.go

Status: Fixed (was: Started)
Deployed.

Sign in to add a comment