New issue
Advanced search Search tips

Issue 781975 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Clean up use of components/variations from unittests

Project Member Reported by dougarnett@chromium.org, Nov 6 2017

Issue description

Idea: we can drop the +components/variations dependency in components/previews/{core,content} (ie, remove uses of  variations::testing::ClearAllVariationParams()) if we can migrate unittests to ScopedFeatureList instead.


Motivating observation from review of change 752424:
-----------------------------------------------------
Steven Holte
12:00 PM
▼
Consider migrating trials to FeatureApi and using ScopedFeatureList?

Doug Arnett
1:25 PM
▼
Good idea, I will discuss that with Ryan

Ryan Sturm
1:32 PM
▼
The new features we add, we add as Feature API. We've avoided migration because we didn't want more config files for different versions.

Steven Holte
1:39 PM
▼
You shouldn't need to have seperate configs.  You should be able to just add the enable/disable features block to your groups, and the same config will work with both versions of code (as long you keep group names that work).  But up to you based on how long you expect to continue running the trials.
 

Comment 1 by bengr@chromium.org, Dec 1 2017

Status: Available (was: Untriaged)

Comment 2 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 3 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
Refreshed during triage.

Comment 5 by bengr@chromium.org, Mar 21 2018

Refreshed during triage.

Comment 6 by bengr@chromium.org, Jun 22 2018

Status: WontFix (was: Available)

Sign in to add a comment