New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781963 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 736416



Sign in to add a comment

DiskCache.?.TotalIOTime Has Bad Construction Arguments

Project Member Reported by bcwh...@chromium.org, Nov 6 2017

Issue description

Chrome Version: HEAD
OS: ALL

https://uma.googleplex.com/p/chrome/histograms/?endDate=latest&dayCount=28&histograms=DiskCache.0.TotalIOTime%2CHistogram.BadConstructionArguments&fixupData=true&showMax=true&filters=channel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial

The DiskCache.?.TotalIOTime histogram is being constructed with bad parameters.  It's being created here:
https://cs.chromium.org/chromium/src/net/disk_cache/blockfile/in_flight_backend_io.cc?rcl=831ab73d348a57b29bb9faf67b4e3e40f43aabb8&l=74

This has a minimum value of zero but histograms need to have a specified minimum value of one.  Zero is always allowed and is an implied bucket.  This will crash if it happens with DCHECKs enabled.

The comment here is incorrect:
https://cs.chromium.org/chromium/src/net/disk_cache/blockfile/histogram_macros.h?rcl=831ab73d348a57b29bb9faf67b4e3e40f43aabb8&l=84

 
Blocking: 736416
Cc: -gavinp@chromium.org rvargas@chromium.org
Labels: -Pri-3 Pri-2
Owner: gavinp@chromium.org
cc: rvargas (gone >30 days)

Some Canary builds now run with DCHECKs enabled.

Sign in to add a comment