DiskCache.?.TotalIOTime Has Bad Construction Arguments |
||
Issue descriptionChrome Version: HEAD OS: ALL https://uma.googleplex.com/p/chrome/histograms/?endDate=latest&dayCount=28&histograms=DiskCache.0.TotalIOTime%2CHistogram.BadConstructionArguments&fixupData=true&showMax=true&filters=channel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial The DiskCache.?.TotalIOTime histogram is being constructed with bad parameters. It's being created here: https://cs.chromium.org/chromium/src/net/disk_cache/blockfile/in_flight_backend_io.cc?rcl=831ab73d348a57b29bb9faf67b4e3e40f43aabb8&l=74 This has a minimum value of zero but histograms need to have a specified minimum value of one. Zero is always allowed and is an implied bucket. This will crash if it happens with DCHECKs enabled. The comment here is incorrect: https://cs.chromium.org/chromium/src/net/disk_cache/blockfile/histogram_macros.h?rcl=831ab73d348a57b29bb9faf67b4e3e40f43aabb8&l=84
,
Jun 29 2018
cc: rvargas (gone >30 days) Some Canary builds now run with DCHECKs enabled. |
||
►
Sign in to add a comment |
||
Comment 1 by bcwh...@chromium.org
, Nov 6 2017