Chrome Version: HEAD OS: ALL https://uma.googleplex.com/p/chrome/histograms/?endDate=latest&dayCount=28&histograms=Histogram.BadConstructionArguments%2CPasswordManager.Android.PasswordExceptionEntry.Website&fixupData=true&showMax=true&filters=channel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial The PasswordManager.Android.PasswordExceptionEntry.Website histogram is being constructed with bad parameters. It's being created here: https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java?rcl=fbefdb0bac773bb088f7145e24c6e582e7415aad&l=365 The problem is that the cut-off value (WEBSITE_ACTION_BOUNDARY) is 1 (one) which is too small. Histograms have to have at least 2 (two) buckets so WEBSITE_ACTION_BOUNDARY needs to be incremented even if that leaves a bucket that is never used.
There are two more of the same: PasswordManager.Android.PasswordCredentialEntry.Website https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java?rcl=350a8e0f8ab9bf3e17555c395854fa4d8d43f0d6&l=370 PasswordManager.Android.PasswordCredentialEntry.Username https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java?rcl=350a8e0f8ab9bf3e17555c395854fa4d8d43f0d6&l=342 https://uma.googleplex.com/p/chrome/histograms/?endDate=latest&dayCount=28&histograms=Histogram.BadConstructionArguments%2CPasswordManager.Android.PasswordCredentialEntry.Username%2CPasswordManager.Android.PasswordCredentialEntry.Website%2CPasswordManager.Android.PasswordExceptionEntry.Website&fixupData=true&showMax=true&filters=channel%2Ceq%2C1%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d70fae6a69ec5a72afad720384edcbac00fe70f commit 4d70fae6a69ec5a72afad720384edcbac00fe70f Author: jdoerrie <jdoerrie@chromium.org> Date: Wed Nov 15 10:27:56 2017 Fix PasswordManager.Android Histograms This change increments the boundary for two single value histograms to be at least 2. This results in Histogram.BadConstructionArguments otherwise. Bug: 781959 Change-Id: I3a92dfe83e2356af80abe1b1ea0dff65a964b573 Reviewed-on: https://chromium-review.googlesource.com/768814 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#516657} [modify] https://crrev.com/4d70fae6a69ec5a72afad720384edcbac00fe70f/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
Comment 1 by bcwh...@chromium.org
, Nov 6 2017