New issue
Advanced search Search tips

Issue 781947 link

Starred by 1 user
Status: Fixed
Owner:
tbansal@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Compute effective connection type when more than a certain number of observations are received

Project Member Reported by tbansal@chromium.org, Nov 6 2017 
Currently, effective connection  type is recomputed every N seconds as long as there is ongoing network traffic. Additionally, we should recompute ECT if more than a certain number of network quality observations have been taken. This would make network quality estimator (NQE) more response when there are enough observations.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98f392b717359bb8ba0ebf5c1662b73a82861ecd

commit 98f392b717359bb8ba0ebf5c1662b73a82861ecd
Author: Tarun Bansal <tbansal@chromium.org>
Date: Tue Nov 07 19:56:03 2017

Compute ECT when more than a certain number of observations are received

Modify observation buffer to take tick clock in the constructor which makes
it simpler to write tests.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Bug:  781947 
Change-Id: I80c40f8911e216cb47cf01af340b88cec67d7569
Reviewed-on: https://chromium-review.googlesource.com/753649
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514552}
[modify] https://crrev.com/98f392b717359bb8ba0ebf5c1662b73a82861ecd/net/nqe/network_quality_estimator.cc
[modify] https://crrev.com/98f392b717359bb8ba0ebf5c1662b73a82861ecd/net/nqe/network_quality_estimator.h
[modify] https://crrev.com/98f392b717359bb8ba0ebf5c1662b73a82861ecd/net/nqe/network_quality_estimator_params.cc
[modify] https://crrev.com/98f392b717359bb8ba0ebf5c1662b73a82861ecd/net/nqe/network_quality_estimator_params.h
[modify] https://crrev.com/98f392b717359bb8ba0ebf5c1662b73a82861ecd/net/nqe/network_quality_estimator_test_util.cc
[modify] https://crrev.com/98f392b717359bb8ba0ebf5c1662b73a82861ecd/net/nqe/network_quality_estimator_test_util.h
[modify] https://crrev.com/98f392b717359bb8ba0ebf5c1662b73a82861ecd/net/nqe/network_quality_estimator_unittest.cc
[modify] https://crrev.com/98f392b717359bb8ba0ebf5c1662b73a82861ecd/net/nqe/observation_buffer.cc
[modify] https://crrev.com/98f392b717359bb8ba0ebf5c1662b73a82861ecd/net/nqe/observation_buffer.h
[modify] https://crrev.com/98f392b717359bb8ba0ebf5c1662b73a82861ecd/net/nqe/observation_buffer_unittest.cc
[modify] https://crrev.com/98f392b717359bb8ba0ebf5c1662b73a82861ecd/net/nqe/throughput_analyzer.cc

Comment 2 by tbansal@chromium.org, Nov 7 2017

Status: Fixed (was: Started)
►

Sign in to add a comment