ds_cache settings to turn off memcache requires memcache to work |
|||||
Issue descriptionRepro, go to any app settings, eg: https://luci-milo.appspot.com/admin/settings/gae if memcache isn't working, turning off dscache results in: API error 9 (memcache: ): Memcache is temporarily unavailable.
,
Nov 9 2017
,
Nov 15 2017
,
Nov 15 2017
I'll take a look.
,
Dec 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/2de768bc6b972cea62fc5691d05c5957844f7112 commit 2de768bc6b972cea62fc5691d05c5957844f7112 Author: Vadim Shtayura <vadimsh@chromium.org> Date: Fri Dec 01 00:53:49 2017 [gaemiddleware] Add a setting that purposefully breaks memcache. Useful to test how apps survive memcache outages (which occasionally happen). R=iannucci@chromium.org, nodir@chromium.org BUG= 781945 , 781978 Change-Id: I78964892fc44a00efc028b4e0042f0fe19b46a30 Reviewed-on: https://chromium-review.googlesource.com/801984 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> [modify] https://crrev.com/2de768bc6b972cea62fc5691d05c5957844f7112/appengine/gaemiddleware/context.go [modify] https://crrev.com/2de768bc6b972cea62fc5691d05c5957844f7112/appengine/gaemiddleware/settings.go
,
Dec 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/948d792b824bc1d8aa9c06f240fc8b9baa6df463 commit 948d792b824bc1d8aa9c06f240fc8b9baa6df463 Author: Vadim Shtayura <vadimsh@chromium.org> Date: Fri Dec 01 20:07:09 2017 [gae] Use AddShardFunctions instead of $dscache.enable. It works more "reliably". $dscache.enable essentially works only for Puts and some Gets outside transactions. AddShardFunctions works always. In particular, this fixes https://crbug.com/781945 R=iannucci@chromium.org, nodir@chromium.org BUG= 781945 Change-Id: If735918601122f8a827beede12c2a55bd8311bb4 Reviewed-on: https://chromium-review.googlesource.com/801985 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> [modify] https://crrev.com/948d792b824bc1d8aa9c06f240fc8b9baa6df463/appengine/gaemiddleware/settings.go [modify] https://crrev.com/948d792b824bc1d8aa9c06f240fc8b9baa6df463/appengine/gaesettings/gaesettings.go [modify] https://crrev.com/948d792b824bc1d8aa9c06f240fc8b9baa6df463/appengine/tsmon/tasknum.go
,
Dec 1 2017
This also fixes dependency of tsmon on memcache. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jpar...@google.com
, Nov 9 2017