Remove the PersonalDataManager context getter from IOS |
||||
Issue descriptionFor getting the regional data, instead of using PersonalDataManager's URL request context getter, get the URL request context getter from the ApplicationContext. We can then remove the context getter from PersonalDataManager. It's used in this file: https://codesearch.chromium.org/chromium/src/ios/chrome/browser/payments/payment_request.mm I think personal_data_manager_->GetURLRequestContextGetter can be replace by https://codesearch.chromium.org/chromium/src/ios/chrome/browser/application_context.h?type=cs&q=ApplicationContext+ios&sq=package:chromium&l=89
,
Nov 6 2017
,
Nov 27 2017
,
Nov 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d00e383369c12a92975df561bdcc46314fcd42b commit 3d00e383369c12a92975df561bdcc46314fcd42b Author: Mohamad Ahmadi <mahmadi@chromium.org> Date: Tue Nov 28 20:51:33 2017 [PR] Removes GetURLRequestContextGetter from autofill::PersonalDataManager Replaces usages of PersonalDataManager::GetURLRequestContextGetter() with ApplicationContext::GetSystemURLRequestContext() Bug: 781942 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7e42baf9ce61d722410c1f49ee33a55c5e53485a Reviewed-on: https://chromium-review.googlesource.com/793850 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#519825} [modify] https://crrev.com/3d00e383369c12a92975df561bdcc46314fcd42b/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/3d00e383369c12a92975df561bdcc46314fcd42b/components/autofill/core/browser/personal_data_manager.h [modify] https://crrev.com/3d00e383369c12a92975df561bdcc46314fcd42b/ios/chrome/browser/payments/payment_request.mm
,
Nov 28 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by edchin@chromium.org
, Nov 6 2017Owner: parastoog@chromium.org
Status: Assigned (was: Untriaged)