New issue
Advanced search Search tips

Issue 781937 link

Starred by 1 user
Status: Fixed
Owner:
wuandy@chromium.org
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Phone number truncated wrongly on target.com(and some others)

Project Member Reported by wuandy@chromium.org, Nov 6 2017 
Go to target.com, in checkout page the phone number is truncated wrongly if the profile has a number with country code saved. 

Profile: 15141231234
Filled: 1514123123
expected: 5141231234

This is due to the site use autocomplete=tel but expecting no country code.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c048c7babec6b41112c1ea694e19b0c945b00662

commit c048c7babec6b41112c1ea694e19b0c945b00662
Author: Hui(Andy) Wu <wuandy@chromium.org>
Date: Wed Nov 08 16:39:37 2017

[Autofill] Override html prediction for autocomplete=tel if server
thinks no country-code is expected.

Right now if a field has autocomplete=tel set, autofill ignore server
predictions and mark the field PHONE_HOME_WHOLE_NUMBER. This is causing
phone number filling issues on some web sites where they actually do not
expect a country code. Server predict this case better, so we will 
override html prediction.

Bug:  781937 
Change-Id: Iac9f48cad5608ec600c5880e787b90557d3ed461
Reviewed-on: https://chromium-review.googlesource.com/755853
Commit-Queue: Hui Wu <wuandy@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514854}
[modify] https://crrev.com/c048c7babec6b41112c1ea694e19b0c945b00662/components/autofill/core/browser/autofill_field.cc
[modify] https://crrev.com/c048c7babec6b41112c1ea694e19b0c945b00662/components/autofill/core/browser/fill_util_unittest.cc

Comment 2 by wuandy@chromium.org, Nov 20 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment