New issue
Advanced search Search tips

Issue 781919 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove large files from /usr/share/cups/ipptool

Project Member Reported by ahass...@chromium.org, Nov 6 2017

Issue description

There are a few files in /usr/share/cups/ipptools that are quite large like:

-rw-r--r-- 1 root root 1048875 Nov  6 11:35 document-a4.pdf
-rw-r--r-- 1 root root 1088024 Nov  6 11:35 document-a4.ps
-rw-r--r-- 1 root root 1411293 Nov  6 11:35 document-letter.pdf
-rw-r--r-- 1 root root 1466776 Nov  6 11:35 document-letter.ps

Is cups directly dependent on these files? Are they like example files? I cannot even open the pdf files since their format is not really pdf. They totally consume about 6MB on rootfs. Is there anyway we can remove them?
 

Comment 1 by skau@chromium.org, Nov 6 2017

Are these in the production image?  We shouldn't need anything from ipptools to run CUPS.
Yes, they were in a veyron_minnie base image I build.

Comment 3 by skau@chromium.org, Nov 7 2017

Status: Available (was: Untriaged)
Thanks.  We'll look into it.

Note for implementer, we should be able to exclude these files during the install.

Comment 4 by skau@chromium.org, Apr 5 2018

Labels: M-68

Comment 5 by skau@chromium.org, Apr 5 2018

Owner: valleau@chromium.org

Comment 6 by skau@chromium.org, Apr 5 2018

Status: Assigned (was: Available)
Labels: -M-68
I did a little bit of digging and it seems that a few of the "tests" in ipptool make use of these documents.

What do we use ipptool for on the system? If we don't use these tests then removing the documents should be fine.

Comment 9 by skau@chromium.org, Jun 19 2018

Release images don't need ipptool. ipptool is used to test IPP servers. It
can be pulled completely from our images.
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3df7a60fa02a3f6dcd74de7def37727d3ca38b4c

commit 3df7a60fa02a3f6dcd74de7def37727d3ca38b4c
Author: David Valleau <valleau@chromium.org>
Date: Fri Jun 22 02:56:22 2018

Patching CUPS to not include test directory

This change should free up some space on rootfs that was being taken up
by unused test files.

BUG= chromium:781919 
TEST=Manually tested by emerging and deploying to device

Change-Id: Ib195dfba2127eda8ecb913efd43551472c383d24
Reviewed-on: https://chromium-review.googlesource.com/1110480
Commit-Ready: David Valleau <valleau@chromium.org>
Tested-by: David Valleau <valleau@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/3df7a60fa02a3f6dcd74de7def37727d3ca38b4c/net-print/cups/files/cups-2.2.2-no-tests.patch
[modify] https://crrev.com/3df7a60fa02a3f6dcd74de7def37727d3ca38b4c/net-print/cups/cups-2.1.4.ebuild
[rename] https://crrev.com/3df7a60fa02a3f6dcd74de7def37727d3ca38b4c/net-print/cups/cups-2.1.4-r48.ebuild

Status: Fixed (was: Assigned)
Ended up just removing the entire test directory from the build since we don't use any of the test programs, and the ebuild explicitly "RESTRICTS" the use of these tests since they are not a conventional pass/fail unit test but rather an interactive test program.

Sign in to add a comment