master-release doesn't wait for any slaves |
|||
Issue descriptionSee e.g. https://luci-milo.appspot.com/buildbot/chromeos/master-release/3668 This causes go/som to get confused, because it assumes that all slaves of that build failed and emits tickets for them. There have been some recent changes by nxia@ and jkop@ to the master-waiting logic, I suspect one of them introduced this behavior change. P1 because it makes go/som useless for digging into canary problems.
,
Nov 6 2017
checking
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/54215b52baed808eda44ccea45dd3964a8ae3b9e commit 54215b52baed808eda44ccea45dd3964a8ae3b9e Author: Ningning Xia <nxia@chromium.org> Date: Tue Nov 07 14:00:17 2017 completion_stages: master-release should wait for slaves to complete. master builds without external_manager should also wait for all slaves to complete. BUG= chromium:781909 TEST=unit_tests Change-Id: I8f7325949426d002103297d94c38c5fecb8de663 Reviewed-on: https://chromium-review.googlesource.com/756276 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/54215b52baed808eda44ccea45dd3964a8ae3b9e/cbuildbot/stages/completion_stages_unittest.py [modify] https://crrev.com/54215b52baed808eda44ccea45dd3964a8ae3b9e/cbuildbot/stages/completion_stages.py
,
Nov 13 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by akes...@chromium.org
, Nov 6 2017Status: Assigned (was: Untriaged)