New issue
Advanced search Search tips

Issue 781905 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

cros tryjob needs to support --chrome_version

Project Member Reported by steve...@chromium.org, Nov 6 2017

Issue description

'cbuildbot --chrome_version' was super useful for bisecting apparent chrome regressions, especially for HWTest failures which can be very difficult to reproduce.

 
Also, personally I would like to skip the "No patches were provided; are you sure you want to just run a build of master? (yes/No)?" query in this case. (Avoidable with --yes, but then I worry about what else I might be answering 'yes' to...)

Do you also need --chrome_rev? I have no idea what it means, but it seems related.
I've never used it. The docs say:

Revision of Chrome to use, of type [tot|latest_release|stable_release|local|spec]

That doesn't seem particularly helpful; if I want to test with a different chrome I will always be able to (and probably want to) specify a specific git revision id.

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f7544a7a90d4f194583540ea1d363d9bdffcaff7

commit f7544a7a90d4f194583540ea1d363d9bdffcaff7
Author: Don Garrett <dgarrett@google.com>
Date: Tue Nov 07 23:25:20 2017

cros_tryjob: Add --chrome_version passthrough option.

--chrome-version is used by Gardeners, so put it back.

BUG= chromium:781905 
TEST=run_tests

Change-Id: I14fdc4b4eeca8eb04fe3d51793b419bb16789c26
Reviewed-on: https://chromium-review.googlesource.com/755841
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/f7544a7a90d4f194583540ea1d363d9bdffcaff7/cli/cros/cros_tryjob_unittest.py
[modify] https://crrev.com/f7544a7a90d4f194583540ea1d363d9bdffcaff7/cli/cros/cros_tryjob.py

Status: Fixed (was: Started)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 8 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment