New issue
Advanced search Search tips

Issue 781892 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocked on:
issue 780859
issue 782860

Blocking:
issue 801275



Sign in to add a comment

Add NoScript specific UMA

Project Member Reported by dougarnett@chromium.org, Nov 6 2017

Issue description

Includes:
 -
 PageLoad.Clients.Previews.NoScript.PaintTiming.NavigationToFirstContentfulPaint
 - PageLoad.Clients.NoScript.Experimental.Bytes.Network

Plus confirming these variants:
 - Previews.OptOut.UserOptedOut.NoScript
 - Previews.InfoBarAction.NoScript
 
Blockedon: 780859
Blocking: 776847
Blockedon: 782860
Cc: ryansturm@chromium.org
Note: for *PaintTiming* there are two observers currently for ClientLoFi of OfflinePage client-side previews: 

chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc

so need to decide whether to add to one of these.

And for *Experimental.Bytes.Network for ClientLoFi, there is 
chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_observer.cc
(that doesn't handle PaintTiming).

Should we just add noscript_page_load_metrics_observer to handle both PaintTiming and Experimental.Bytes.External?


Project Member

Comment 5 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb0049744f868042dc3ceaf1edfdb3b8c73271a1

commit bb0049744f868042dc3ceaf1edfdb3b8c73271a1
Author: Doug Arnett <dougarnett@chromium.org>
Date: Mon Nov 27 17:54:11 2017

Adds timing and data UMA variants for NoScript previews

Bug:  781892 
Change-Id: I915dc2beb47a5f879eab955ad8d4377e8c0747ea
Reviewed-on: https://chromium-review.googlesource.com/772812
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519334}
[modify] https://crrev.com/bb0049744f868042dc3ceaf1edfdb3b8c73271a1/chrome/browser/BUILD.gn
[add] https://crrev.com/bb0049744f868042dc3ceaf1edfdb3b8c73271a1/chrome/browser/page_load_metrics/observers/noscript_preview_page_load_metrics_observer.cc
[add] https://crrev.com/bb0049744f868042dc3ceaf1edfdb3b8c73271a1/chrome/browser/page_load_metrics/observers/noscript_preview_page_load_metrics_observer.h
[add] https://crrev.com/bb0049744f868042dc3ceaf1edfdb3b8c73271a1/chrome/browser/page_load_metrics/observers/noscript_preview_page_load_metrics_observer_unittest.cc
[rename] https://crrev.com/bb0049744f868042dc3ceaf1edfdb3b8c73271a1/chrome/browser/page_load_metrics/observers/offline_page_previews_page_load_metrics_observer.cc
[rename] https://crrev.com/bb0049744f868042dc3ceaf1edfdb3b8c73271a1/chrome/browser/page_load_metrics/observers/offline_page_previews_page_load_metrics_observer.h
[rename] https://crrev.com/bb0049744f868042dc3ceaf1edfdb3b8c73271a1/chrome/browser/page_load_metrics/observers/offline_page_previews_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/bb0049744f868042dc3ceaf1edfdb3b8c73271a1/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
[modify] https://crrev.com/bb0049744f868042dc3ceaf1edfdb3b8c73271a1/chrome/test/BUILD.gn
[modify] https://crrev.com/bb0049744f868042dc3ceaf1edfdb3b8c73271a1/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Comment 7 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 8 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
Blocking: -776847 801275
Labels: -Restrict-View-Google OS-iOS

Sign in to add a comment