New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 781890 link

Starred by 2 users
Status: Assigned
Owner:
pmonette@chromium.org
Cc:
█ dgn@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 661629



Sign in to add a comment

3p redirect UI: Add metrics / instrumentation for close action

Project Member Reported by csharrison@chromium.org, Nov 6 2017 
There is some existing instrumentation to get a callback when the "proceed" link is tapped, but it would be nice to run the callback with an enum kUserAction which includes closing the infobar with the x button.

The link clicked instrumentation is called via FramebustBlockMessageDelegate::OnLinkClicked, but it looks like we'd need to augment that with a close method if we want the callback to be shared.

Note, this will be used to log action metrics for the tab-under blocking experiment (linked).

Comment 1 by csharrison@chromium.org, Nov 6 2017 

dgn: Would you be willing to implement this? If not, I can do it (with any implementation advice you have to offer).

Comment 2 by dgn@chromium.org, Nov 7 2017

Cc: -dgn@chromium.org
Labels: OS-Android
Owner: dgn@chromium.org
Status: Started (was: Available)
Sure! Do you have a deadline? Is this needed for M64? is Branch ok?

Comment 3 by csharrison@chromium.org, Nov 7 2017 

Thanks! I would consider this "nice to have" for M64 branch, but not critical. In general we want some proxy for "user really noticed that we applied the intervention and did not proceed."

Possibly, additional metrics like "expanded the infobar to see the blocked URL" would be useful, if it is simple  to do.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996

commit 0330875f5b9a2b2fe46b1ec2c06050cb21aa7996
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Tue Nov 21 18:58:45 2017

👮 Unify intervention infobar callback paths

Simplifies the code path for the Framebust block infobar that was
trying to share code with the desktop intrvention UI but ended up
being unused. Makes the implementation closer to the one for the
Near-OOM intervention.
Most importantly, exposes Accept and DeclineIntervention methods
for the Framebust Block intervention, that now enables callers
to react when the intervention is accepted.

Bug: 781890
Change-Id: I845f76bdbddf85f49c8e0fe8548a2e78d2e213b3
Reviewed-on: https://chromium-review.googlesource.com/779521
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518319}
[modify] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/android/java/src/org/chromium/chrome/browser/infobar/FramebustBlockInfoBar.java
[modify] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java
[delete] https://crrev.com/2c85cdb93d7f91cfed1c0dd4ee9cc59c491a898a/chrome/android/java/src/org/chromium/chrome/browser/interventions/FramebustBlockMessageDelegate.java
[delete] https://crrev.com/2c85cdb93d7f91cfed1c0dd4ee9cc59c491a898a/chrome/android/java/src/org/chromium/chrome/browser/interventions/FramebustBlockMessageDelegateBridge.java
[modify] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/android/java_sources.gni
[modify] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarAppearanceTest.java
[modify] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/app/chromium_strings.grd
[modify] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/browser/BUILD.gn
[modify] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/browser/android/oom_intervention/oom_intervention_tab_helper.cc
[modify] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/browser/android/oom_intervention/oom_intervention_tab_helper.h
[modify] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/browser/ui/android/infobars/framebust_block_infobar.cc
[modify] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/browser/ui/android/infobars/framebust_block_infobar.h
[modify] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/browser/ui/android/infobars/near_oom_infobar.cc
[modify] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/browser/ui/android/infobars/near_oom_infobar.h
[modify] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/browser/ui/interventions/framebust_block_message_delegate.cc
[modify] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/browser/ui/interventions/framebust_block_message_delegate.h
[add] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/browser/ui/interventions/intervention_delegate.h
[add] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/browser/ui/interventions/intervention_infobar_delegate.cc
[add] https://crrev.com/0330875f5b9a2b2fe46b1ec2c06050cb21aa7996/chrome/browser/ui/interventions/intervention_infobar_delegate.h
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1645eab3d4f48705c91fb611f1ca6318c5aa345

commit c1645eab3d4f48705c91fb611f1ca6318c5aa345
Author: Nicolas Dossou-gbete <dgn@chromium.org>
Date: Thu Nov 23 10:11:33 2017

👮 Record UMA when tab-under intervention is accepted

FramebustBlockMessageDelegate now accepts a callback surfacing
what action the user took regarding the intervention.

This CL also used that new callback to record if the user accepted
the intervention blocking tab under. We previously already recorded
when the user declined the intervention, this will allow getting
a better picture of the performance of this intervention.

Bug: 781890
Change-Id: I7c783fd3bfdcce26828cc059f53b9de63e5338fe
Reviewed-on: https://chromium-review.googlesource.com/785150
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518881}
[modify] https://crrev.com/c1645eab3d4f48705c91fb611f1ca6318c5aa345/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify] https://crrev.com/c1645eab3d4f48705c91fb611f1ca6318c5aa345/chrome/browser/ui/blocked_content/tab_under_navigation_throttle.cc
[modify] https://crrev.com/c1645eab3d4f48705c91fb611f1ca6318c5aa345/chrome/browser/ui/blocked_content/tab_under_navigation_throttle.h
[modify] https://crrev.com/c1645eab3d4f48705c91fb611f1ca6318c5aa345/chrome/browser/ui/interventions/framebust_block_message_delegate.cc
[modify] https://crrev.com/c1645eab3d4f48705c91fb611f1ca6318c5aa345/chrome/browser/ui/interventions/framebust_block_message_delegate.h
[modify] https://crrev.com/c1645eab3d4f48705c91fb611f1ca6318c5aa345/tools/metrics/histograms/enums.xml

Comment 6 by dgn@chromium.org, Nov 23 2017

Cc: -pmonette@chromium.org dgn@chromium.org
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Owner: pmonette@chromium.org
Status: Assigned (was: Started)
Android done. Over to pmonette@ for Desktop implementation. Feel free to close if it's not needed.

Comment 7 by csharrison@chromium.org, Dec 6 2017 

 Issue 780485  has been merged into this issue.
►

Sign in to add a comment