Need to reflect estimated data savings of NoScript to user.
dougarnett, is this a P1? Any progress?
Setting to P2 - only an issue for launching NoScript
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0959654cbb076677793da8081738098ac1c97d53 commit 0959654cbb076677793da8081738098ac1c97d53 Author: Doug Arnett <dougarnett@chromium.org> Date: Thu Dec 14 23:40:36 2017 Adds new observer method to DRPDataUseObserver for DidFinishLoad This is plumbing preparation for estimating data savings for the NoScript preview (determined when page load finished event occurs). Bug: 781885 Change-Id: I145b9d270327c757ea1fbfbc44aa5932822c592e Reviewed-on: https://chromium-review.googlesource.com/820891 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#524231} [modify] https://crrev.com/0959654cbb076677793da8081738098ac1c97d53/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc [modify] https://crrev.com/0959654cbb076677793da8081738098ac1c97d53/chrome/browser/data_use_measurement/chrome_data_use_ascriber.h [modify] https://crrev.com/0959654cbb076677793da8081738098ac1c97d53/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc [modify] https://crrev.com/0959654cbb076677793da8081738098ac1c97d53/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.h [modify] https://crrev.com/0959654cbb076677793da8081738098ac1c97d53/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc [modify] https://crrev.com/0959654cbb076677793da8081738098ac1c97d53/chrome/browser/data_use_measurement/data_use_web_contents_observer.cc [modify] https://crrev.com/0959654cbb076677793da8081738098ac1c97d53/chrome/browser/data_use_measurement/data_use_web_contents_observer.h [modify] https://crrev.com/0959654cbb076677793da8081738098ac1c97d53/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer.cc [modify] https://crrev.com/0959654cbb076677793da8081738098ac1c97d53/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer.h [modify] https://crrev.com/0959654cbb076677793da8081738098ac1c97d53/components/data_use_measurement/core/data_use_ascriber.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/818b1378d1974d65a4dd24f2e9f43711afdffe93 commit 818b1378d1974d65a4dd24f2e9f43711afdffe93 Author: Doug Arnett <dougarnett@chromium.org> Date: Fri Dec 22 17:25:39 2017 Estimates data savings for NoScript preview This add two Feature params for calculating an inflation value to apply for a loaded page with NoScript previews active. It uses the DataReductionProxyDataUseObserver to report the estimated extra original bytes (first capturing the committed PreviewsType during the main frame load and then making the calc at DidFinishLoad time based on the total network bytes). Bug: 781885 Change-Id: I0618fd2d8801364f72ba52178aeb57df7d4a098b Reviewed-on: https://chromium-review.googlesource.com/834807 Commit-Queue: Doug Arnett <dougarnett@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#526014} [modify] https://crrev.com/818b1378d1974d65a4dd24f2e9f43711afdffe93/components/data_reduction_proxy/core/browser/BUILD.gn [modify] https://crrev.com/818b1378d1974d65a4dd24f2e9f43711afdffe93/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer.cc [modify] https://crrev.com/818b1378d1974d65a4dd24f2e9f43711afdffe93/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer.h [add] https://crrev.com/818b1378d1974d65a4dd24f2e9f43711afdffe93/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer_unittest.cc [modify] https://crrev.com/818b1378d1974d65a4dd24f2e9f43711afdffe93/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h [modify] https://crrev.com/818b1378d1974d65a4dd24f2e9f43711afdffe93/components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h [modify] https://crrev.com/818b1378d1974d65a4dd24f2e9f43711afdffe93/components/previews/core/previews_experiments.cc [modify] https://crrev.com/818b1378d1974d65a4dd24f2e9f43711afdffe93/components/previews/core/previews_experiments.h
Ok, some estimated savings now reported. Follow-on would be to pass per host estimate factors as Cacao metadata
Comment 1 by dougarnett@chromium.org
, Nov 6 2017