New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781875 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 660942



Sign in to add a comment

MCVD doesn't get an overlay in fs

Project Member Reported by liber...@chromium.org, Nov 6 2017

Issue description

if i set is_required, then it does get overlays.  the chooser is choosing to use surface texture for some reason.
 
the surface chooser is being given false for "is compositor promotable".  i probably just need to plumb through promotion hints.  codec images already have a callback to forward hints with.  just need to request them from the compositor, actually forward them in CodecImage, and send them to surfacechooser in MCVD.

most of that should be close to copy and paste from avda.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a488ff947b6d63d7867b35a2dffbb1c5d07d592c

commit a488ff947b6d63d7867b35a2dffbb1c5d07d592c
Author: liberato@chromium.org <liberato@chromium.org>
Date: Thu Nov 16 22:41:40 2017

Enable overlays and FrameMetrics in MCVD.

This CL incorporates SurfaceChooserHelper to handle promotion hints
from CodecImage.  It also requests promotion hints in
VideoFrameFactoryImpl.  This adds support for both player-fs and
div-fullscreen cases for overlays to MCVD.

Bug:  781875 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8063a562676af9a0a5532b8434f9fe7fee20b005
Reviewed-on: https://chromium-review.googlesource.com/762061
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Chris Watkins <watk@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517212}
[modify] https://crrev.com/a488ff947b6d63d7867b35a2dffbb1c5d07d592c/media/gpu/android/android_video_decode_accelerator.cc
[modify] https://crrev.com/a488ff947b6d63d7867b35a2dffbb1c5d07d592c/media/gpu/android/codec_image.cc
[modify] https://crrev.com/a488ff947b6d63d7867b35a2dffbb1c5d07d592c/media/gpu/android/codec_image.h
[modify] https://crrev.com/a488ff947b6d63d7867b35a2dffbb1c5d07d592c/media/gpu/android/media_codec_video_decoder.cc
[modify] https://crrev.com/a488ff947b6d63d7867b35a2dffbb1c5d07d592c/media/gpu/android/media_codec_video_decoder.h
[modify] https://crrev.com/a488ff947b6d63d7867b35a2dffbb1c5d07d592c/media/gpu/android/media_codec_video_decoder_unittest.cc
[modify] https://crrev.com/a488ff947b6d63d7867b35a2dffbb1c5d07d592c/media/gpu/android/surface_chooser_helper.cc
[modify] https://crrev.com/a488ff947b6d63d7867b35a2dffbb1c5d07d592c/media/gpu/android/surface_chooser_helper.h
[modify] https://crrev.com/a488ff947b6d63d7867b35a2dffbb1c5d07d592c/media/gpu/android/surface_chooser_helper_unittest.cc
[modify] https://crrev.com/a488ff947b6d63d7867b35a2dffbb1c5d07d592c/media/gpu/android/video_frame_factory.h
[modify] https://crrev.com/a488ff947b6d63d7867b35a2dffbb1c5d07d592c/media/gpu/android/video_frame_factory_impl.cc
[modify] https://crrev.com/a488ff947b6d63d7867b35a2dffbb1c5d07d592c/media/gpu/android/video_frame_factory_impl.h

Status: Fixed (was: Started)

Sign in to add a comment