Cross compiling Chrome for Windows on Linux no longer works |
|||||||||
Issue descriptionLast week, following the instructions in docs/win_cross.md, I was able to build Chrome for Windows on my Linux machine. Today, it no longer works. I get an error about missing 'mt.exe': ---------- $ ninja -C out/win-cross/ unit_tests ninja: Entering directory `out/win-cross/' [1/1] Regenerating ninja files [494/35310] LINK(DLL) chrome_elf.dll chrome_elf.dll.lib chrome_elf.dll.pdb FAILED: chrome_elf.dll chrome_elf.dll.lib chrome_elf.dll.pdb python ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False ../../third_party/llvm-build/Release+Asserts/bin/lld-link --rsp-quoting=posix /nologo /IMPLIB:./chrome_elf.dll.lib /DLL /OUT:./chrome_elf.dll /PDB:./chrome_elf.dll.pdb @./chrome_elf.dll.rsp ../../third_party/llvm-build/Release+Asserts/bin/lld-link: error: unable to find mt.exe in PATH: No such file or directory [543/35310] CXX obj/third_party/pdfium/fpdfapi/cpdf_streamcontentparser.obj ninja: build stopped: subcommand failed. ----------
,
Nov 6 2017
Did we do linking libxml? Any sub-version roll we could revert? This config shouldn't break.
,
Nov 6 2017
Checking with ldd, 315613-2 was the last version where lld-link depended on libxml So we regressed with the roll last Friday: https://chromium-review.googlesource.com/752143 Let me try to find out why..
,
Nov 6 2017
Something changed upstream. Bisecting..
,
Nov 6 2017
It regressed here: --- New Revision: 316064 URL: http://llvm.org/viewvc/llvm-project?rev=316064&view=rev Log: Fix the incorrect detection of ICONV_LIBRARY_PATH This is introduced in rL308711. Check for c library is incorrect here just because libc will be found always and it does not mean that iconv is presented. Thank to Andrew Krasny for narrowing down the root cause. Reviewers: ecbeckmann Reviewed By: ecbeckmann Subscribers: mgorny, llvm-commits Differential Revision: https://reviews.llvm.org/D38875 ---
,
Nov 6 2017
But r308711 is suspicious: why do we gate the libxml2 check on iconv?
,
Nov 6 2017
Revert is in r317517, but we'll need a Clang roll to bring that in. We also need better testing here. The current tests just disable themselves when libxml2 isn't being used, which isn't very helpful.
,
Nov 7 2017
,
Nov 7 2017
having this issue too. I starred the bug! :)
,
Nov 13 2017
The bug was "started" without an owner. Assigning to hans@, since you did some work here. Please re-triage if necessary. Thanks!
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d44709a65174adedba3d4de9979999f946f3343d commit d44709a65174adedba3d4de9979999f946f3343d Author: Hans Wennborg <hans@chromium.org> Date: Wed Nov 15 01:14:08 2017 Clang: configure the build with -DLLVM_ENABLE_LIBXML2=FORCE_ON This makes the build fail if libxml2 cannot be used for some reason. We rely on it for the manifest merging tool used in Windows cross-builds. The flag was introduced in LLVM r318209. Bug: 781873 Change-Id: I3bea539061601d4eaf151ca138d5ba398918e9c9 Reviewed-on: https://chromium-review.googlesource.com/769675 Reviewed-by: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#516541} [modify] https://crrev.com/d44709a65174adedba3d4de9979999f946f3343d/tools/clang/scripts/update.py
,
Nov 15 2017
,
Nov 21 2017
(infra bug triager here, triaging infra bugs)
,
Nov 27 2017
The Clang roll appears to be sticking.
,
Dec 14 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by alito@chromium.org
, Nov 6 2017