New issue
Advanced search Search tips

Issue 781870 link

Starred by 2 users
Status: Fixed
Owner:
dmu...@chromium.org
Closed: Jan 3
Cc:
jam@chromium.org
mek@chromium.org
dmu...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 873895
issue 874906



Sign in to add a comment

Onion soupify DOMStorage

Project Member Reported by mek@chromium.org, Nov 6 2017 
Now that localstorage is mojofied, we should also onion-soupify it, and move the renderer side code fully into blink.

This might be simpler after session storage is also mojofied (since then we'd just have one codepath to deal with), but should be possible to do even now.

Comment 1 by jam@chromium.org, Mar 15 2018

Cc: jam@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de

commit f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Thu Jun 07 18:57:12 2018

[DOMStorage] Move leveldb_wrapper.mojom to blink in preparation for onion souping.

Also rename from LevelDBWrapper to StorageArea to better reflect what
the interface is used for.

Bug:  781870 ,  809771 
Change-Id: I712fee920d95f5e18dc6bfa74d1277c8aed4bd19
Reviewed-on: https://chromium-review.googlesource.com/1087495
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565365}
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/dom_storage_context_wrapper.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/dom_storage_context_wrapper.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/local_storage_context_mojo.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/local_storage_context_mojo.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/local_storage_context_mojo_unittest.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_context_mojo.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_context_mojo_unittest.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_data_map.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_data_map_unittest.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_leveldb_wrapper.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_leveldb_wrapper.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_leveldb_wrapper_unittest.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_namespace_impl_mojo.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_namespace_impl_mojo.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/dom_storage/session_storage_namespace_impl_mojo_unittest.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/isolated_origin_browsertest.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/leveldb_wrapper_impl.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/leveldb_wrapper_impl.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/leveldb_wrapper_impl_unittest.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/browser/storage_partition_impl.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/common/BUILD.gn
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/common/storage_partition_service.mojom
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/renderer/dom_storage/local_storage_cached_area.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/renderer/dom_storage/local_storage_cached_area.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/renderer/dom_storage/local_storage_cached_area_unittest.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/renderer/dom_storage/mock_leveldb_wrapper.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/renderer/dom_storage/mock_leveldb_wrapper.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/test/leveldb_wrapper_test_util.cc
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/content/test/leveldb_wrapper_test_util.h
[modify] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/third_party/blink/public/mojom/dom_storage/OWNERS
[rename] https://crrev.com/f9a9e76e9b4f8a224c450b5cc1aca4a4074ff4de/third_party/blink/public/mojom/dom_storage/storage_area.mojom
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9431b8d6b7cd427065672e680a91a1289ad1642

commit e9431b8d6b7cd427065672e680a91a1289ad1642
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Tue Jun 12 02:10:23 2018

[DOMStorage] Merge StorageArea and Storage classes.

There was always a 1:1 mapping between Storage and StorageArea anyway,
so just merge the two classes by moving all the functionality into
StorageArea directly. Having one less layer of abstraction should make
things less confusing when it comes to bigger onion soup related refactorings.

Bug:  781870 
Change-Id: Iad19d7df81f15d6a9b9bdfecd22d16e98a0817f0
Reviewed-on: https://chromium-review.googlesource.com/1091926
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566272}
[modify] https://crrev.com/e9431b8d6b7cd427065672e680a91a1289ad1642/third_party/blink/renderer/modules/storage/BUILD.gn
[modify] https://crrev.com/e9431b8d6b7cd427065672e680a91a1289ad1642/third_party/blink/renderer/modules/storage/OWNERS
[modify] https://crrev.com/e9431b8d6b7cd427065672e680a91a1289ad1642/third_party/blink/renderer/modules/storage/dom_window_storage.cc
[modify] https://crrev.com/e9431b8d6b7cd427065672e680a91a1289ad1642/third_party/blink/renderer/modules/storage/dom_window_storage.h
[modify] https://crrev.com/e9431b8d6b7cd427065672e680a91a1289ad1642/third_party/blink/renderer/modules/storage/inspector_dom_storage_agent.cc
[modify] https://crrev.com/e9431b8d6b7cd427065672e680a91a1289ad1642/third_party/blink/renderer/modules/storage/inspector_dom_storage_agent.h
[delete] https://crrev.com/77f7cd850429efba96fa186673cef17ba90c17f0/third_party/blink/renderer/modules/storage/storage.cc
[delete] https://crrev.com/77f7cd850429efba96fa186673cef17ba90c17f0/third_party/blink/renderer/modules/storage/storage.h
[modify] https://crrev.com/e9431b8d6b7cd427065672e680a91a1289ad1642/third_party/blink/renderer/modules/storage/storage.idl
[modify] https://crrev.com/e9431b8d6b7cd427065672e680a91a1289ad1642/third_party/blink/renderer/modules/storage/storage_area.cc
[modify] https://crrev.com/e9431b8d6b7cd427065672e680a91a1289ad1642/third_party/blink/renderer/modules/storage/storage_area.h
[modify] https://crrev.com/e9431b8d6b7cd427065672e680a91a1289ad1642/third_party/blink/renderer/modules/storage/storage_event.cc
[modify] https://crrev.com/e9431b8d6b7cd427065672e680a91a1289ad1642/third_party/blink/renderer/modules/storage/storage_event.h
[modify] https://crrev.com/e9431b8d6b7cd427065672e680a91a1289ad1642/third_party/blink/renderer/modules/storage/storage_namespace.cc
[modify] https://crrev.com/e9431b8d6b7cd427065672e680a91a1289ad1642/third_party/blink/renderer/modules/storage/storage_namespace.h
[modify] https://crrev.com/e9431b8d6b7cd427065672e680a91a1289ad1642/third_party/blink/renderer/modules/storage/storage_namespace_controller.cc
[modify] https://crrev.com/e9431b8d6b7cd427065672e680a91a1289ad1642/third_party/blink/renderer/modules/storage/storage_namespace_controller.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc60341f02ca54a2beed21cf8950202ee31b645d

commit bc60341f02ca54a2beed21cf8950202ee31b645d
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Wed Jun 13 00:16:14 2018

[DOMStorage] Add a UseCounter to measure need for reverse-iteration optimization.

The current domstorage implementation has an optimization to make
reverse iterating over all the keys in a storage area fast. Keeping that
optimization after onion-souping would be tricky, so add a use counter
to see how many pages actually do anything that hits this case.

Bug:  781870 
Change-Id: Ie5b83858842c01d9ac4d8fb8dc31cdaf5738d3ee
Reviewed-on: https://chromium-review.googlesource.com/1098025
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566640}
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/common/dom_storage/dom_storage_map.cc
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/common/dom_storage/dom_storage_map.h
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/dom_storage_cached_area.cc
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/dom_storage_cached_area.h
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/local_storage_area.cc
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/local_storage_area.h
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/local_storage_cached_area.cc
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/local_storage_cached_area.h
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/webstoragearea_impl.cc
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/webstoragearea_impl.h
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/third_party/blink/public/platform/web_storage_area.h
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/third_party/blink/renderer/modules/storage/storage_area.cc
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/tools/metrics/histograms/enums.xml
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc60341f02ca54a2beed21cf8950202ee31b645d

commit bc60341f02ca54a2beed21cf8950202ee31b645d
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Wed Jun 13 00:16:14 2018

[DOMStorage] Add a UseCounter to measure need for reverse-iteration optimization.

The current domstorage implementation has an optimization to make
reverse iterating over all the keys in a storage area fast. Keeping that
optimization after onion-souping would be tricky, so add a use counter
to see how many pages actually do anything that hits this case.

Bug:  781870 
Change-Id: Ie5b83858842c01d9ac4d8fb8dc31cdaf5738d3ee
Reviewed-on: https://chromium-review.googlesource.com/1098025
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566640}
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/common/dom_storage/dom_storage_map.cc
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/common/dom_storage/dom_storage_map.h
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/dom_storage_cached_area.cc
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/dom_storage_cached_area.h
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/local_storage_area.cc
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/local_storage_area.h
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/local_storage_cached_area.cc
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/local_storage_cached_area.h
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/webstoragearea_impl.cc
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/webstoragearea_impl.h
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/third_party/blink/public/platform/web_storage_area.h
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/third_party/blink/renderer/modules/storage/storage_area.cc
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/tools/metrics/histograms/enums.xml
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc60341f02ca54a2beed21cf8950202ee31b645d

commit bc60341f02ca54a2beed21cf8950202ee31b645d
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Wed Jun 13 00:16:14 2018

[DOMStorage] Add a UseCounter to measure need for reverse-iteration optimization.

The current domstorage implementation has an optimization to make
reverse iterating over all the keys in a storage area fast. Keeping that
optimization after onion-souping would be tricky, so add a use counter
to see how many pages actually do anything that hits this case.

Bug:  781870 
Change-Id: Ie5b83858842c01d9ac4d8fb8dc31cdaf5738d3ee
Reviewed-on: https://chromium-review.googlesource.com/1098025
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566640}
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/common/dom_storage/dom_storage_map.cc
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/common/dom_storage/dom_storage_map.h
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/dom_storage_cached_area.cc
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/dom_storage_cached_area.h
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/local_storage_area.cc
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/local_storage_area.h
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/local_storage_cached_area.cc
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/local_storage_cached_area.h
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/webstoragearea_impl.cc
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/content/renderer/dom_storage/webstoragearea_impl.h
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/third_party/blink/public/platform/web_storage_area.h
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/third_party/blink/renderer/modules/storage/storage_area.cc
[modify] https://crrev.com/bc60341f02ca54a2beed21cf8950202ee31b645d/tools/metrics/histograms/enums.xml
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4712c33d1913a2efcb72c8bb79ac8a464b174252

commit 4712c33d1913a2efcb72c8bb79ac8a464b174252
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Wed Jun 13 19:06:59 2018

[DOMStorage] Move other DOMStorage mojom files to blink as well.

In preparation of eventual onion souping DOMStorage this move the
SessionStorageNamespace and StoragePartitionService mojom interfaces
to blink/public/mojom as well, splitting them up in each their own
file in the process.

Tbr: dgozman@chromium.org
Bug:  781870 
Change-Id: Icf85fee3eb327d81d2eee1cc68ce89b255cd13b4
Reviewed-on: https://chromium-review.googlesource.com/1087406
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566938}
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/browser/dom_storage/dom_storage_context_wrapper.cc
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/browser/dom_storage/dom_storage_context_wrapper.h
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/browser/dom_storage/session_storage_context_mojo.cc
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/browser/dom_storage/session_storage_context_mojo.h
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/browser/dom_storage/session_storage_context_mojo_unittest.cc
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/browser/dom_storage/session_storage_namespace_impl_mojo.cc
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/browser/dom_storage/session_storage_namespace_impl_mojo.h
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/browser/dom_storage/session_storage_namespace_impl_mojo_unittest.cc
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/browser/isolated_origin_browsertest.cc
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/browser/storage_partition_impl.h
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/common/BUILD.gn
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/renderer/dom_storage/local_storage_cached_area.cc
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/renderer/dom_storage/local_storage_cached_area.h
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/renderer/dom_storage/local_storage_cached_areas.cc
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/renderer/dom_storage/local_storage_cached_areas.h
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/renderer/dom_storage/mock_leveldb_wrapper.cc
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/renderer/dom_storage/mock_leveldb_wrapper.h
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/content/renderer/render_thread_impl.h
[modify] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/third_party/blink/public/mojom/dom_storage/session_storage_namespace.mojom
[add] https://crrev.com/4712c33d1913a2efcb72c8bb79ac8a464b174252/third_party/blink/public/mojom/dom_storage/storage_partition_service.mojom
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f50c6b1577b7f1f15084bea80a3fc34f6005dfcb

commit f50c6b1577b7f1f15084bea80a3fc34f6005dfcb
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Sat Jun 23 00:29:20 2018

[DOMStorage] Introduce blink::StorageAreaMap.

This is the blink equivalent of a slimmed down content::DOMStorageMap.
Important differences:
 - This version always stores both keys and values. DOMStorageMap has a
   mode where only keys are stored, but that is only used in the browser
   process so is not needed in this blink version.
 - For now this version is less efficient than DOMStorageMap if GetKey
   is used to iterate over the map backwards. This is because blink's
   HashMap iterators currently don't support operator--. If needed we'll
   add that support later.

Bug:  781870 
Tbr: jbroman@chromium.org
Change-Id: I0f2733322a8acb67690abb918776ab2c72159d2a
Reviewed-on: https://chromium-review.googlesource.com/1103144
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569856}
[modify] https://crrev.com/f50c6b1577b7f1f15084bea80a3fc34f6005dfcb/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/f50c6b1577b7f1f15084bea80a3fc34f6005dfcb/third_party/blink/renderer/modules/storage/BUILD.gn
[add] https://crrev.com/f50c6b1577b7f1f15084bea80a3fc34f6005dfcb/third_party/blink/renderer/modules/storage/README.md
[add] https://crrev.com/f50c6b1577b7f1f15084bea80a3fc34f6005dfcb/third_party/blink/renderer/modules/storage/storage_area_map.cc
[add] https://crrev.com/f50c6b1577b7f1f15084bea80a3fc34f6005dfcb/third_party/blink/renderer/modules/storage/storage_area_map.h
[add] https://crrev.com/f50c6b1577b7f1f15084bea80a3fc34f6005dfcb/third_party/blink/renderer/modules/storage/storage_area_map_test.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dad9b95058d6cfce9cffbc4a2065fa71fdb70a23

commit dad9b95058d6cfce9cffbc4a2065fa71fdb70a23
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Thu Jun 28 03:07:52 2018

[DOMStorage] Add reverse iteration optimization to blink::StorageAreaMap.

This makes the performance of blink::StorageAreaMap closer to that of
content::DOMStorageMap. In particular this makes any kind of reverse
iteration over a storage area less inefficient (not sure why people
would do so though).

Bug:  781870 
Change-Id: I6f313c65868a21de8b0d2fbdff526a23895baa57
Reviewed-on: https://chromium-review.googlesource.com/1117206
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571017}
[modify] https://crrev.com/dad9b95058d6cfce9cffbc4a2065fa71fdb70a23/third_party/blink/renderer/modules/storage/storage_area_map.cc
[modify] https://crrev.com/dad9b95058d6cfce9cffbc4a2065fa71fdb70a23/third_party/blink/renderer/modules/storage/storage_area_map_test.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1571d750d7217703d89c44562678eddde611ad50

commit 1571d750d7217703d89c44562678eddde611ad50
Author: Daniel Murphy <dmurph@chromium.org>
Date: Fri Aug 10 21:16:18 2018

[DOMStorage] blink::CachedStorageArea for onion souping

As part of onion souping domstorage this adds a couple of new classes
to blink more or less duplicating the content equivalents:

CachedStorageArea matches content::LocalStorageCachedArea (with some
minor API changes, in particular around how it acquires a mojom
StorageArea). Also has improved test coverage compared to the content
version.

MockStorageArea is very similar to content::MockLevelDBWrapper (with
the difference that it doesn't implement StoragePartitionService since
it doesn't need to with the changed API of CachedStorageArea).

Bug:  781870 
Change-Id: Ic64b3bf307fe275d9287669743f186c8470847bb
Reviewed-on: https://chromium-review.googlesource.com/1166218
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582334}
[modify] https://crrev.com/1571d750d7217703d89c44562678eddde611ad50/third_party/blink/public/mojom/dom_storage/storage_area.mojom
[modify] https://crrev.com/1571d750d7217703d89c44562678eddde611ad50/third_party/blink/renderer/modules/DEPS
[modify] https://crrev.com/1571d750d7217703d89c44562678eddde611ad50/third_party/blink/renderer/modules/storage/BUILD.gn
[add] https://crrev.com/1571d750d7217703d89c44562678eddde611ad50/third_party/blink/renderer/modules/storage/cached_storage_area.cc
[add] https://crrev.com/1571d750d7217703d89c44562678eddde611ad50/third_party/blink/renderer/modules/storage/cached_storage_area.h
[add] https://crrev.com/1571d750d7217703d89c44562678eddde611ad50/third_party/blink/renderer/modules/storage/cached_storage_area_test.cc
[add] https://crrev.com/1571d750d7217703d89c44562678eddde611ad50/third_party/blink/renderer/modules/storage/testing/fake_area_source.h
[add] https://crrev.com/1571d750d7217703d89c44562678eddde611ad50/third_party/blink/renderer/modules/storage/testing/mock_storage_area.cc
[add] https://crrev.com/1571d750d7217703d89c44562678eddde611ad50/third_party/blink/renderer/modules/storage/testing/mock_storage_area.h

Comment 12 by dmu...@chromium.org, Aug 15

Owner: dmu...@chromium.org
Status: Assigned (was: Available)

Comment 13 by dmu...@chromium.org, Aug 15

Blocking: 873895

Comment 14 by dmurph@google.com, Sep 17

Blocking: 874906
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cd35197a7b609719b130608790861339307b013

commit 1cd35197a7b609719b130608790861339307b013
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Wed Sep 19 20:27:21 2018

Remove DefaultHash<scoped_refptr<const SecurityOrigin>>.

The existance of this DefaultHash implementation is potentially problematic
for several reasons:

- DefaultHash<scoped_refptr<T>> exists as well, making it very easy to end up
  with ODR violations where different translation units end up with different
  types for a HashSet<scoped_refptr<const SecurityOrigin>>.
- It is not obvious what "equality" the hash implements, since there are at
  least two equally valid definitions of equality for origins ("same origin"
  vs "same origin-domain").

Currently no code is actually using this hash, but our upcoming DOMStorage
onion souping will want a hash that implements same origin equality, so
for that this also changes the implementation to implement that version of
equality.

Bug:  781870 
Change-Id: I79d8820194b51cb81ba4bf0684e65cba575dba82
Reviewed-on: https://chromium-review.googlesource.com/1229357
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592536}
[modify] https://crrev.com/1cd35197a7b609719b130608790861339307b013/third_party/blink/renderer/modules/webdatabase/database_tracker.cc
[modify] https://crrev.com/1cd35197a7b609719b130608790861339307b013/third_party/blink/renderer/platform/loader/fetch/memory_cache.cc
[modify] https://crrev.com/1cd35197a7b609719b130608790861339307b013/third_party/blink/renderer/platform/weborigin/security_origin_hash.h

Comment 16 by jsb...@chromium.org, Sep 20

Status: Started (was: Assigned)

Comment 17 by jsb...@chromium.org, Sep 20

Labels: Hotlist-CodeHealth
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95792efb1e0eb03422a041766a0df4929ca4ff7d

commit 95792efb1e0eb03422a041766a0df4929ca4ff7d
Author: Daniel Murphy <dmurph@chromium.org>
Date: Thu Oct 04 01:29:55 2018

[DOMStorage] Onion Soup work on StorageNamespace, adding flag and tests.

This change adds all of the OnionSoup mojo pointers to StorageNamespace,
and creates a new global called StorageController. This inherits most of
the functionality of the StorageNamespaceController but adds the
necessary mojo pointers.

The inspector agents are moved to live in the StorageNamespaces. This
facilitates how they will be used after the event dispatching model is
changed for onion-souping.

Bug:  781870 
Change-Id: I0bf0b7fffcf9c6b6870b636954f130b655642a0c
Reviewed-on: https://chromium-review.googlesource.com/c/1232195
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596468}
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/content/browser/dom_storage/dom_storage_context_impl.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/content/browser/dom_storage/session_storage_metadata.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/content/browser/dom_storage/session_storage_namespace_impl.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/content/common/BUILD.gn
[delete] https://crrev.com/e67fc19f0ea8972bbfc8f88202c727a905fd582f/content/common/dom_storage/dom_storage_namespace_ids.h
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/content/public/test/mock_render_thread.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/content/public/test/render_view_test.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/content/renderer/dom_storage/local_storage_cached_areas.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/content/renderer/render_view_impl.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/common/BUILD.gn
[rename] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/common/dom_storage/session_storage_namespace_id.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/common/features.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/public/common/BUILD.gn
[add] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/public/common/dom_storage/session_storage_namespace_id.h
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/public/common/features.h
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/DEPS
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/core/dom/idle_deadline_test.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/modules/modules_initializer.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/modules/storage/BUILD.gn
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/modules/storage/README.md
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/modules/storage/cached_storage_area.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/modules/storage/cached_storage_area.h
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/modules/storage/cached_storage_area_test.cc
[add] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/modules/storage/docs/ownership.png
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/modules/storage/dom_window_storage.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/modules/storage/inspector_dom_storage_agent.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/modules/storage/storage_area.cc
[add] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/modules/storage/storage_controller.cc
[add] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/modules/storage/storage_controller.h
[add] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/modules/storage/storage_controller_test.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/modules/storage/storage_namespace.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/modules/storage/storage_namespace.h
[delete] https://crrev.com/e67fc19f0ea8972bbfc8f88202c727a905fd582f/third_party/blink/renderer/modules/storage/storage_namespace_controller.cc
[delete] https://crrev.com/e67fc19f0ea8972bbfc8f88202c727a905fd582f/third_party/blink/renderer/modules/storage/storage_namespace_controller.h
[add] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/modules/storage/storage_namespace_test.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/modules/storage/testing/fake_area_source.h
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/platform/scheduler/common/simple_thread_scheduler.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/platform/scheduler/common/simple_thread_scheduler.h
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/platform/scheduler/public/thread_scheduler.h
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.h
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc
[modify] https://crrev.com/95792efb1e0eb03422a041766a0df4929ca4ff7d/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8e991abf6c9999948a637546defc101d41d5dcd

commit c8e991abf6c9999948a637546defc101d41d5dcd
Author: Daniel Murphy <dmurph@chromium.org>
Date: Fri Oct 12 22:09:03 2018

[DOMStorage] Onion soup complete behind a flag

      It should go away once the "old way" is removed.

Binary-Size: Increase is temporary due to a "new way" / "old way" refactoring.
Bug:  781870 
Change-Id: I0425be19fddd9d198e71ed5e6a884b7077f9ffdf
Reviewed-on: https://chromium-review.googlesource.com/c/1263283
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599375}
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/content/browser/dom_storage/dom_storage_browsertest.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/content/browser/dom_storage/dom_storage_context_wrapper.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/content/browser/dom_storage/session_storage_context_mojo.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/content/browser/dom_storage/session_storage_context_mojo_unittest.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/content/browser/dom_storage/session_storage_namespace_impl.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/content/public/common/content_features.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/content/public/common/content_features.h
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/content/renderer/dom_storage/local_storage_cached_areas.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/content/renderer/dom_storage/local_storage_cached_areas_unittest.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/content/renderer/render_view_impl.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/content/renderer/render_view_impl.h
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/content/shell/test_runner/web_view_test_client.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/content/shell/test_runner/web_view_test_client.h
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/content/shell/test_runner/web_view_test_proxy.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/content/shell/test_runner/web_view_test_proxy.h
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/public/web/web_view_client.h
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/renderer/core/core_initializer.h
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/renderer/core/loader/empty_clients.h
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/renderer/core/page/chrome_client.h
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/renderer/core/page/chrome_client_impl.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/renderer/core/page/chrome_client_impl.h
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/renderer/core/page/chrome_client_impl_test.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/renderer/core/page/create_window.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/renderer/core/testing/sim/sim_web_view_client.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/renderer/core/testing/sim/sim_web_view_client.h
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/renderer/modules/modules_initializer.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/renderer/modules/modules_initializer.h
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/renderer/modules/storage/dom_window_storage.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/renderer/modules/storage/inspector_dom_storage_agent.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/renderer/modules/storage/storage_area.cc
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/renderer/modules/storage/storage_area.h
[modify] https://crrev.com/c8e991abf6c9999948a637546defc101d41d5dcd/third_party/blink/renderer/modules/storage/storage_namespace.cc
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80ce30280a48850aad465138b84fe209474733e8

commit 80ce30280a48850aad465138b84fe209474733e8
Author: Daniel Murphy <dmurph@chromium.org>
Date: Thu Oct 18 07:28:07 2018

[DOMStorage] Enable onion soup codepath

R=mek@chromium.org

Bug:  781870 
Change-Id: Ic1b3846812f99520300dbad5e4082921043e673a
Reviewed-on: https://chromium-review.googlesource.com/c/1286204
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600681}
[modify] https://crrev.com/80ce30280a48850aad465138b84fe209474733e8/third_party/blink/common/features.cc

Comment 21 by dmu...@chromium.org, Jan 3

Status: Fixed (was: Started)
Done! Creating new bug to track cleanup:
https://bugs.chromium.org/p/chromium/issues/detail?id=918910
►

Sign in to add a comment