[Local-NTP] If you shrink the NTP vertically some px of the bottom of the tiles are overlapping by the white bottom bar before they hide. |
|||||||
Issue descriptionChrome Version: 64.0.3260.0 (Official Build) canary (64-bit) OS: macOS 10.12.6 What steps will reproduce the problem? (1) Enable the Local-NTP (2) Open a NTP (3) Compare the NewTabPage's vertical and horizontally window shrinking. What is the expected result? If you shrink the NTP vertically, the tiles should already hide some px before the white bottom bar overlaps the tiles. It works correct without any overlapping when you shrink the window horizontally. What happens instead? If you shrink the NTP vertically some px of the tiles are overlapping by the white bottom bar before they hide. This happened after https://chromium-review.googlesource.com/726079. Two screencasts are attached. If you need more information, please let me know. Thanks for looking into the bug. Mehmet
,
Nov 7 2017
Not a blink layout problem, just not-quite-correct CSS on the NTP. Also (most likely) not Mac-specific.
,
Nov 7 2017
,
Nov 7 2017
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/295060d5a6cb3d2c44c003dc992efd1ddd771424 commit 295060d5a6cb3d2c44c003dc992efd1ddd771424 Author: Marc Treib <treib@chromium.org> Date: Wed Nov 08 18:08:42 2017 Local NTP: fine-tune min-height values for showing rows of tiles This CL increases the min-height for showing 1 or 2 rows by 4px each, to leave space for the bottom shadow between the tiles. Bug: 755761, 781866 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I371590d17fd59d3d2275e18cc429a0ba31232b94 Reviewed-on: https://chromium-review.googlesource.com/756850 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#514881} [modify] https://crrev.com/295060d5a6cb3d2c44c003dc992efd1ddd771424/chrome/browser/resources/local_ntp/local_ntp.css [modify] https://crrev.com/295060d5a6cb3d2c44c003dc992efd1ddd771424/chrome/browser/resources/local_ntp/most_visited_single.css
,
Nov 9 2017
,
Nov 9 2017
Tested the issue on windows 10, Mac os 10.12.6 , ubuntu 14.04 using chrome M64 #64.0.3263.0 and followed the steps mentioned in comment #0. And observed that issue is working as intended/expected. Attached screencast for reference. @treib-- Could you please check attached screencast and confirm us if this is working as expected and if we can add TE-verified Labels. Thanks!
,
Nov 9 2017
As far as I can tell, that looks like it should, though it's hard to tell in that video. If you look at the "not_okay_vertically.mov" attached to the original report, you can see that the issue was quite subtle. Try slowly resizing the window vertically, and check if the bottom of the tiles gets hidden by the white bottom bar.
,
Nov 11 2017
Great, looks good to me in Chrome Canary 64.0.3265.0 on macOS 10.12.6. hdodda@: You can add the TE-verified Labels. Thanks. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by meh...@chromium.org
, Nov 6 2017Status: Assigned (was: Untriaged)