New issue
Advanced search Search tips

Issue 781863 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

[Select-to-Speak] When per-word highlighting is off, STS should highlight entire paragraphs

Project Member Reported by katie@chromium.org, Nov 6 2017

Issue description

As a companion to https://bugs.chromium.org/p/chromium/issues/detail?id=676451, the normal focus ring shouldn't jump from node to node, but from block to block.
 

Comment 1 by katie@chromium.org, Nov 9 2017

Components: UI>Accessibility
Status: Assigned (was: Untriaged)

Comment 2 by katie@chromium.org, Nov 10 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0306422953dc7c42baf1da8d2ba92e5210b1e95e

commit 0306422953dc7c42baf1da8d2ba92e5210b1e95e
Author: Katie Dektar <katydek@google.com>
Date: Wed Nov 15 06:22:13 2017

Highlights parent blocks with focus ring in Select-to-Speak.

Whether word highlighting is on or off, the focus ring should be
placed around the nearest block parent.

This is based off discussion with lpalmaro@.

Bug:  781863 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id5cd8d6c3d145d3384fd152be4bfdfda99e3566c
Reviewed-on: https://chromium-review.googlesource.com/764430
Commit-Queue: Katie D <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516607}
[modify] https://crrev.com/0306422953dc7c42baf1da8d2ba92e5210b1e95e/chrome/browser/resources/chromeos/select_to_speak/paragraph_utils.js
[modify] https://crrev.com/0306422953dc7c42baf1da8d2ba92e5210b1e95e/chrome/browser/resources/chromeos/select_to_speak/paragraph_utils_unittest.gtestjs
[modify] https://crrev.com/0306422953dc7c42baf1da8d2ba92e5210b1e95e/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js

Comment 4 by katie@chromium.org, Nov 29 2017

Status: Fixed (was: Started)

Sign in to add a comment