New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781857 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[Local-NTP] The Google Bar's bottom border is missing when you shrink the window and it is too close to the window's bottom border

Project Member Reported by meh...@chromium.org, Nov 6 2017

Issue description

Chrome Version: 64.0.3260.0 (Official Build) canary (64-bit)
OS: macOS 10.12.6

What steps will reproduce the problem?
(1) Enable the Local-NTP
(2) Open a NTP
(3) Shrink the window to a very small state

What is the expected result?
Between the window bottom border and the Google Bar bottom border could be some px space and the Google Bar's bottom border could be visible.

What happens instead?
The Google Bar's bottom border is missing and the Google Bar is too close to the window bottom border.

This happened after https://chromium-review.googlesource.com/726079.

A screencast is attached.

Thanks for looking into this issue.
 
local_ntp_google_bar.mov
2.7 MB Download
Components: Blink>Layout
Status: Assigned (was: Untriaged)

Comment 3 by e...@chromium.org, Nov 6 2017

Labels: Needs-Feedback
Could you please include instructions for how to enable the local-ntp and a screenshot showing the problem please?

Comment 4 by treib@chromium.org, Nov 7 2017

You can enable the local NTP via chrome://flags/#use-google-local-ntp, or just visit chrome-search://local-ntp/local-ntp.html as a one-off.

Comment 5 by treib@chromium.org, Nov 7 2017

Components: -Blink>Layout
This is probably caused by an "overflow: hidden" which makes the off-screen part of the search bar invisible. Should be fixed by making the page's min-height a bit bigger. (BTW, how do you trigger that overscroll effect which makes the missing bottom border visible?)
Anyway, I don't think there's any problem in Blink/layout here, so removing that label.

A different problem shown in the video is that the OneGoogleBar overlaps the Google logo at small sizes. I'll look into that separately.

Comment 6 by treib@chromium.org, Nov 7 2017

Status: Started (was: Assigned)

Comment 7 by treib@chromium.org, Nov 7 2017

Labels: -Needs-Feedback M-64
Hello treib@,

> (BTW, how do you trigger that overscroll effect which makes the missing bottom border visible?)

On macOS the overscroll (rubberbanding) effect appears automatically when you reach the end of the page. 

Thanks for looking into the issue. 

Comment 9 by treib@chromium.org, Nov 7 2017

The rubberbanding doesn't happen for me. Maybe it only appears if you scroll via touch, not via keyboard or mouse? (I don't have a touchscreen on my Mac machine.)

Anyway, pending CL that fixes the issue is here: https://chromium-review.googlesource.com/c/chromium/src/+/756849
Should land any minute now :)
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcecc755b5d69c77ac886da761dcf46972abf1b8

commit bcecc755b5d69c77ac886da761dcf46972abf1b8
Author: Marc Treib <treib@chromium.org>
Date: Tue Nov 07 15:33:44 2017

Local NTP: Give the fakebox a bottom margin

The top margin of the most visited section is reduced to compensate.

The fakebox margin covers the bottom shadow, and effectively increases
the minimum height of the page. This makes a difference for small
window heights.

Bug:  781857 , 755761
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7d541d5f4a93d4418b6528c763a877eadc0a0b20
Reviewed-on: https://chromium-review.googlesource.com/756849
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514474}
[modify] https://crrev.com/bcecc755b5d69c77ac886da761dcf46972abf1b8/chrome/browser/resources/local_ntp/local_ntp.css

Status: Fixed (was: Started)
Checked in latest Snapshot 514483. Looks great and fixed for me - please see the screencast! Thank you for quick fix.

BTW: With touch you mean Trackpad, right? Yes, the rubberbanding appears for me with Trackpad and AppleMagicMouse. (Maybe it doesn't appear with "classic" mouses?)
fixed.mov
424 KB Download
Yup, I used a plain old (non-Mac) mouse. That explains it I guess.

Thanks for verifying!
Status: Verified (was: Fixed)
You're welcome. Don't worry about the mouse - I'm using a device from 2012 :-)
Cc: hdodda@chromium.org
Labels: TE-Verified-M64 TE-Verified-64.0.3262.0
Tested the issue on Mac OS 10.12.6 using chrome M64 #64.0.3262.0 and issue seems to be fixed.

Observed the space Between the window bottom border and the Google Bar bottom border  and the Google Bar's bottom border is visible.

Attached screencast for reference.

Adding TE-Verified Labels.

Thanks!

781857.mp4
743 KB View Download

Sign in to add a comment