Issue metadata
Sign in to add a comment
|
[Local-NTP] The Google Bar's bottom border is missing when you shrink the window and it is too close to the window's bottom border |
||||||||||||||||||||||
Issue descriptionChrome Version: 64.0.3260.0 (Official Build) canary (64-bit) OS: macOS 10.12.6 What steps will reproduce the problem? (1) Enable the Local-NTP (2) Open a NTP (3) Shrink the window to a very small state What is the expected result? Between the window bottom border and the Google Bar bottom border could be some px space and the Google Bar's bottom border could be visible. What happens instead? The Google Bar's bottom border is missing and the Google Bar is too close to the window bottom border. This happened after https://chromium-review.googlesource.com/726079. A screencast is attached. Thanks for looking into this issue.
,
Nov 6 2017
,
Nov 6 2017
Could you please include instructions for how to enable the local-ntp and a screenshot showing the problem please?
,
Nov 7 2017
You can enable the local NTP via chrome://flags/#use-google-local-ntp, or just visit chrome-search://local-ntp/local-ntp.html as a one-off.
,
Nov 7 2017
This is probably caused by an "overflow: hidden" which makes the off-screen part of the search bar invisible. Should be fixed by making the page's min-height a bit bigger. (BTW, how do you trigger that overscroll effect which makes the missing bottom border visible?) Anyway, I don't think there's any problem in Blink/layout here, so removing that label. A different problem shown in the video is that the OneGoogleBar overlaps the Google logo at small sizes. I'll look into that separately.
,
Nov 7 2017
,
Nov 7 2017
,
Nov 7 2017
Hello treib@, > (BTW, how do you trigger that overscroll effect which makes the missing bottom border visible?) On macOS the overscroll (rubberbanding) effect appears automatically when you reach the end of the page. Thanks for looking into the issue.
,
Nov 7 2017
The rubberbanding doesn't happen for me. Maybe it only appears if you scroll via touch, not via keyboard or mouse? (I don't have a touchscreen on my Mac machine.) Anyway, pending CL that fixes the issue is here: https://chromium-review.googlesource.com/c/chromium/src/+/756849 Should land any minute now :)
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcecc755b5d69c77ac886da761dcf46972abf1b8 commit bcecc755b5d69c77ac886da761dcf46972abf1b8 Author: Marc Treib <treib@chromium.org> Date: Tue Nov 07 15:33:44 2017 Local NTP: Give the fakebox a bottom margin The top margin of the most visited section is reduced to compensate. The fakebox margin covers the bottom shadow, and effectively increases the minimum height of the page. This makes a difference for small window heights. Bug: 781857 , 755761 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7d541d5f4a93d4418b6528c763a877eadc0a0b20 Reviewed-on: https://chromium-review.googlesource.com/756849 Reviewed-by: Chris Pickel <sfiera@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#514474} [modify] https://crrev.com/bcecc755b5d69c77ac886da761dcf46972abf1b8/chrome/browser/resources/local_ntp/local_ntp.css
,
Nov 7 2017
,
Nov 7 2017
Checked in latest Snapshot 514483. Looks great and fixed for me - please see the screencast! Thank you for quick fix. BTW: With touch you mean Trackpad, right? Yes, the rubberbanding appears for me with Trackpad and AppleMagicMouse. (Maybe it doesn't appear with "classic" mouses?)
,
Nov 7 2017
Yup, I used a plain old (non-Mac) mouse. That explains it I guess. Thanks for verifying!
,
Nov 7 2017
You're welcome. Don't worry about the mouse - I'm using a device from 2012 :-)
,
Nov 8 2017
Tested the issue on Mac OS 10.12.6 using chrome M64 #64.0.3262.0 and issue seems to be fixed. Observed the space Between the window bottom border and the Google Bar bottom border and the Google Bar's bottom border is visible. Attached screencast for reference. Adding TE-Verified Labels. Thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by spqc...@chromium.org
, Nov 6 2017